OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

PR c/99055 - memory leak in warn_parm_array_mismatch

Browse Source 
gcc/c-family/ChangeLog:

	PR c/99055
	* c-warn.c (warn_parm_array_mismatch): Free strings returned from
	print_generic_expr_to_str.

gcc/ChangeLog:

	* tree-pretty-print.c (print_generic_expr_to_str): Update comment.
This commit is contained in:
Martin Sebor 2021-02-12 11:18:17 -07:00
parent 0631e008ad
commit f3d7fd1475
2 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
gcc/c-family/c-warn.c
View File

@ -3319,6 +3319,19 @@ warn_parm_ptrarray_mismatch (location_t origloc, tree curparms, tree newparms)
}
}
/* Format EXPR if nonnull and return the formatted string. If EXPR is
null return DFLT. */
static inline const char*
expr_to_str (pretty_printer &pp, tree expr, const char *dflt)
{
if (!expr)
return dflt;
dump_generic_node (&pp, expr, 0, TDF_VOPS | TDF_MEMSYMS, false);
return pp_formatted_text (&pp);
}
/* Detect and diagnose a mismatch between an attribute access specification
on the original declaration of FNDECL and that on the parameters NEWPARMS
from its refeclaration. ORIGLOC is the location of the first declaration
@ -3585,10 +3598,9 @@ warn_parm_array_mismatch (location_t origloc, tree fndecl, tree newparms)
the same. */
continue;
const char* const newbndstr =
newbnd ? print_generic_expr_to_str (newbnd) : "*";
const char* const curbndstr =
curbnd ? print_generic_expr_to_str (curbnd) : "*";
pretty_printer pp1, pp2;
const char* const newbndstr = expr_to_str (pp1, newbnd, "*");
const char* const curbndstr = expr_to_str (pp2, curbnd, "*");
if (!newpos != !curpos
|| (newpos && !tree_int_cst_equal (newpos, curpos)))

3
gcc/tree-pretty-print.c
View File

@ -169,7 +169,8 @@ print_generic_expr (FILE *file, tree t, dump_flags_t flags)
pp_flush (tree_pp);
}
/* Print a single expression T to string, and return it. */
/* Print a single expression T to string, and return it. The caller
must free the returned memory. */
char *
print_generic_expr_to_str (tree t)