OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR c/35435 (ICE with attribute tls_model in typedef)

Browse Source 
PR c/35435
	* c-common.c (handle_tls_model_attribute): Ignore attribute for
	non-VAR_DECLs without checking DECL_THREAD_LOCAL_P.

testsuite:
	* gcc.dg/tls/diag-6.c: New test.

From-SVN: r143963
This commit is contained in:
Joseph Myers 2009-02-05 12:13:52 +00:00 committed by Joseph Myers
parent 7ab7e65a7e
commit f93418341d
4 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/ChangeLog
View File

@ -1,3 +1,9 @@
2009-02-05 Joseph Myers <joseph@codesourcery.com>
PR c/35435
* c-common.c (handle_tls_model_attribute): Ignore attribute for
non-VAR_DECLs without checking DECL_THREAD_LOCAL_P.
2009-02-05 Richard Guenther <rguenther@suse.de>
Backport from mainline

2
gcc/c-common.c
View File

@ -5782,7 +5782,7 @@ handle_tls_model_attribute (tree *node, tree name, tree args,
*no_add_attrs = true;
if (!DECL_THREAD_LOCAL_P (decl))
if (TREE_CODE (decl) != VAR_DECL || !DECL_THREAD_LOCAL_P (decl))
{
warning (OPT_Wattributes, "%qE attribute ignored", name);
return NULL_TREE;

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2009-02-05 Joseph Myers <joseph@codesourcery.com>
PR c/35435
* gcc.dg/tls/diag-6.c: New test.
2009-02-05 Richard Guenther <rguenther@suse.de>
Backport from mainline

8
gcc/testsuite/gcc.dg/tls/diag-6.c Normal file
View File

@ -0,0 +1,8 @@
/* Invalid tls_model attributes. PR 35435. */
/* { dg-require-effective-target tls } */
int v __attribute__((tls_model("initial-exec"))); /* { dg-warning "attribute ignored" } */
typedef int X __attribute__((tls_model("initial-exec"))); /* { dg-warning "attribute ignored" } */
void f(int x __attribute__((tls_model("initial-exec")))); /* { dg-warning "attribute ignored" } */
__thread int a __attribute__((tls_model(1))); /* { dg-error "tls_model argument not a string" } */
__thread int b __attribute__((tls_model("unknown"))); /* { dg-error "tls_model argument must be one of" } */