OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[Ada] Additional warnings on overlapping actuals of composite types 

2020-06-10  Ed Schonberg  <schonberg@adacore.com>

gcc/ada/

	* sem_warn.adb (Warn_On_Overlapping_Actuals): Add a warning when
	two actuals in a call overlap, both are composite types that may
	be passed by reference, and only one of them is writable.
This commit is contained in:
Ed Schonberg 2020-03-09 16:36:55 -04:00 committed by Pierre-Marie de Rodat
parent 67a44a4c10
commit f95fb9d019
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
gcc/ada/sem_warn.adb
View File

@ -3742,10 +3742,26 @@ package body Sem_Warn is
-- If appropriate warning switch is set, we also report warnings on
-- overlapping parameters that are record types or array types.
-- It is also worthwhile to warn on overlaps of composite objects when
-- only one of the formals is (in)-out. Note that the RM rule above is
-- a legality rule. We choose to implement this check as a warning to
-- avoid major incompatibilities with legacy code. We exclude internal
-- sources from the warning, because subprograms in Container libraries
-- would be affected by the warning.
-- Note also that the rule in 6.4.1 (6.17/3), introduced by AI12-0324,
-- is potentially more expensive to verify, and is not yet implemented.
if Is_Internal_Unit (Current_Sem_Unit) then
return;
end if;
Form1 := First_Formal (Subp);
Act1 := First_Actual (N);
while Present (Form1) and then Present (Act1) loop
if Is_Covered_Formal (Form1) then
if Is_Covered_Formal (Form1)
or else not Is_Elementary_Type (Etype (Act1))
then
Form2 := First_Formal (Subp);
Act2 := First_Actual (N);
while Present (Form2) and then Present (Act2) loop