Go to file
Stefan Schulze Frielinghaus 27594524d8 fortran/io.c: Fix use of uninitialized variable num [PR94769]
While bootstrapping GCC on S/390 the following warning occurs:

gcc/fortran/io.c: In function 'bool gfc_resolve_dt(gfc_code*, gfc_dt*, locus*)':
gcc/fortran/io.c:3857:7: error: 'num' may be used uninitialized in this function [-Werror=maybe-uninitialized]
 3857 |       if (num == 0)
      |       ^~
gcc/fortran/io.c:3843:11: note: 'num' was declared here
 3843 |       int num;

Since gfc_resolve_dt is a non-static function we cannot assume anything about
argument DT.  Argument DT gets passed to function check_io_constraints which
passes values depending on DT, namely dt->asynchronous->value.character.string
to function compare_to_allowed_values as well as argument warn which is true as
soon as DT->dterr is true.  Thus both arguments depend on DT.

If function compare_to_allowed_values is called with
dt->asynchronous->value.character.string not being an allowed value, and
ALLOWED_F2003 as well as ALLOWED_GNU being NULL (which is the case at the
particular call side), and WARN equals true, then the function returns with a
non-zero value and leaves num uninitialized which renders the warning true.

Initialized num to -1 and added an assert statement.

gcc/fortran/ChangeLog:

2020-04-29  Stefan Schulze Frielinghaus  <stefansf@linux.ibm.com>

        PR fortran/94769
        * io.c (check_io_constraints): Initialize local variable num to
        -1 and assert that it receives a meaningful value by function
        compare_to_allowed_values.
2020-04-29 16:37:18 +02:00
config Check whether -fcf-protection=none -Wl,-z,ibt,-z,shstk work first 2020-04-28 05:42:50 -07:00
contrib Do not modify tab options in vimrc for .py files. 2020-04-17 08:55:55 +02:00
fixincludes
gcc fortran/io.c: Fix use of uninitialized variable num [PR94769] 2020-04-29 16:37:18 +02:00
gnattools
gotools
include Do not use HAVE_DOS_BASED_FILE_SYSTEM for Cygwin. 2020-04-17 09:22:51 +02:00
INSTALL
intl intl: Unbreak intl build with bison 3 when no regeneration is needed [PR92008] 2020-04-16 11:55:00 +02:00
libada
libatomic i386: Remove unneeded assignments when triggering SSE exceptions 2020-04-19 14:27:12 +02:00
libbacktrace
libcc1
libcpp
libdecnumber
libffi libffi/test: Fix compilation for build sysroot 2020-04-25 21:27:14 +01:00
libgcc RS6000: Use .machine ppc for some CRT files 2020-04-27 07:45:54 +02:00
libgfortran Protect the trigd functions in libgfortran from unavailable math functions. 2020-04-23 10:11:01 -04:00
libgo gotest: increase the test timeout 2020-04-23 20:16:32 -07:00
libgomp [OpenACC] Set 'acc_device_current = -1' 2020-04-29 09:54:37 +02:00
libhsail-rt
libiberty Check whether -fcf-protection=none -Wl,-z,ibt,-z,shstk work first 2020-04-28 05:42:50 -07:00
libitm
libobjc
liboffloadmic
libphobos libphobos: Fix KERNEL_VERSION condition in libphobos testsuite 2020-04-29 10:42:21 +02:00
libquadmath
libsanitizer
libssp
libstdc++-v3 libstdc++: Fixes for feature test macros (PR 91480) 2020-04-28 23:40:18 +01:00
libvtv
lto-plugin Check whether -fcf-protection=none -Wl,-z,ibt,-z,shstk work first 2020-04-28 05:42:50 -07:00
maintainer-scripts
zlib
.dir-locals.el
.gitattributes
.gitignore
ABOUT-NLS
ar-lib
ChangeLog [gcn] Don't default to building target-libstdc++-v3 [PR92713] 2020-04-29 09:28:01 +02:00
ChangeLog.jit
ChangeLog.tree-ssa
compile
config-ml.in
config.guess
config.rpath
config.sub
configure [gcn] Don't default to building target-libstdc++-v3 [PR92713] 2020-04-29 09:28:01 +02:00
configure.ac [gcn] Don't default to building target-libstdc++-v3 [PR92713] 2020-04-29 09:28:01 +02:00
COPYING
COPYING3
COPYING3.LIB
COPYING.LIB
COPYING.RUNTIME
depcomp
install-sh
libtool-ldflags
libtool.m4
lt~obsolete.m4
ltgcc.m4
ltmain.sh Do not use HAVE_DOS_BASED_FILE_SYSTEM for Cygwin. 2020-04-17 09:22:51 +02:00
ltoptions.m4
ltsugar.m4
ltversion.m4
MAINTAINERS MAINTAINERS: add myself for write after approval 2020-04-22 09:39:44 +02:00
Makefile.def Merge top-level configury changes from gdb 2020-04-09 06:52:55 -06:00
Makefile.in Merge top-level configury changes from gdb 2020-04-09 06:52:55 -06:00
Makefile.tpl
missing
mkdep
mkinstalldirs
move-if-change
multilib.am
README
symlink-tree
test-driver
ylwrap

This directory contains the GNU Compiler Collection (GCC).

The GNU Compiler Collection is free software.  See the files whose
names start with COPYING for copying permission.  The manuals, and
some of the runtime libraries, are under different terms; see the
individual source files for details.

The directory INSTALL contains copies of the installation information
as HTML and plain text.  The source of this information is
gcc/doc/install.texi.  The installation information includes details
of what is included in the GCC sources and what files GCC installs.

See the file gcc/doc/gcc.texi (together with other files that it
includes) for usage and porting information.  An online readable
version of the manual is in the files gcc/doc/gcc.info*.

See http://gcc.gnu.org/bugs/ for how to report bugs usefully.

Copyright years on GCC source files may be listed using range
notation, e.g., 1987-2012, indicating that every year in the range,
inclusive, is a copyrightable year that could otherwise be listed
individually.