916c7a201a
As the new testcase shows, we weren't actually performing reductions on host teams construct. And fixing that revealed a flaw in the for-14.c testcase. The problem is that the tests perform also initialization and checking around the calls to the functions with the OpenMP constructs. In that testcase, all the tests have been spawned from a teams construct but only the tested loops were distribute, which means the initialization and checking has been performed redundantly and racily in each team. Fixed by performing the initialization and checking outside of host teams and only do the calls to functions with the tested constructs inside of host teams. 2020-08-05 Jakub Jelinek <jakub@redhat.com> PR middle-end/96459 * omp-low.c (lower_omp_taskreg): Call lower_reduction_clauses even in for host teams. * testsuite/libgomp.c/teams-3.c: New test. * testsuite/libgomp.c-c++-common/for-2.h (OMPTEAMS): Define to nothing if not defined yet. (N(test)): Use it before all N(f*) calls. * testsuite/libgomp.c-c++-common/for-14.c (DO_PRAGMA, OMPTEAMS): Define. (main): Don't call all test_* functions from within #pragma omp teams reduction(|:err), call them directly.
21 lines
328 B
C
21 lines
328 B
C
/* PR middle-end/96459 */
|
|
|
|
#include <stdlib.h>
|
|
|
|
int
|
|
main ()
|
|
{
|
|
int niters = 0, i, j, k;
|
|
#pragma omp teams reduction(+:niters)
|
|
{
|
|
#pragma omp distribute collapse(3)
|
|
for (i = 0; i < 3; i++)
|
|
for (j = 0; j < 8; j += 2)
|
|
for (k = 0; k < 25; k += 3)
|
|
niters++;
|
|
}
|
|
if (niters != 108)
|
|
abort ();
|
|
return 0;
|
|
}
|