gcc/libiberty
Philippe Waroquiers f9f75f8d3c Fix splay tree KEY leak detected in GDB test gdb.base/macscp.exp
When a node is removed from a splay tree, the splay tree was
not using the function splay_tree_delete_key_fn to release the key.
This was causing a leak, fixed by Tom Tromey.

This patch fixes another key leak, that happens when a key equal to
a key already present is inserted.  In such a case, we have to release
the old KEY.
Note that this is based on the assumption that the caller always
allocates a new KEY when doing an insert.

Also, clarify the documentation about when the release functions are
called.

2019-02-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

	* splay-tree.h (splay_tree_delete_key_fn): Update comment.
	(splay_tree_delete_value_fn): Likewise.

libiberty/ChangeLog
2019-02-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

	* splay-tree.c (splay_tree_insert): Also release old KEY in case
	of insertion of a key equal to an already present key.
	(splay_tree_new_typed_alloc): Update comment.

From-SVN: r268793
2019-02-12 13:02:48 +00:00
..
config
testsuite Update copyright years. 2019-01-01 13:31:55 +01:00
.gitignore
COPYING.LIB
ChangeLog Fix splay tree KEY leak detected in GDB test gdb.base/macscp.exp 2019-02-12 13:02:48 +00:00
ChangeLog.jit
Makefile.in Update copyright years. 2019-01-01 13:31:55 +01:00
README
_doprnt.c Update copyright years. 2019-01-01 13:31:55 +01:00
aclocal.m4
alloca.c
argv.c Update copyright years. 2019-01-01 13:31:55 +01:00
asprintf.c Update copyright years. 2019-01-01 13:31:55 +01:00
at-file.texi
atexit.c
basename.c
bcmp.c
bcopy.c
bsearch.c
bzero.c
calloc.c
choose-temp.c Update copyright years. 2019-01-01 13:31:55 +01:00
clock.c Update copyright years. 2019-01-01 13:31:55 +01:00
concat.c Update copyright years. 2019-01-01 13:31:55 +01:00
config.h-vms
config.in Update GCC to autoconf 2.69, automake 1.15.1 (PR bootstrap/82856). 2018-10-31 17:03:16 +00:00
configure Update GCC to autoconf 2.69, automake 1.15.1 (PR bootstrap/82856). 2018-10-31 17:03:16 +00:00
configure.ac Update GCC to autoconf 2.69, automake 1.15.1 (PR bootstrap/82856). 2018-10-31 17:03:16 +00:00
configure.com
copying-lib.texi Update copyright years. 2019-01-01 13:31:55 +01:00
copysign.c
cp-demangle.c Implement P0482R5, char8_t: A type for UTF-8 characters and strings 2019-01-14 14:55:51 -05:00
cp-demangle.h Implement P0482R5, char8_t: A type for UTF-8 characters and strings 2019-01-14 14:55:51 -05:00
cp-demint.c Update copyright years. 2019-01-01 13:31:55 +01:00
cplus-dem.c Update copyright years. 2019-01-01 13:31:55 +01:00
crc32.c Update copyright years. 2019-01-01 13:31:55 +01:00
d-demangle.c Update copyright years. 2019-01-01 13:31:55 +01:00
dwarfnames.c Update copyright years. 2019-01-01 13:31:55 +01:00
dyn-string.c Update copyright years. 2019-01-01 13:31:55 +01:00
fdmatch.c Update copyright years. 2019-01-01 13:31:55 +01:00
ffs.c
fibheap.c Update copyright years. 2019-01-01 13:31:55 +01:00
filename_cmp.c Update copyright years. 2019-01-01 13:31:55 +01:00
floatformat.c PR other/16615 [2/5] 2019-01-09 16:39:49 -05:00
fnmatch.c Update copyright years. 2019-01-01 13:31:55 +01:00
fnmatch.txh
fopen_unlocked.c Update copyright years. 2019-01-01 13:31:55 +01:00
functions.texi
gather-docs Update copyright years. 2019-01-01 13:31:55 +01:00
getcwd.c
getopt.c Update copyright years. 2019-01-01 13:31:55 +01:00
getopt1.c Update copyright years. 2019-01-01 13:31:55 +01:00
getpagesize.c
getpwd.c
getruntime.c Update copyright years. 2019-01-01 13:31:55 +01:00
gettimeofday.c
hashtab.c Update copyright years. 2019-01-01 13:31:55 +01:00
hex.c Update copyright years. 2019-01-01 13:31:55 +01:00
index.c
insque.c
lbasename.c Update copyright years. 2019-01-01 13:31:55 +01:00
libiberty.texi Update copyright years. 2019-01-01 13:31:55 +01:00
lrealpath.c Update copyright years. 2019-01-01 13:31:55 +01:00
maint-tool Update copyright years. 2019-01-01 13:31:55 +01:00
make-relative-prefix.c Update copyright years. 2019-01-01 13:31:55 +01:00
make-temp-file.c Update copyright years. 2019-01-01 13:31:55 +01:00
makefile.vms
md5.c Update copyright years. 2019-01-01 13:31:55 +01:00
memchr.c
memcmp.c
memcpy.c
memmem.c Update copyright years. 2019-01-01 13:31:55 +01:00
memmove.c
mempcpy.c Update copyright years. 2019-01-01 13:31:55 +01:00
memset.c
mkstemps.c Update copyright years. 2019-01-01 13:31:55 +01:00
msdos.c
objalloc.c Update copyright years. 2019-01-01 13:31:55 +01:00
obstack.c Update copyright years. 2019-01-01 13:31:55 +01:00
obstacks.texi
partition.c Update copyright years. 2019-01-01 13:31:55 +01:00
pex-common.c Update copyright years. 2019-01-01 13:31:55 +01:00
pex-common.h Update copyright years. 2019-01-01 13:31:55 +01:00
pex-djgpp.c Update copyright years. 2019-01-01 13:31:55 +01:00
pex-msdos.c Update copyright years. 2019-01-01 13:31:55 +01:00
pex-one.c Update copyright years. 2019-01-01 13:31:55 +01:00
pex-unix.c Update copyright years. 2019-01-01 13:31:55 +01:00
pex-win32.c Update copyright years. 2019-01-01 13:31:55 +01:00
pexecute.c Update copyright years. 2019-01-01 13:31:55 +01:00
pexecute.txh
physmem.c Update copyright years. 2019-01-01 13:31:55 +01:00
putenv.c Update copyright years. 2019-01-01 13:31:55 +01:00
random.c
regex.c Update copyright years. 2019-01-01 13:31:55 +01:00
rename.c
rindex.c
rust-demangle.c Update copyright years. 2019-01-01 13:31:55 +01:00
safe-ctype.c Update copyright years. 2019-01-01 13:31:55 +01:00
setenv.c Update copyright years. 2019-01-01 13:31:55 +01:00
setproctitle.c Update copyright years. 2019-01-01 13:31:55 +01:00
sha1.c Update copyright years. 2019-01-01 13:31:55 +01:00
sigsetmask.c
simple-object-coff.c Update copyright years. 2019-01-01 13:31:55 +01:00
simple-object-common.h Update copyright years. 2019-01-01 13:31:55 +01:00
simple-object-elf.c Update copyright years. 2019-01-01 13:31:55 +01:00
simple-object-mach-o.c Update copyright years. 2019-01-01 13:31:55 +01:00
simple-object-xcoff.c Update copyright years. 2019-01-01 13:31:55 +01:00
simple-object.c re PR lto/88422 (collect2.exe: fatal error: lto-wrapper returned 1 exit status: file not recognized: file truncated) 2019-01-22 09:47:52 +00:00
simple-object.txh
snprintf.c Update copyright years. 2019-01-01 13:31:55 +01:00
sort.c Update copyright years. 2019-01-01 13:31:55 +01:00
spaces.c Update copyright years. 2019-01-01 13:31:55 +01:00
splay-tree.c Fix splay tree KEY leak detected in GDB test gdb.base/macscp.exp 2019-02-12 13:02:48 +00:00
stack-limit.c Update copyright years. 2019-01-01 13:31:55 +01:00
stpcpy.c Update copyright years. 2019-01-01 13:31:55 +01:00
stpncpy.c Update copyright years. 2019-01-01 13:31:55 +01:00
strcasecmp.c
strchr.c
strdup.c
strerror.c PR other/16615 [2/5] 2019-01-09 16:39:49 -05:00
strncasecmp.c
strncmp.c
strndup.c Update copyright years. 2019-01-01 13:31:55 +01:00
strnlen.c
strrchr.c
strsignal.c
strstr.c
strtod.c Update copyright years. 2019-01-01 13:31:55 +01:00
strtol.c
strtoll.c
strtoul.c
strtoull.c
strverscmp.c Update copyright years. 2019-01-01 13:31:55 +01:00
timeval-utils.c Update copyright years. 2019-01-01 13:31:55 +01:00
tmpnam.c
unlink-if-ordinary.c Update copyright years. 2019-01-01 13:31:55 +01:00
vasprintf.c Update copyright years. 2019-01-01 13:31:55 +01:00
vfork.c
vfprintf.c Update copyright years. 2019-01-01 13:31:55 +01:00
vprintf-support.c Update copyright years. 2019-01-01 13:31:55 +01:00
vprintf-support.h Update copyright years. 2019-01-01 13:31:55 +01:00
vprintf.c
vsnprintf.c Update copyright years. 2019-01-01 13:31:55 +01:00
vsprintf.c Update copyright years. 2019-01-01 13:31:55 +01:00
waitpid.c
xasprintf.c Update copyright years. 2019-01-01 13:31:55 +01:00
xatexit.c
xexit.c Update copyright years. 2019-01-01 13:31:55 +01:00
xmalloc.c Update copyright years. 2019-01-01 13:31:55 +01:00
xmemdup.c
xstrdup.c
xstrerror.c
xstrndup.c Update copyright years. 2019-01-01 13:31:55 +01:00
xvasprintf.c Update copyright years. 2019-01-01 13:31:55 +01:00

README

This directory contains the -liberty library of free software.
It is a collection of subroutines used by various GNU programs.
Current members include:

	getopt -- get options from command line
	obstack -- stacks of arbitrarily-sized objects
	strerror -- error message strings corresponding to errno
	strtol -- string-to-long conversion
	strtoul -- string-to-unsigned-long conversion

We expect many of the GNU subroutines that are floating around to
eventually arrive here.

The library must be configured from the top source directory.  Don't
try to run configure in this directory.  Follow the configuration
instructions in ../README.

Please report bugs to "gcc-bugs@gcc.gnu.org" and send fixes to
"gcc-patches@gcc.gnu.org".  Thank you.

ADDING A NEW FILE
=================

There are two sets of files:  Those that are "required" will be
included in the library for all configurations, while those
that are "optional" will be included in the library only if "needed."

To add a new required file, edit Makefile.in to add the source file
name to CFILES and the object file to REQUIRED_OFILES.

To add a new optional file, it must provide a single function, and the
name of the function must be the same as the name of the file.

    * Add the source file name to CFILES in Makefile.in and the object
      file to CONFIGURED_OFILES.

    * Add the function to name to the funcs shell variable in
      configure.ac.

    * Add the function to the AC_CHECK_FUNCS lists just after the
      setting of the funcs shell variable.  These AC_CHECK_FUNCS calls
      are never executed; they are there to make autoheader work
      better.

    * Consider the special cases of building libiberty; as of this
      writing, the special cases are newlib and VxWorks.  If a
      particular special case provides the function, you do not need
      to do anything.  If it does not provide the function, add the
      object file to LIBOBJS, and add the function name to the case
      controlling whether to define HAVE_func.

Finally, in the build directory of libiberty, configure with
"--enable-maintainer-mode", run "make maint-deps" to update
Makefile.in, and run 'make stamp-functions' to regenerate
functions.texi.

The optional file you've added (e.g. getcwd.c) should compile and work
on all hosts where it is needed.  It does not have to work or even
compile on hosts where it is not needed.

ADDING A NEW CONFIGURATION
==========================

On most hosts you should be able to use the scheme for automatically
figuring out which files are needed.  In that case, you probably
don't need a special Makefile stub for that configuration.

If the fully automatic scheme doesn't work, you may be able to get
by with defining EXTRA_OFILES in your Makefile stub.  This is
a list of object file names that should be treated as required
for this configuration - they will be included in libiberty.a,
regardless of whatever might be in the C library.