gcc/libstdc++-v3/testsuite/20_util/allocator/void.cc
Jonathan Wakely fc6f1128ae libstdc++: Ignore cv-quals when std::allocator<void> constructs
When I added the std::allocator_traits<std::allocator<void>>
specialization it broke code like this:

  std::allocate_shared<const int>(std::allocator<void>());

The problem is that allocator_traits<allocator<void>>::construct(a, p)
now uses std::_Construct(p), which only does a static_cast<void*>(p) and
so fails if the pointer has cv-quals.

This changes std::_Construct (and the related std::_Construct_novalue)
to use a C-style cast to (void*) which matches the effects of the
"voidify" helper in the C++20 standard.

libstdc++-v3/ChangeLog:

	* include/bits/stl_construct.h (_Construct, _Construct_novalue):
	Also cast away cv-qualifiers when converting pointer to void.
	* testsuite/20_util/allocator/void.cc: Test construct function
	with cv-qualified types.
2022-01-14 10:14:25 +00:00

110 lines
3.7 KiB
C++

// Copyright (C) 2016-2022 Free Software Foundation, Inc.
//
// This file is part of the GNU ISO C++ Library. This library is free
// software; you can redistribute it and/or modify it under the
// terms of the GNU General Public License as published by the
// Free Software Foundation; either version 3, or (at your option)
// any later version.
// This library is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
// You should have received a copy of the GNU General Public License along
// with this library; see the file COPYING3. If not see
// <http://www.gnu.org/licenses/>.
// { dg-do run { target c++11 } }
#include <memory>
#include <testsuite_hooks.h>
template class std::allocator<void>;
void
test01()
{
int i;
using alloc_type = std::allocator<void>;
alloc_type a;
std::allocator_traits<alloc_type>::construct(a, &i, 42);
VERIFY( i == 42 );
std::allocator_traits<alloc_type>::destroy(a, &i);
}
static_assert( std::allocator<void>::propagate_on_container_move_assignment(),
"POCMA trait should always be present" );
static_assert( std::allocator<void>::is_always_equal(),
"is_always_equal trait should always be present" );
static_assert(
std::is_same<std::allocator<void>::size_type, std::size_t>(),
"size_type is size_t" );
static_assert(
std::is_same<std::allocator<void>::difference_type, std::ptrdiff_t>(),
"size_type is size_t" );
// These properties are formally unspecified, but have always been true for
// the libstdc++ definition of allocator<void>.
static_assert(
std::is_trivially_default_constructible<std::allocator<void>>::value,
"explicit specialization has trivial default constructor");
static_assert(
std::is_trivially_copy_constructible<std::allocator<void>>::value,
"explicit specialization has trivial copy constructor");
static_assert(
std::is_trivially_move_constructible<std::allocator<void>>::value,
"explicit specialization has trivial move constructor");
static_assert(
std::is_trivially_destructible<std::allocator<void>>::value,
"explicit specialization has trivial destructor");
#if __cplusplus >= 202002L
// C++20 removes the allocator<void> explicit specialization, so it can now be
// constructed using the converting constructor from other specializations.
static_assert( std::is_nothrow_constructible_v<std::allocator<void>,
std::allocator<int>> );
template<typename T>
concept has_pointer = requires { typename T::pointer; };
template<typename T>
concept has_const_pointer = requires { typename T::const_pointer; };
template<typename T>
concept has_size_type = requires { typename T::size_type; };
template<typename T>
concept has_difference_type = requires { typename T::difference_type; };
// These were removed for C++20
static_assert( ! has_pointer<std::allocator<void>> );
static_assert( ! has_const_pointer<std::allocator<void>> );
#else
static_assert(
std::is_same<std::allocator<void>::pointer, void*>(),
"pointer is void*" );
static_assert( std::is_same<std::allocator<void>::const_pointer, const void*>(),
"const_pointer is const void*" );
#endif // C++20
void
test02()
{
std::allocator<void> av;
int* p = std::allocator<int>().allocate(1);
const int* c = p;
std::allocator_traits<std::allocator<void>>::construct(av, c, 0);
volatile int* v = p;
std::allocator_traits<std::allocator<void>>::construct(av, v, 0);
const volatile int* cv = p;
std::allocator_traits<std::allocator<void>>::construct(av, cv, 0);
std::allocator<int>().deallocate(p, 1);
}
int
main()
{
test01();
test02();
}