1a2f01efa6
Update the Go library to the 1.10beta1 release.
Requires a few changes to the compiler for modifications to the map
runtime code, and to handle some nowritebarrier cases in the runtime.
Reviewed-on: https://go-review.googlesource.com/86455
gotools/:
* Makefile.am (go_cmd_vet_files): New variable.
(go_cmd_buildid_files, go_cmd_test2json_files): New variables.
(s-zdefaultcc): Change from constants to functions.
(noinst_PROGRAMS): Add vet, buildid, and test2json.
(cgo$(EXEEXT)): Link against $(LIBGOTOOL).
(vet$(EXEEXT)): New target.
(buildid$(EXEEXT)): New target.
(test2json$(EXEEXT)): New target.
(install-exec-local): Install all $(noinst_PROGRAMS).
(uninstall-local): Uninstasll all $(noinst_PROGRAMS).
(check-go-tool): Depend on $(noinst_PROGRAMS). Copy down
objabi.go.
(check-runtime): Depend on $(noinst_PROGRAMS).
(check-cgo-test, check-carchive-test): Likewise.
(check-vet): New target.
(check): Depend on check-vet. Look at cmd_vet-testlog.
(.PHONY): Add check-vet.
* Makefile.in: Rebuild.
From-SVN: r256365
60 lines
1.7 KiB
Go
60 lines
1.7 KiB
Go
// Copyright 2013 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// This file contains tests for the shadowed variable checker.
|
|
// Some of these errors are caught by the compiler (shadowed return parameters for example)
|
|
// but are nonetheless useful tests.
|
|
|
|
package testdata
|
|
|
|
import "os"
|
|
|
|
func ShadowRead(f *os.File, buf []byte) (err error) {
|
|
var x int
|
|
if f != nil {
|
|
err := 3 // OK - different type.
|
|
_ = err
|
|
}
|
|
if f != nil {
|
|
_, err := f.Read(buf) // ERROR "declaration of .err. shadows declaration at testdata/shadow.go:13"
|
|
if err != nil {
|
|
return err
|
|
}
|
|
i := 3 // OK
|
|
_ = i
|
|
}
|
|
if f != nil {
|
|
x := one() // ERROR "declaration of .x. shadows declaration at testdata/shadow.go:14"
|
|
var _, err = f.Read(buf) // ERROR "declaration of .err. shadows declaration at testdata/shadow.go:13"
|
|
if x == 1 && err != nil {
|
|
return err
|
|
}
|
|
}
|
|
for i := 0; i < 10; i++ {
|
|
i := i // OK: obviously intentional idiomatic redeclaration
|
|
go func() {
|
|
println(i)
|
|
}()
|
|
}
|
|
var shadowTemp interface{}
|
|
switch shadowTemp := shadowTemp.(type) { // OK: obviously intentional idiomatic redeclaration
|
|
case int:
|
|
println("OK")
|
|
_ = shadowTemp
|
|
}
|
|
if shadowTemp := shadowTemp; true { // OK: obviously intentional idiomatic redeclaration
|
|
var f *os.File // OK because f is not mentioned later in the function.
|
|
// The declaration of x is a shadow because x is mentioned below.
|
|
var x int // ERROR "declaration of .x. shadows declaration at testdata/shadow.go:14"
|
|
_, _, _ = x, f, shadowTemp
|
|
}
|
|
// Use a couple of variables to trigger shadowing errors.
|
|
_, _ = err, x
|
|
return
|
|
}
|
|
|
|
func one() int {
|
|
return 1
|
|
}
|