22cff118f7
... to diagnose potentially suboptimal choices regarding OpenACC parallelism. Not enabled by default: too noisy ("*potentially* suboptimal choices"); see XFAILed 'dg-bogus'es. gcc/c-family/ * c.opt (Wopenacc-parallelism): New. gcc/fortran/ * lang.opt (Wopenacc-parallelism): New. gcc/ * omp-offload.c (oacc_validate_dims): Implement '-Wopenacc-parallelism'. * doc/invoke.texi (-Wopenacc-parallelism): Document. gcc/testsuite/ * c-c++-common/goacc/diag-parallelism-1.c: New. * c-c++-common/goacc/acc-icf.c: Specify '-Wopenacc-parallelism', and match diagnostics, as appropriate. * c-c++-common/goacc/classify-kernels-unparallelized.c: Likewise. * c-c++-common/goacc/classify-kernels.c: Likewise. * c-c++-common/goacc/classify-parallel.c: Likewise. * c-c++-common/goacc/classify-routine.c: Likewise. * c-c++-common/goacc/classify-serial.c: Likewise. * c-c++-common/goacc/kernels-decompose-1.c: Likewise. * c-c++-common/goacc/kernels-decompose-2.c: Likewise. * c-c++-common/goacc/parallel-dims-1.c: Likewise. * c-c++-common/goacc/parallel-reduction.c: Likewise. * c-c++-common/goacc/pr70688.c: Likewise. * c-c++-common/goacc/routine-1.c: Likewise. * c-c++-common/goacc/routine-level-of-parallelism-2.c: Likewise. * c-c++-common/goacc/uninit-dim-clause.c: Likewise. * gfortran.dg/goacc/classify-kernels-unparallelized.f95: Likewise. * gfortran.dg/goacc/classify-kernels.f95: Likewise. * gfortran.dg/goacc/classify-parallel.f95: Likewise. * gfortran.dg/goacc/classify-routine.f95: Likewise. * gfortran.dg/goacc/classify-serial.f95: Likewise. * gfortran.dg/goacc/kernels-decompose-1.f95: Likewise. * gfortran.dg/goacc/kernels-decompose-2.f95: Likewise. * gfortran.dg/goacc/parallel-tree.f95: Likewise. * gfortran.dg/goacc/routine-4.f90: Likewise. * gfortran.dg/goacc/routine-level-of-parallelism-1.f90: Likewise. * gfortran.dg/goacc/routine-module-mod-1.f90: Likewise. * gfortran.dg/goacc/routine-multiple-directives-1.f90: Likewise. * gfortran.dg/goacc/uninit-dim-clause.f95: Likewise. libgomp/ * testsuite/libgomp.oacc-c-c++-common/firstprivate-1.c: Specify '-Wopenacc-parallelism', and match diagnostics, as appropriate. * testsuite/libgomp.oacc-c-c++-common/loop-auto-1.c: Likewise. * testsuite/libgomp.oacc-c-c++-common/loop-red-w-1.c: Likewise. * testsuite/libgomp.oacc-c-c++-common/loop-red-w-2.c: Likewise. * testsuite/libgomp.oacc-c-c++-common/loop-w-1.c: Likewise. * testsuite/libgomp.oacc-c-c++-common/mode-transitions.c: Likewise. * testsuite/libgomp.oacc-c-c++-common/par-reduction-1.c: Likewise. * testsuite/libgomp.oacc-c-c++-common/par-reduction-2.c: Likewise. * testsuite/libgomp.oacc-c-c++-common/parallel-dims.c: Likewise. * testsuite/libgomp.oacc-c-c++-common/parallel-reduction.c: Likewise. * testsuite/libgomp.oacc-c-c++-common/pr85381-3.c: Likewise. * testsuite/libgomp.oacc-c-c++-common/private-variables.c: Likewise. * testsuite/libgomp.oacc-c-c++-common/reduction-5.c: Likewise. * testsuite/libgomp.oacc-c-c++-common/reduction-7.c: Likewise. * testsuite/libgomp.oacc-c-c++-common/routine-g-1.c: Likewise. * testsuite/libgomp.oacc-c-c++-common/routine-w-1.c: Likewise. * testsuite/libgomp.oacc-c-c++-common/routine-wv-2.c: Likewise. * testsuite/libgomp.oacc-c-c++-common/static-variable-1.c: Likewise. * testsuite/libgomp.oacc-fortran/optional-private.f90: Likewise. * testsuite/libgomp.oacc-fortran/par-reduction-2-1.f: Likewise. * testsuite/libgomp.oacc-fortran/par-reduction-2-2.f: Likewise. * testsuite/libgomp.oacc-fortran/parallel-dims.f90: Likewise. * testsuite/libgomp.oacc-fortran/parallel-reduction.f90: Likewise. * testsuite/libgomp.oacc-fortran/pr84028.f90: Likewise. * testsuite/libgomp.oacc-fortran/private-variables.f90: Likewise. * testsuite/libgomp.oacc-fortran/reduction-1.f90: Likewise. * testsuite/libgomp.oacc-fortran/reduction-5.f90: Likewise. * testsuite/libgomp.oacc-fortran/reduction-6.f90: Likewise. * testsuite/libgomp.oacc-fortran/routine-7.f90: Likewise. Co-Authored-By: Nathan Sidwell <nathan@codesourcery.com> Co-Authored-By: Tom de Vries <vries@codesourcery.com> Co-Authored-By: Julian Brown <julian@codesourcery.com> Co-Authored-By: Kwok Cheung Yeung <kcy@codesourcery.com>
250 lines
5.1 KiB
C
250 lines
5.1 KiB
C
/* AMD GCN does not use 32-lane vectors.
|
|
{ dg-skip-if "unsuitable dimensions" { openacc_radeon_accel_selected } { "*" } { "" } } */
|
|
|
|
/* { dg-additional-options "-fopenacc-dim=32" } */
|
|
|
|
/* { dg-additional-options "-Wopenacc-parallelism" } for testing/documenting
|
|
aspects of that functionality. */
|
|
|
|
#include <stdio.h>
|
|
#include <openacc.h>
|
|
#include <gomp-constants.h>
|
|
|
|
int check (const int *ary, int size, int gp, int wp, int vp)
|
|
{
|
|
int exit = 0;
|
|
int ix;
|
|
int gangs[32], workers[32], vectors[32];
|
|
|
|
for (ix = 0; ix < 32; ix++)
|
|
gangs[ix] = workers[ix] = vectors[ix] = 0;
|
|
|
|
for (ix = 0; ix < size; ix++)
|
|
{
|
|
vectors[ary[ix] & 0xff]++;
|
|
workers[(ary[ix] >> 8) & 0xff]++;
|
|
gangs[(ary[ix] >> 16) & 0xff]++;
|
|
}
|
|
|
|
for (ix = 0; ix < 32; ix++)
|
|
{
|
|
if (gp)
|
|
{
|
|
int expect = gangs[0];
|
|
if (gangs[ix] != expect)
|
|
{
|
|
exit = 1;
|
|
printf ("gang %d not used %d times\n", ix, expect);
|
|
}
|
|
}
|
|
else if (ix && gangs[ix])
|
|
{
|
|
exit = 1;
|
|
printf ("gang %d unexpectedly used\n", ix);
|
|
}
|
|
|
|
if (wp)
|
|
{
|
|
int expect = workers[0];
|
|
if (workers[ix] != expect)
|
|
{
|
|
exit = 1;
|
|
printf ("worker %d not used %d times\n", ix, expect);
|
|
}
|
|
}
|
|
else if (ix && workers[ix])
|
|
{
|
|
exit = 1;
|
|
printf ("worker %d unexpectedly used\n", ix);
|
|
}
|
|
|
|
if (vp)
|
|
{
|
|
int expect = vectors[0];
|
|
if (vectors[ix] != expect)
|
|
{
|
|
exit = 1;
|
|
printf ("vector %d not used %d times\n", ix, expect);
|
|
}
|
|
}
|
|
else if (ix && vectors[ix])
|
|
{
|
|
exit = 1;
|
|
printf ("vector %d unexpectedly used\n", ix);
|
|
}
|
|
|
|
}
|
|
return exit;
|
|
}
|
|
|
|
#pragma acc routine seq
|
|
static int __attribute__((noinline)) place ()
|
|
{
|
|
int r = 0;
|
|
|
|
int g = 0, w = 0, v = 0;
|
|
g = __builtin_goacc_parlevel_id (GOMP_DIM_GANG);
|
|
w = __builtin_goacc_parlevel_id (GOMP_DIM_WORKER);
|
|
v = __builtin_goacc_parlevel_id (GOMP_DIM_VECTOR);
|
|
r = (g << 16) | (w << 8) | v;
|
|
|
|
return r;
|
|
}
|
|
|
|
static void clear (int *ary, int size)
|
|
{
|
|
int ix;
|
|
|
|
for (ix = 0; ix < size; ix++)
|
|
ary[ix] = -1;
|
|
}
|
|
|
|
int vector_1 (int *ary, int size)
|
|
{
|
|
clear (ary, size);
|
|
|
|
#pragma acc parallel num_workers (32) vector_length(32) copy(ary[0:size]) firstprivate (size)
|
|
{
|
|
#pragma acc loop gang
|
|
for (int jx = 0; jx < 1; jx++)
|
|
#pragma acc loop auto
|
|
for (int ix = 0; ix < size; ix++)
|
|
ary[ix] = place ();
|
|
}
|
|
|
|
return check (ary, size, 0, 1, 1);
|
|
}
|
|
|
|
int vector_2 (int *ary, int size)
|
|
{
|
|
clear (ary, size);
|
|
|
|
#pragma acc parallel num_workers (32) vector_length(32) copy(ary[0:size]) firstprivate (size)
|
|
{
|
|
#pragma acc loop worker
|
|
for (int jx = 0; jx < size / 64; jx++)
|
|
#pragma acc loop auto
|
|
for (int ix = 0; ix < 64; ix++)
|
|
ary[ix + jx * 64] = place ();
|
|
}
|
|
|
|
return check (ary, size, 0, 1, 1);
|
|
}
|
|
|
|
int worker_1 (int *ary, int size)
|
|
{
|
|
clear (ary, size);
|
|
|
|
#pragma acc parallel num_workers (32) vector_length(32) copy(ary[0:size]) firstprivate (size)
|
|
{
|
|
#pragma acc loop gang
|
|
for (int kx = 0; kx < 1; kx++)
|
|
#pragma acc loop auto
|
|
for (int jx = 0; jx < size / 64; jx++)
|
|
#pragma acc loop vector
|
|
for (int ix = 0; ix < 64; ix++)
|
|
ary[ix + jx * 64] = place ();
|
|
}
|
|
|
|
return check (ary, size, 0, 1, 1);
|
|
}
|
|
|
|
int gang_1 (int *ary, int size)
|
|
{
|
|
clear (ary, size);
|
|
|
|
#pragma acc parallel num_gangs (32) num_workers (32) vector_length(32) copy(ary[0:size]) firstprivate (size)
|
|
/* { dg-warning "region is vector partitioned but does not contain vector partitioned code" "" { target *-*-* } .-1 } */
|
|
{
|
|
#pragma acc loop auto
|
|
for (int jx = 0; jx < size / 64; jx++)
|
|
#pragma acc loop worker
|
|
for (int ix = 0; ix < 64; ix++)
|
|
ary[ix + jx * 64] = place ();
|
|
}
|
|
|
|
return check (ary, size, 1, 1, 0);
|
|
}
|
|
|
|
int gang_2 (int *ary, int size)
|
|
{
|
|
clear (ary, size);
|
|
|
|
#pragma acc parallel num_gangs (32) num_workers (32) vector_length(32) copy(ary[0:size]) firstprivate (size)
|
|
{
|
|
#pragma acc loop auto
|
|
for (int kx = 0; kx < size / (32 * 32); kx++)
|
|
#pragma acc loop auto
|
|
for (int jx = 0; jx < 32; jx++)
|
|
#pragma acc loop auto
|
|
for (int ix = 0; ix < 32; ix++)
|
|
ary[ix + jx * 32 + kx * 32 * 32] = place ();
|
|
}
|
|
|
|
return check (ary, size, 1, 1, 1);
|
|
}
|
|
|
|
int gang_3 (int *ary, int size)
|
|
{
|
|
clear (ary, size);
|
|
|
|
#pragma acc parallel num_workers (32) vector_length(32) copy(ary[0:size]) firstprivate (size)
|
|
{
|
|
#pragma acc loop auto
|
|
for (int jx = 0; jx < size / 64; jx++)
|
|
#pragma acc loop auto
|
|
for (int ix = 0; ix < 64; ix++)
|
|
ary[ix + jx * 64] = place ();
|
|
}
|
|
|
|
return check (ary, size, 1, 1, 1);
|
|
}
|
|
|
|
int gang_4 (int *ary, int size)
|
|
{
|
|
clear (ary, size);
|
|
|
|
#pragma acc parallel vector_length(32) copy(ary[0:size]) firstprivate (size)
|
|
{
|
|
#pragma acc loop auto
|
|
for (int jx = 0; jx < size; jx++)
|
|
ary[jx] = place ();
|
|
}
|
|
|
|
return check (ary, size, 1, 0, 1);
|
|
}
|
|
|
|
#define N (32*32*32*2)
|
|
int main ()
|
|
{
|
|
int ondev = 0;
|
|
|
|
#pragma acc parallel copy(ondev)
|
|
{
|
|
ondev = acc_on_device (acc_device_not_host);
|
|
}
|
|
if (!ondev)
|
|
return 0;
|
|
|
|
int ary[N];
|
|
|
|
if (vector_1 (ary, N))
|
|
return 1;
|
|
if (vector_2 (ary, N))
|
|
return 1;
|
|
|
|
if (worker_1 (ary, N))
|
|
return 1;
|
|
|
|
if (gang_1 (ary, N))
|
|
return 1;
|
|
if (gang_2 (ary, N))
|
|
return 1;
|
|
if (gang_3 (ary, N))
|
|
return 1;
|
|
if (gang_4 (ary, N))
|
|
return 1;
|
|
|
|
return 0;
|
|
}
|