Go to file
Ed Schonberg d2a60e5911 [Ada] Improper copying of limited arrays with default initialization
This patch fixes an improper expansion of aggregates for limited array
types in an object declaration. Prior to this patch, The presence of the
aggregate (which can only consist of box initializations) would create a
temporary that was then assigned to the object in the declaration.
Apart from a violation of the semantics of build-in-place limited
objects, this can also lead to out-of-scope access in LLVM.

Executing the following;

   gcc -c -gnatDG nocopy.adb
   grep quintet nocopy.adb.dg | wc -l

must yield:

   5

----
procedure NoCopy is

  --  Task used in this example to test that the limited component
  --  is properly initialized.

  task type T_Task (Disc : Natural);

  task body T_Task is
  begin
     null;
  end T_Task;

  type My_Rec (D : Natural := 9999) is record

     --  Components initialized by means of the current value
     --  of the record discriminant

     T : T_Task (D);
  end record;

  type TR is array (1 .. 5) of My_Rec;
  Quintet : TR := (others => (others => <>));
begin
   null;
end NoCopy;

2018-08-21  Ed Schonberg  <schonberg@adacore.com>

gcc/ada/

	* exp_aggr.adb (Expand_Array_Aggregate): If the component type
	is limited, the array must be constructed in place, so set flag
	In_Place_Assign_OK_For_Declaration accordingly. This prevents
	improper copying of an array of tasks during initialization.

From-SVN: r263719
2018-08-21 14:46:49 +00:00
config
contrib C-SKY port: Configury 2018-08-17 15:00:25 -04:00
fixincludes inclhack.def (aix_unistd): New. 2018-07-23 16:51:50 -04:00
gcc [Ada] Improper copying of limited arrays with default initialization 2018-08-21 14:46:49 +00:00
gnattools
gotools
include Add linker_output as prefix for LTO temps (PR lto/86548). 2018-07-26 12:13:14 +00:00
INSTALL
intl
libada
libatomic
libbacktrace libbacktrace: Suppress the default action-if-found for AC_CHECK_LIBS. 2018-08-05 20:24:59 +00:00
libcc1
libcpp [CPP PATCH] node field bits 2018-08-20 17:45:42 +00:00
libdecnumber
libffi backport: ffi.c (ffi_call_go, [...]): New functions. 2018-08-15 06:57:45 +00:00
libgcc libgcc: add crt{begin,end} for powerpc-wrs-vxworks target 2018-08-21 08:49:15 +00:00
libgfortran Include <sys/random.h> for getentropy on Solaris 2018-08-14 22:51:36 +00:00
libgo runtime: use poll rather than pollset for netpoll on AIX 2018-08-07 17:29:50 +00:00
libgomp [nvptx] Use CUDA driver API to select default runtime launch geometry 2018-08-13 12:04:24 +00:00
libhsail-rt
libiberty [libiberty patch] PEX-unix forking 2018-08-21 00:01:50 +00:00
libitm Remove nfs bogon 2018-08-03 14:53:48 -06:00
libobjc
liboffloadmic
libquadmath
libsanitizer Cherry-pick compiler-rt revision 338606 (PR sanitizer/86022). 2018-08-02 09:32:58 +00:00
libssp
libstdc++-v3 * testsuite/18_support/new_nothrow.cc: XFAIL on AIX. 2018-08-21 10:03:16 -04:00
libvtv
lto-plugin
maintainer-scripts
zlib
.dir-locals.el
.gitattributes
.gitignore
ABOUT-NLS
ChangeLog Update global reviewers list 2018-08-21 13:49:30 +00:00
ChangeLog.jit
ChangeLog.tree-ssa
compile
config-ml.in
config.guess
config.rpath
config.sub
configure
configure.ac
COPYING
COPYING3
COPYING3.LIB
COPYING.LIB
COPYING.RUNTIME
depcomp
install-sh
libtool-ldflags
libtool.m4
lt~obsolete.m4
ltgcc.m4
ltmain.sh
ltoptions.m4
ltsugar.m4
ltversion.m4
MAINTAINERS Update global reviewers list 2018-08-21 13:49:30 +00:00
Makefile.def
Makefile.in
Makefile.tpl
missing
mkdep
mkinstalldirs
move-if-change
README
symlink-tree
ylwrap

This directory contains the GNU Compiler Collection (GCC).

The GNU Compiler Collection is free software.  See the files whose
names start with COPYING for copying permission.  The manuals, and
some of the runtime libraries, are under different terms; see the
individual source files for details.

The directory INSTALL contains copies of the installation information
as HTML and plain text.  The source of this information is
gcc/doc/install.texi.  The installation information includes details
of what is included in the GCC sources and what files GCC installs.

See the file gcc/doc/gcc.texi (together with other files that it
includes) for usage and porting information.  An online readable
version of the manual is in the files gcc/doc/gcc.info*.

See http://gcc.gnu.org/bugs/ for how to report bugs usefully.

Copyright years on GCC source files may be listed using range
notation, e.g., 1987-2012, indicating that every year in the range,
inclusive, is a copyrightable year that could otherwise be listed
individually.