OpenE2K
/
glibc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't make local variables static in ldbl-96 j1l. 

The ldbl-96 implementation of j1l has some function-local variables
that are declared static for no apparent reason (this dates back to
the first addition of that file).

Any vaguely recent compiler, probably including any that are supported
for building glibc, optimizes away the "static" here, as the values of
the variables on entry to the function are dead.  So there is not
actually a user-visible bug here at present (but with any compilers
that didn't optimize away the static at all, possibly building with
less or no optimization, so that the function stored intermediate
values to and then loaded them from the variables, there would have
been a thread-safety issue).  But the "static" clearly doesn't belong
there and might potentially make things unsafe were compilation
without optimization to be supported in future, so this patch removes
it.

Tested for x86_64.

	* sysdeps/ieee754/ldbl-96/e_j1l.c (qone): Don't make local
	variables static.
This commit is contained in:
Joseph Myers 2017-12-06 15:19:06 +00:00
parent 53994f1263
commit 1dbe6f64ab
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ChangeLog
View File

@ -1,5 +1,8 @@
2017-12-06 Joseph Myers <joseph@codesourcery.com>
* sysdeps/ieee754/ldbl-96/e_j1l.c (qone): Don't make local
variables static.
* sysdeps/ieee754/ldbl-128/e_j0l.c (Y0_2N): Make const.
(Y0_2D): Likewise.
* sysdeps/ieee754/ldbl-128/e_j1l.c (Y0_2N): Likewise.

2
sysdeps/ieee754/ldbl-96/e_j1l.c
View File

@ -507,7 +507,7 @@ static long double
qone (long double x)
{
const long double *p, *q;
static long double s, r, z;
long double s, r, z;
int32_t ix;
uint32_t se, i0, i1;