diff --git a/ChangeLog b/ChangeLog index f500b833de..c292a5bf29 100644 --- a/ChangeLog +++ b/ChangeLog @@ -47,6 +47,11 @@ * nis/nis_subr.c: Likewise. * nis/nis_verifygroup.c: Likewise. +2017-03-21 Stefan Liebler + + * malloc/tst-interpose-aux.c (check_for_allocations): + Move compiler barrier before free. + 2017-03-20 Joseph Myers [BZ #21279] diff --git a/malloc/tst-interpose-aux.c b/malloc/tst-interpose-aux.c index e80e979299..68282b41d5 100644 --- a/malloc/tst-interpose-aux.c +++ b/malloc/tst-interpose-aux.c @@ -113,11 +113,11 @@ check_for_allocations (void) { /* Make sure that malloc is called at least once from libc. */ void *volatile ptr = strdup ("ptr"); - free (ptr); /* Compiler barrier. The strdup function calls malloc, which updates allocation_index, but strdup is marked __THROW, so the compiler could optimize away the reload. */ __asm__ volatile ("" ::: "memory"); + free (ptr); /* If the allocation count is still zero, it means we did not interpose malloc successfully. */ if (allocation_index == 0)