Run vismain only if linker supports protected data symbol

Gold doesn't support protected data symbol:

configure:5672: checking linker support for protected data symbol
configure:5682: gcc -fuse-ld=gold -nostdlib -nostartfiles -fno-stack-protector -fPIC -shared conftest.c -o conftest.so
configure:5685: $? = 0
configure:5692: gcc -fuse-ld=gold -nostdlib -nostartfiles -fno-stack-protector conftest.c -o conftest conftest.so
/usr/local/bin/ld.gold: error: /tmp/ccXWoofs.o: cannot make copy relocation for protected symbol 'bar', defined in conftest.so
collect2: error: ld returned 1 exit status

Run vismain only if linker supports protected data symbol.

	* elf/Makefile (tests): Add vismain only if
	$(have-protected-data) == yes.
	(tests-pie): Likewise.
This commit is contained in:
H.J. Lu 2017-08-04 11:47:08 -07:00
parent d2cf37c0a2
commit 3093fd5e5d
2 changed files with 8 additions and 0 deletions

View File

@ -1,3 +1,9 @@
2017-08-04 H.J. Lu <hongjiu.lu@intel.com>
* elf/Makefile (tests): Add vismain only if
$(have-protected-data) == yes.
(tests-pie): Likewise.
2017-08-04 H.J. Lu <hongjiu.lu@intel.com> 2017-08-04 H.J. Lu <hongjiu.lu@intel.com>
[BZ #21871] [BZ #21871]

View File

@ -289,10 +289,12 @@ ifeq (yesyes,$(have-fpie)$(build-shared))
modules-names += tst-piemod1 modules-names += tst-piemod1
tests += tst-pie1 tst-pie2 tests += tst-pie1 tst-pie2
tests-pie += tst-pie1 tst-pie2 tests-pie += tst-pie1 tst-pie2
ifeq (yes,$(have-protected-data))
tests += vismain tests += vismain
tests-pie += vismain tests-pie += vismain
CFLAGS-vismain.c = $(PIE-ccflag) CFLAGS-vismain.c = $(PIE-ccflag)
endif endif
endif
modules-execstack-yes = tst-execstack-mod modules-execstack-yes = tst-execstack-mod
extra-test-objs += $(addsuffix .os,$(strip $(modules-names))) extra-test-objs += $(addsuffix .os,$(strip $(modules-names)))