OpenE2K/glibc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

* sysdeps/mach/hurd/fork.c (__fork): Do not free the signal

Browse Source 
thread's sigstate data structure if it has been allocated.
This commit is contained in:
Roland McGrath 2002-09-20 03:31:58 +00:00
parent 3c9117108e
commit 4ac9bb2e4a
2 changed files with 29 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
2002-09-19 Neal H. Walfield <neal@cs.uml.edu>
* sysdeps/mach/hurd/fork.c (__fork): Do not free the signal
thread's sigstate data structure if it has been allocated.
2002-09-19 Roland McGrath <roland@redhat.com> 2002-09-19 Roland McGrath <roland@redhat.com>
* include/libc-symbols.h [HAVE_ASM_SET_DIRECTIVE] * include/libc-symbols.h [HAVE_ASM_SET_DIRECTIVE]

30
sysdeps/mach/hurd/fork.c
View File

@ -609,14 +609,17 @@ __fork (void)
for (i = 0; i < _hurd_nports; ++i) for (i = 0; i < _hurd_nports; ++i)
__spin_unlock (&_hurd_ports[i].lock); __spin_unlock (&_hurd_ports[i].lock);
/* We are the only thread in this new task, so we will /* We are one of the (exactly) two threads in this new task, we
take the task-global signals. */ will take the task-global signals. */
_hurd_sigthread = ss->thread; _hurd_sigthread = ss->thread;
/* Unchain the sigstate structures for threads that existed in the /* Claim our sigstate structure and unchain the rest: the
parent task but don't exist in this task (the child process). threads existed in the parent task but don't exist in this
Delay freeing them until later because some of the further setup task (the child process). Delay freeing them until later
and unlocking might be required for free to work. */ because some of the further setup and unlocking might be
required for free to work. Before we finish cleaning up,
we will reclaim the signal thread's sigstate structure (if
it had one). */
oldstates = _hurd_sigstates; oldstates = _hurd_sigstates;
if (oldstates == ss) if (oldstates == ss)
oldstates = ss->next; oldstates = ss->next;
@ -650,13 +653,26 @@ __fork (void)
if (!err) if (!err)
err = __thread_resume (_hurd_msgport_thread); err = __thread_resume (_hurd_msgport_thread);
/* Free the old sigstate structures. */ /* Reclaim the signal thread's sigstate structure and free the
other old sigstate structures. */
while (oldstates != NULL) while (oldstates != NULL)
{ {
struct hurd_sigstate *next = oldstates->next; struct hurd_sigstate *next = oldstates->next;
if (oldstates->thread == _hurd_msgport_thread)
{
/* If we have a second signal state structure then we
must have been through here before--not good. */
assert (_hurd_sigstates->next == 0);
_hurd_sigstates->next = oldstates;
oldstates->next = 0;
}
else
free (oldstates); free (oldstates);
oldstates = next; oldstates = next;
} }
/* XXX what to do if we have any errors here? */ /* XXX what to do if we have any errors here? */
pid = 0; pid = 0;