I noticed that glibc testsuite runs left several files behind in /tmp
(or TMPDIR, if different). The problem was testcases that generate a
template for mkstemp / mkstemp64, ending with XXXXXX, then pass that
template to add_temp_file before calling mkstemp / mkstemp64, meaning
that the template ending with XXXXXX is stored in the list of
temporary files to delete (add_temp_file uses strdup so that the
original string doesn't need to stay live), not the actual filename as
determined by mkstemp / mkstemp64. This patch fixes those tests to
call add_temp_file later.
Tested for x86_64 (that the files are no longer left behind by a
testsuite run and the modified tests still pass).
* io/test-lfs.c (do_prepare): Do not call add_temp_file until
after mkstemp64.
* login/tst-utmp.c (do_prepare): Likewise.
* rt/tst-aio.c (do_prepare): Likewise.
* rt/tst-aio64.c (do_prepare): Likewise.
To remove -Wno-error=undef, we need to fix the remaining cases where
there are -Wundef warnings in the testsuite. One of those places is
in login/tst-utmp.c.
When included from tst-utmpx.c, <utmpx.h> is included instead of
<utmp.h>, meaning the _HAVE_UT_* macros are not defined. The test is
prepared for them not being defined, in that all the relevant
conditionals also include "defined UTMPX". However, they test the
_HAVE_UT_* macros first, so resulting in -Wundef warnings.
This patch does the minimal fix of swapping the || operands. This is
logically correct - avoiding checking a macro we know will not be
defined in the case where it is not defined. It won't fix such
warnings for the case where the toplevel bits/utmp.h is used and most
_HAVE_UT_* aren't defined at all even when <utmp.h> is included, but
that case doesn't apply to any current glibc configuration. Fixing it
would also be tricky in that, while glibc itself consistently uses
_HAVE_UT_* in ways that would work with 0 instead of undefined,
external packages that use the macros expect defined / undefined
instead of 1 / 0 (codesearch.debian.net shows uses by util-linux,
python-utmp, libsys-utmp-perl).
Tested for x86_64.
* login/tst-utmp.c [_HAVE_UT_TYPE || defined UTMPX]: Change
conditional to [defined UTMPX || _HAVE_UT_TYPE].
[_HAVE_UT_TV || defined UTMPX]: Change conditional to [defined
UTMPX || _HAVE_UT_TV].
[_HAVE_UT_TV - 0 || defined UTMPX]: Change conditional to [defined
UTMPX || _HAVE_UT_TV - 0].
2001-07-06 Paul Eggert <eggert@twinsun.com>
* manual/argp.texi: Remove ignored LGPL copyright notice; it's
not appropriate for documentation anyway.
* manual/libc-texinfo.sh: "Library General Public License" ->
"Lesser General Public License".
2001-07-06 Andreas Jaeger <aj@suse.de>
* All files under GPL/LGPL version 2: Place under LGPL version
2.1.
1998-06-01 Gordon Matzigkeit <gord@profitpress.com>
* hurd/Makefile (routines): Add cthreads.
1998-05-31 Mark Kettenis <kettenis@phys.uva.nl>
* login/login.c (login): Let pututline take care of finding the
positin to insert the UTMP entry. This corrects a bug where ssh
was not reusing UTMP entries marked as DEAD_PROCESS.
Reported by Herbert Xu <herbert@gondor.apana.org.au>.
1998-05-31 Mark Kettenis <kettenis@phys.uva.nl>
* login/Makefile (tests): New variable, add tst-utmp and
tst-utmpx.
* login/tst-utmp.c: New file.
* login/tst-utmpx.c: New file.
1998-06-01 Gordon Matzigkeit <gord@profitpress.com>
* sysdeps/mach/hurd/errlist.c (sys_nerr, _sys_nerr): Make weak
aliases for _hurd_nerr, for programs that don't use sys_errlist,
but need sys_err.
1998-05-31 Mark Kettenis <kettenis@phys.uva.nl>
* sysdeps/generic/updwtmpx.c: Rename function to updwtmpx.
* libc.map: Add updwtmpx and utmpxname to GLIBC_2.1.
1998-05-31 Mark Kettenis <kettenis@phys.uva.nl>
* sysdeps/mach/hurd/read.c: Rename function to __libc_read and
make __read a weak alias. Use ANSI-style function definition.
* sysdeps/mach/hurd/write.c: Likewise.
1998-05-31 Mark Kettenis <kettenis@phys.uva.nl>
* sysdeps/mach/hurd/err_hurd.sub: Use _hurd_errlist instead of
_sys_errlist.
1998-05-30 Mark Kettenis <kettenis@phys.uva.nl>
* sysdeps/mach/hurd/Makefile ($(objpfx)librtld.os):
Renamed from librtld.so.
1998-06-02 Andreas Jaeger <aj@arthur.rhein-neckar.de>
* libc.map: Remove _IO_getline_info which was erroneously
introduced in section GLIBC_2.0.
Noticed by Horst von Brand <vonbrand@sleipnir.valparaiso.cl>.
1998-06-01 Gordon Matzigkeit <gord@profitpress.com>
* sysdeps/generic/socket.c (__socket): Renamed from socket, and
created a weak alias.
* sysdeps/mach/hurd/socket.c (__socket): Likewise.
1998-05-31 Gordon Matzigkeit <gord@profitpress.com>
* sysdeps/mach/hurd/ftruncate.c (__ftruncate): Rename from old
ftruncate function, and create a weak alias to ftruncate.
1998-06-01 Gordon Matzigkeit <gord@profitpress.com>
* grp/fgetgrent_r.c: Use &errno instead of __errno_location ().
* inet/getnetgrent_r.c: Likewise.
* nss/getXXbyYY_r.c: Likewise.
* nss/getXXent_r.c: Likewise.
* pwd/fgetpwent_r.c: Likewise.
* shadow/sgetspent_r.c: Likewise.
* shadow/fgetspent_r.c: Likewise.
* sunrpc/publickey.c: Likewise.
1998-06-01 Gordon Matzigkeit <gord@profitpress.com>
* hurd/libhurduser.map: New file.
* mach/libmachuser.map: Likewise.
* libc.map: Add Hurd-specific functions to version 2.1.
Add __flshfp and __fillbf.
1998-05-30 Andreas Schwab <schwab@issan.informatik.uni-dortmund.de>
* manual/signal.texi (Basic Signal Handling): Fix typo.
* manual/errno.texi (Error Codes): Likewise.
1998-06-02 Ulrich Drepper <drepper@cygnus.com>
* sysdeps/unix/sysv/linux/netipx/ipx.h: Include <bits/sockaddr.h>
instead of <sys/socket.h>.
Patch by NIIBE Yutaka <gniibe@mri.co.jp>
* sysdeps/unix/sysv/linux/powerpc/dl-sysdep.c (DL_FIND_ARG_COMPONENTS):
Finally make it working.
Patch by Mark Hatle <fray@kernel.crashing.org>.
1998-03-22 Paul Eggert <eggert@twinsun.com>
* posix/regex.c: Include <wchar.h> before <wctype.h>, to work around
a Solaris 2.6 bug.
Joseph Myers
Paul Pluzhnikov
Allan McRae
Paul Eggert
Ulrich Drepper
Roland McGrath
Andreas Jaeger