OpenE2K/glibc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
0ff64d3a18
glibc/iconv
History
H.J. Lu 8bcdb7e0c5 Mark internal functions with attribute_hidden [BZ #18822] 
Mark internal functions with attribute_hidden to allow direct access to
internal functions within libc.so and libc.a without using GOT nor PLT.

Size comparison of libc.so:

On x86-64:
        text	   data	    bss	    dec	    hex
Before: 1728577	  20584	  17088	1766249	 1af369
After : 1728593	  20584	  17088	1766265	 1af379

The only change is __gconv_release_shlib in iconv/gconv_dl.c is inlined
since it is hidden, which increases the code size of gconv_dl.os by 18
bytes.

On i686:
        text	   data	    bss	    dec	    hex
Before: 1869039	  11444	  11112	1891595	 1cdd0b
After : 1868635	  11444	  11112	1891191	 1cdb77

The code size is decreased by avoiding GOT/PLT for hidden functions.

	[BZ #18822]
	* iconv/gconv_int.h (__gconv_open): Add attribute_hidden.
	(__gconv_close): Likewise.
	(__gconv): Likewise.
	(__gconv_find_transform): Likewise.
	(__gconv_lookup_cache): Likewise.
	(__gconv_compare_alias_cache): Likewise.
	(__gconv_load_cache): Likewise.
	(__gconv_get_path): Likewise.
	(__gconv_close_transform): Likewise.
	(__gconv_release_cache): Likewise.
	(__gconv_find_shlib): Likewise.
	(__gconv_release_shlib): Likewise.
	(__gconv_get_builtin_trans): Likewise.
	(__gconv_compare_alias): Likewise.
	* include/dlfcn.h (_dlerror_run): Likewise.
	* include/stdio.h (__fortify_fail_abort): Likewise.
	* include/time.h (__tz_compute): Likewise.
	(__strptime_internal): Likewise.
	* intl/gettextP.h (_nl_find_domain): Likewise.
	(_nl_load_domain): Likewise.
	(_nl_find_msg): Likewise.
	* intl/plural-exp.h (FREE_EXPRESSION): Likewise.
	(EXTRACT_PLURAL_EXPRESSION): Likewise.
	* locale/coll-lookup.h (__collidx_table_lookup): Likewise.
	* resolv/gai_misc.h (__gai_enqueue_request): Likewise.
	(__gai_find_request): Likewise.
	(__gai_remove_request): Likewise.
	(__gai_notify): Likewise.
	(__gai_notify_only): Likewise.
	* sysdeps/generic/aio_misc.h (__aio_sigqueue): Likewise.
	* sysdeps/generic/ldsodefs.h (_dl_fini): Likewise.
	(_dl_non_dynamic_init): Likewise.
	(_dl_aux_init): Likewise.
	* sysdeps/i386/machine-gmon.h (mcount_internal): Likewise.
	* sysdeps/unix/sysv/linux/i386/olddirent.h (__old_getdents64):
	Likewise.
	* wcsmbs/wcsmbsload.h (__wcsmbs_load_conv): Likewise.
	(__wcsmbs_clone_conv): Likewise.
	(__wcsmbs_named_conv): Likewise.
2017-10-01 15:07:23 -07:00
..
dummy-repertoire.c
gconv_builtin.c iconv, intl, locale, wcsmbs: Remove internal_function 2017-08-31 15:59:06 +02:00
gconv_builtin.h
gconv_cache.c iconv, intl, locale, wcsmbs: Remove internal_function 2017-08-31 15:59:06 +02:00
gconv_charset.h
gconv_close.c iconv, intl, locale, wcsmbs: Remove internal_function 2017-08-31 15:59:06 +02:00
gconv_conf.c iconv, intl, locale, wcsmbs: Remove internal_function 2017-08-31 15:59:06 +02:00
gconv_db.c iconv, intl, locale, wcsmbs: Remove internal_function 2017-08-31 15:59:06 +02:00
gconv_dl.c iconv, intl, locale, wcsmbs: Remove internal_function 2017-08-31 15:59:06 +02:00
gconv_int.h Mark internal functions with attribute_hidden [BZ #18822] 2017-10-01 15:07:23 -07:00
gconv_open.c iconv, intl, locale, wcsmbs: Remove internal_function 2017-08-31 15:59:06 +02:00
gconv_simple.c
gconv_trans.c
gconv.c iconv, intl, locale, wcsmbs: Remove internal_function 2017-08-31 15:59:06 +02:00
gconv.h Remove __need macros from stdio.h and wchar.h. 2017-06-08 13:58:17 -04:00
iconv_charmap.c
iconv_close.c
iconv_open.c
iconv_prog.c iconv, intl, locale, wcsmbs: Remove internal_function 2017-08-31 15:59:06 +02:00
iconv_prog.h
iconv.c
iconv.h
iconvconfig.c iconv, intl, locale, wcsmbs: Remove internal_function 2017-08-31 15:59:06 +02:00
iconvconfig.h
loop.c Narrowing the visibility of libc-internal.h even further. 2017-03-01 20:33:46 -05:00
Makefile iconv_open: Fix heap corruption on gconv_init failure [BZ #22026] 2017-08-29 17:33:58 +02:00
skeleton.c
strtab.c
test-gconv-modules iconv_open: Fix heap corruption on gconv_init failure [BZ #22026] 2017-08-29 17:33:58 +02:00
tst-gconv-init-failure-mod.c iconv_open: Fix heap corruption on gconv_init failure [BZ #22026] 2017-08-29 17:33:58 +02:00
tst-gconv-init-failure.c iconv_open: Fix heap corruption on gconv_init failure [BZ #22026] 2017-08-29 17:33:58 +02:00
tst-iconv1.c
tst-iconv2.c
tst-iconv3.c
tst-iconv4.c
tst-iconv5.c
tst-iconv6.c Add missing header files throughout the testsuite. 2017-02-16 17:33:18 -05:00
Versions