c2d8f0b704
One group of warnings seen with -Wextra is warnings for static or inline not at the start of a declaration (-Wold-style-declaration). This patch fixes various such cases for inline, ensuring it comes at the start of the declaration (after any static). A common case of the fix is "static inline <type> __always_inline"; the definition of __always_inline starts with __inline, so the natural change is to "static __always_inline <type>". Other cases of the warning may be harder to fix (one pattern is a function definition that gets rewritten to be static by an including file, "#define funcname static wrapped_funcname" or similar), but it seems worth fixing these cases with inline anyway. Tested for x86_64. * elf/dl-load.h (_dl_postprocess_loadcmd): Use __always_inline before return type, without separate inline. * elf/dl-tunables.c (maybe_enable_malloc_check): Likewise. * elf/dl-tunables.h (tunable_is_name): Likewise. * malloc/malloc.c (do_set_trim_threshold): Likewise. (do_set_top_pad): Likewise. (do_set_mmap_threshold): Likewise. (do_set_mmaps_max): Likewise. (do_set_mallopt_check): Likewise. (do_set_perturb_byte): Likewise. (do_set_arena_test): Likewise. (do_set_arena_max): Likewise. (do_set_tcache_max): Likewise. (do_set_tcache_count): Likewise. (do_set_tcache_unsorted_limit): Likewise. * nis/nis_subr.c (count_dots): Likewise. * nptl/allocatestack.c (advise_stack_range): Likewise. * sysdeps/ieee754/dbl-64/s_sin.c (do_cos): Likewise. (do_sin): Likewise. (reduce_sincos): Likewise. (do_sincos): Likewise. * sysdeps/unix/sysv/linux/x86/elision-conf.c (do_set_elision_enable): Likewise. (TUNABLE_CALLBACK_FNDECL): Likewise. |
||
---|---|---|
.. | ||
alpha | ||
arm | ||
bsd | ||
i386 | ||
inet | ||
mips | ||
powerpc | ||
sh | ||
sysv/linux | ||
x86_64 | ||
clock_gettime.c | ||
clock_nanosleep.c | ||
clock_settime.c | ||
confstr.h | ||
get_child_max.c | ||
getlogin_r.c | ||
getlogin.c | ||
getpagesize.c | ||
grantpt.c | ||
ifreq.c | ||
Implies | ||
make-syscalls.sh | ||
Makefile | ||
pt-fcntl.c | ||
s-proto-cancel.S | ||
s-proto.S | ||
setxid.h | ||
sockatmark.c | ||
stime.c | ||
syscall-template.S | ||
syscall.S | ||
syscalls.list | ||
sysdep.h |