OpenE2K/glibc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
86140c6223
glibc/locale
History
Joseph Myers 32db86d558 Add fall-through comments. 
This patch adds fall-through comments in some cases where -Wextra
produces implicit-fallthrough warnings.

The patch is non-exhaustive.  Apart from architecture-specific code
for non-x86_64 architectures, it does not change sunrpc/xdr.c (legacy
code, probably should have such changes, but left to be dealt with
separately), or places that already had comments about the
fall-through but not matching the form expected by
-Wimplicit-fallthrough=3 (the default level with -Wextra; my
inclination is to adjust those comments to match rather than
downgrading to -Wimplicit-fallthrough=1 to allow any comment), or one
place where I thought the implicit fallthrough was not correct and so
should be handled separately as a bug fix.  I think the key thing to
consider in review of this patch is whether the fall-through is indeed
intended and correct in each place where such a comment is added.

Tested for x86_64.

	* elf/dl-exception.c (_dl_exception_create_format): Add
	fall-through comments.
	* elf/ldconfig.c (parse_conf_include): Likewise.
	* elf/rtld.c (print_statistics): Likewise.
	* locale/programs/charmap.c (parse_charmap): Likewise.
	* misc/mntent_r.c (__getmntent_r): Likewise.
	* posix/wordexp.c (parse_arith): Likewise.
	(parse_backtick): Likewise.
	* resolv/ns_ttl.c (ns_parse_ttl): Likewise.
	* sysdeps/x86/cpu-features.c (init_cpu_features): Likewise.
	* sysdeps/x86_64/dl-machine.h (elf_machine_rela): Likewise.
2019-02-12 10:30:34 +00:00
..
bits Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
programs Add fall-through comments. 2019-02-12 10:30:34 +00:00
broken_cur_max.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
C_name.c
C-address.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
C-collate.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
C-ctype.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
C-identification.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
C-measurement.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
C-messages.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
C-monetary.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
C-name.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
C-numeric.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
C-paper.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
C-telephone.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
C-time.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
C-translit.h.in Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
categories.def Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
coll-lookup.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
coll-lookup.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
duplocale.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
elem-hash.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
findlocale.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
freelocale.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
gen-translit.py Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
global-locale.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
hashval.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
indigits.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
indigitswc.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iso-639.def Add new locale yuw_PG [BZ #20952] 2017-10-25 10:49:35 +02:00
iso-3166.def
iso-4217.def
langinfo.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
lc-address.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
lc-collate.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
lc-ctype.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
lc-identification.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
lc-measurement.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
lc-messages.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
lc-monetary.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
lc-name.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
lc-numeric.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
lc-paper.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
lc-telephone.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
lc-time.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
loadarchive.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
loadlocale.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
locale.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
localeconv.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
localeinfo.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
localename.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
locarchive.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
Makefile Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
mb_cur_max.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
newlocale.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
nl_langinfo_l.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
nl_langinfo.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
outdigits.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
outdigitswc.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
setlocale.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
strlen-hash.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
SYS_libc.c
tst-C-locale.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-duplocale.c
tst-locname.c
uselocale.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
Versions
weight.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
weightwc.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
xlocale.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00