OpenE2K/glibc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
a4fea3f2c3
glibc/misc
History
Joseph Myers 8b4a118222 Fix -Os gnu_dev_* linknamespace, localplt issues (bug 15105, bug 19463). 
Building with -Os produces linknamespace and localplt failures for,
among other functions, gnu_dev_major, gnu_dev_minor and
gnu_dev_makedev.

The issue is that those functions are not inlined when building with
-Os.  While one could force them to be inlined in that case, it seems
more natural to fix this issue similarly to other namespace issues.
Thus, this patch makes gnu_dev_* into weak aliases for hidden symbols
__gnu_dev_*; __gnu_dev_* are then defined as inlines in the internal
include/sys/sysmacros.h, and uses of gnu_dev_* (often via the macros
major, minor and makedev) for which there are namespace issues are
changed to use __gnu_dev_*; where there are no namespace issues, use
of libc_hidden_proto serves to avoid unnecessary local PLT entry use.

Tested for x86_64, (a) without -Os, to verify the testsuite continues
to pass without problems and that the functions called under their new
names continue to be inlined as expected in that case; (b) with -Os,
to verify that the linknamespace and localplt failures in question go
away (but because of other such failures present, neither of the
relevant bugs can yet be closed).

	[BZ #15105]
	[BZ #19463]
	* include/sys/sysmacros.h [!_ISOMAC]
	(__SYSMACROS_NEED_IMPLEMENTATION): Define macro.
	[!_SYS_SYSMACROS_H_WRAPPER && !_ISOMAC]
	(_SYS_SYSMACROS_H_WRAPPER): Likewise.
	[!_SYS_SYSMACROS_H_WRAPPER && !_ISOMAC] (gnu_dev_major): Use
	libc_hidden_proto.
	[!_SYS_SYSMACROS_H_WRAPPER && !_ISOMAC] (gnu_dev_minor): Likewise.
	[!_SYS_SYSMACROS_H_WRAPPER && !_ISOMAC] (gnu_dev_makedev):
	Likewise.
	[!_SYS_SYSMACROS_H_WRAPPER && !_ISOMAC] (__SYSMACROS_DECL_TEMPL):
	Undefine and redefine to add use __gnu_dev_ prefix.
	[!_SYS_SYSMACROS_H_WRAPPER && !_ISOMAC] (__SYSMACROS_IMPL_TEMPL):
	Likewise.
	[!_SYS_SYSMACROS_H_WRAPPER && !_ISOMAC] (__gnu_dev_major): Declare
	and define as hidden inline function.
	[!_SYS_SYSMACROS_H_WRAPPER && !_ISOMAC] (__gnu_dev_minor):
	Likewise.
	[!_SYS_SYSMACROS_H_WRAPPER && !_ISOMAC] (__gnu_dev_makedev):
	Likewise.
	* misc/makedev.c (OUT_OF_LINE_IMPL_TEMPL): Use __gnu_dev_ prefix.
	(gnu_dev_major): Use weak_alias and libc_hidden_weak.
	(gnu_dev_minor): Likewise.
	(gnu_dev_makedev): Likewise.
	* csu/check_fds.c (check_one_fd): Use __gnu_dev_makedev instead of
	makedev.
	* posix/wordexp.c (exec_comm_child): Likewise.
	* sysdeps/mach/hurd/xmknodat.c (__xmknodat): Use __gnu_dev_minor
	instead of minor and __gnu_dev_major instead of major.
	* sysdeps/unix/sysv/linux/device-nrs.h (DEV_TTY_P): Use
	__gnu_dev_major instead of major.
	* sysdeps/unix/sysv/linux/pathconf.c (distinguish_extX): Use
	__gnu_dev_major instead of gnu_dev_major and __gnu_dev_minor
	instead of gnu_dev_minor.
	* sysdeps/unix/sysv/linux/ptsname.c (MASTER_P): Likewise.
	(SLAVE_P): Likewise.
	(__ptsname_internal): Use __gnu_dev_minor instead of minor.
	* sysdeps/unix/sysv/linux/ttyname.h (is_pty): Use __gnu_dev_major
	instead of major.
2018-02-07 14:57:31 +00:00
..
bits Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
sys Fix non-__GNUC__ definitions of __inline and __restrict (bug 17721). 2018-02-06 21:48:35 +00:00
acct.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
ar.h Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
brk.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
bug18240.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
bug-hsearch1.c
chflags.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
chroot.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
daemon.c Consolidate non cancellable close call 2017-08-18 18:38:55 -03:00
dirname.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
efgcvt_r.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
efgcvt.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
err.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
err.h Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
error.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
error.h Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fchflags.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fdatasync.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fgetxattr.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
flistxattr.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fremovexattr.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fsetxattr.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fstab.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fstab.h
fsync.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
ftruncate64.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
ftruncate.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
futimes.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
futimesat.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
getauxval.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
getclktck.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
getdomain.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
getdtsz.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
gethostid.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
gethostname.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
getloadavg.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
getpagesize.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
getpass.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
getsysstats.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
getttyent.c misc: Remove internal_function function attribute 2017-08-31 15:59:06 +02:00
getusershell.c
getxattr.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
gtty.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
hsearch_r.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
hsearch.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
ifunc-impl-list.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
init-misc.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
insremque.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
ioctl.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
lgetxattr.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
libgen.h Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
listxattr.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
llistxattr.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
lremovexattr.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
lsearch.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
lsetxattr.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
lutimes.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
madvise.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
makedev.c Fix -Os gnu_dev_* linknamespace, localplt issues (bug 15105, bug 19463). 2018-02-07 14:57:31 +00:00
Makefile Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
mincore.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
mkdtemp.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
mkostemp64.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
mkostemp.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
mkostemps64.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
mkostemps.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
mkstemp64.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
mkstemp.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
mkstemps64.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
mkstemps.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
mktemp.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
mlock.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
mlockall.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
mmap64.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
mmap.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
mntent_r.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
mntent.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
mntent.h Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
mprotect.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
msync.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
munlock.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
munlockall.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
munmap.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
preadv2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
preadv64.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
preadv64v2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
preadv.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
pselect.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
ptrace.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
pwritev2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
pwritev64.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
pwritev64v2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
pwritev.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
qefgcvt_r.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
qefgcvt.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
readv.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
reboot.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
regexp.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
regexp.h Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
remap_file_pages.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
removexattr.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
revoke.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
sbrk.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
search.h Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
select.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
setdomain.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
setegid.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
seteuid.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
sethostid.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
sethostname.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
setregid.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
setreuid.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
setxattr.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
sgtty.h Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
sstk.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
stab.h
stty.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
swapoff.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
swapon.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
sync.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
syncfs.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
syscall.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
syscall.h
sysexits.h
syslog.c misc: Remove internal_function function attribute 2017-08-31 15:59:06 +02:00
syslog.h
truncate64.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
truncate.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tsearch.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-atomic-long.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-atomic.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-dirname.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-efgcvt.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-empty.c
tst-error1.c
tst-fdset.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-hsearch.c
tst-insremque.c
tst-makedev.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-mntent2.c
tst-mntent-blank-corrupt.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-mntent-blank-passno.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-mntent.c
tst-preadvwritev2-common.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-preadvwritev2.c preadv2/pwritev2: Handle offset == -1 [BZ #22753] 2018-02-02 10:46:26 +01:00
tst-preadvwritev64.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-preadvwritev64v2.c preadv2/pwritev2: Handle offset == -1 [BZ #22753] 2018-02-02 10:46:26 +01:00
tst-preadvwritev-common.c preadv2/pwritev2: Handle offset == -1 [BZ #22753] 2018-02-02 10:46:26 +01:00
tst-preadvwritev.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-pselect.c misc/tst-pselect.c: Add copyright header 2018-01-02 22:07:59 +01:00
tst-tsearch.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
ttyent.h
ttyslot.c
ualarm.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
usleep.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
ustat.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
ustat.h
utimes.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
Versions
vhangup.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
writev.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00