Go to file
Arjun Shankar c5288d378a Remove unnecessary locking when reading iconv configuration [BZ #22062]
In iconv/gconv_conf.c, __gconv_get_path unnecessarily obtains a lock when
populating the array pointed to by __gconv_path_elem. The locking is not
necessary because all calls to __gconv_read_conf (which in turn calls
__gconv_get_path) are serialized using __libc_once.

This patch:
- removes all locking in __gconv_get_path;
- replaces all explicitly serialized __gconv_read_conf calls with calls to
  __gconv_load_conf, a new wrapper that is serialized internally;
- adds a new test, iconv/tst-iconv_mt.c, to exercise iconv initialization,
  usage, and cleanup in a multi-threaded program;
- indents __gconv_get_path correctly, removing tab characters (which makes
  the patch look a little bigger than it really is).

After removing the unnecessary locking, it was confirmed that the test case
fails if the relevant __libc_once is removed. Additionally, four localedata
and iconvdata tests also fail. This gives confidence that the testsuite
sufficiently guards against some regressions relating to multi-threading
with iconv.

Tested on x86_64 and i686.
2018-10-17 17:47:29 +02:00
argp
assert
benchtests Don't reduce test timeout to less than default 2018-10-17 09:34:13 +02:00
bits
catgets
ChangeLog.old
conform Replace conform/list-header-symbols.pl with a Python script. 2018-08-31 21:19:51 +00:00
crypt Don't reduce test timeout to less than default 2018-10-17 09:34:13 +02:00
csu
ctype
debug __readlink_chk: Remove micro-optimization 2018-08-21 11:24:12 +02:00
dirent Don't reduce test timeout to less than default 2018-10-17 09:34:13 +02:00
dlfcn
elf Add missing unwind information to ld.so on powerpc32 (bug 23707) 2018-09-26 16:49:30 +02:00
gmon
gnulib
grp [BZ #20271] Add newlines in __libc_fatal calls. 2018-08-31 18:04:32 -07:00
gshadow
hesiod
htl hurd: Add missing symbols for proper libc_get/setspecific 2018-08-08 01:55:04 +02:00
hurd hurd: Fix exec usage of mach_setup_thread 2018-08-01 00:10:03 +02:00
iconv Remove unnecessary locking when reading iconv configuration [BZ #22062] 2018-10-17 17:47:29 +02:00
iconvdata
include Use copysign functions not __copysign functions in glibc libm. 2018-09-27 20:04:48 +00:00
inet
intl
io Don't reduce test timeout to less than default 2018-10-17 09:34:13 +02:00
libio Don't reduce test timeout to less than default 2018-10-17 09:34:13 +02:00
locale Fix out of bounds access in findidxwc (bug 23442) 2018-07-25 10:50:03 +02:00
localedata Don't reduce test timeout to less than default 2018-10-17 09:34:13 +02:00
login
mach hurd: Fix exec usage of mach_setup_thread 2018-08-01 00:10:03 +02:00
malloc malloc: Add ChangeLog for accidentally committed change 2018-08-20 14:57:13 +02:00
manual Don't build libnsl for new ABIs 2018-09-24 10:23:10 +02:00
math Add more fma tests. 2018-10-02 17:17:15 +00:00
mathvec
misc Fix misreported errno on preadv2/pwritev2 (BZ#23579) 2018-09-28 10:08:09 -03:00
nis Don't build libnsl for new ABIs 2018-09-24 10:23:10 +02:00
nptl Fix race in pthread_mutex_lock while promoting to PTHREAD_MUTEX_ELISION_NP [BZ #23275] 2018-10-17 12:23:04 +02:00
nptl_db
nscd [BZ #20271] Add newlines in __libc_fatal calls. 2018-08-31 18:04:32 -07:00
nss Increase timeout of nss/tst-nss-files-hosts-multi 2018-10-09 15:57:01 +01:00
po Update translations for be. 2018-08-24 22:26:41 -04:00
posix Don't reduce test timeout to less than default 2018-10-17 09:34:13 +02:00
pwd
resolv
resource
rt Don't reduce test timeout to less than default 2018-10-17 09:34:13 +02:00
scripts Don't build libnsl for new ABIs 2018-09-24 10:23:10 +02:00
setjmp
shadow
signal
socket
soft-fp
stdio-common Don't reduce test timeout to less than default 2018-10-17 09:34:13 +02:00
stdlib Don't reduce test timeout to less than default 2018-10-17 09:34:13 +02:00
streams
string Fix strstr bug with huge needles (bug 23637) 2018-09-19 16:50:18 +01:00
sunrpc
support Adjust name of ld.so in test-container.c. 2018-10-04 13:07:29 +02:00
sysdeps Use single bits/shm.h for all architectures. 2018-10-17 11:56:28 +00:00
sysvipc
termios
time Don't reduce test timeout to less than default 2018-10-17 09:34:13 +02:00
timezone Don't reduce test timeout to less than default 2018-10-17 09:34:13 +02:00
wcsmbs
wctype
.gitattributes
.gitignore
abi-tags
aclocal.m4
ChangeLog Remove unnecessary locking when reading iconv configuration [BZ #22062] 2018-10-17 17:47:29 +02:00
config.h.in
config.make.in Fix ifunc support with DT_TEXTREL segments (BZ#20480) 2018-09-25 16:27:50 -03:00
configure Fix ifunc support with DT_TEXTREL segments (BZ#20480) 2018-09-25 16:27:50 -03:00
configure.ac Fix ifunc support with DT_TEXTREL segments (BZ#20480) 2018-09-25 16:27:50 -03:00
COPYING
COPYING.LIB
extra-lib.mk
gen-locales.mk
INSTALL Don't build libnsl for new ABIs 2018-09-24 10:23:10 +02:00
libc-abis
libof-iterator.mk
LICENSES
MAINTAINERS
Makeconfig Don't build libnsl for new ABIs 2018-09-24 10:23:10 +02:00
Makefile Remove leading space from testrun.sh 2018-09-26 10:13:13 +02:00
Makefile.in
Makerules Don't build libnsl for new ABIs 2018-09-24 10:23:10 +02:00
NEWS powerpc: Only enable TLE with PPC_FEATURE2_HTM_NOSC 2018-09-21 10:18:03 -07:00
o-iterator.mk
README
Rules Add test-in-container infrastructure. 2018-08-22 21:20:37 -04:00
shlib-versions
test-skeleton.c
version.h Open master branch for glibc 2.29 development 2018-08-01 01:35:02 -04:00

This directory contains the sources of the GNU C Library.
See the file "version.h" for what release version you have.

The GNU C Library is the standard system C library for all GNU systems,
and is an important part of what makes up a GNU system.  It provides the
system API for all programs written in C and C-compatible languages such
as C++ and Objective C; the runtime facilities of other programming
languages use the C library to access the underlying operating system.

In GNU/Linux systems, the C library works with the Linux kernel to
implement the operating system behavior seen by user applications.
In GNU/Hurd systems, it works with a microkernel and Hurd servers.

The GNU C Library implements much of the POSIX.1 functionality in the
GNU/Hurd system, using configurations i[4567]86-*-gnu.

When working with Linux kernels, this version of the GNU C Library
requires Linux kernel version 3.2 or later.

Also note that the shared version of the libgcc_s library must be
installed for the pthread library to work correctly.

The GNU C Library supports these configurations for using Linux kernels:

	aarch64*-*-linux-gnu
	alpha*-*-linux-gnu
	arm-*-linux-gnueabi
	hppa-*-linux-gnu
	i[4567]86-*-linux-gnu
	x86_64-*-linux-gnu	Can build either x86_64 or x32
	ia64-*-linux-gnu
	m68k-*-linux-gnu
	microblaze*-*-linux-gnu
	mips-*-linux-gnu
	mips64-*-linux-gnu
	powerpc-*-linux-gnu	Hardware or software floating point, BE only.
	powerpc64*-*-linux-gnu	Big-endian and little-endian.
	s390-*-linux-gnu
	s390x-*-linux-gnu
	riscv64-*-linux-gnu
	sh[34]-*-linux-gnu
	sparc*-*-linux-gnu
	sparc64*-*-linux-gnu

If you are interested in doing a port, please contact the glibc
maintainers; see http://www.gnu.org/software/libc/ for more
information.

See the file INSTALL to find out how to configure, build, and install
the GNU C Library.  You might also consider reading the WWW pages for
the C library at http://www.gnu.org/software/libc/.

The GNU C Library is (almost) completely documented by the Texinfo manual
found in the `manual/' subdirectory.  The manual is still being updated
and contains some known errors and omissions; we regret that we do not
have the resources to work on the manual as much as we would like.  For
corrections to the manual, please file a bug in the `manual' component,
following the bug-reporting instructions below.  Please be sure to check
the manual in the current development sources to see if your problem has
already been corrected.

Please see http://www.gnu.org/software/libc/bugs.html for bug reporting
information.  We are now using the Bugzilla system to track all bug reports.
This web page gives detailed information on how to report bugs properly.

The GNU C Library is free software.  See the file COPYING.LIB for copying
conditions, and LICENSES for notices about a few contributions that require
these additional notices to be distributed.  License copyright years may be
listed using range notation, e.g., 1996-2015, indicating that every year in
the range, inclusive, is a copyrightable year that would otherwise be listed
individually.