add fixmes for the ucontext_t shadow stack field

This commit is contained in:
Adam C. Foltzer 2019-06-27 09:32:52 -07:00
parent 886bb3f2f8
commit 339fe22653
No known key found for this signature in database
GPG Key ID: 2A91B421C62B535C
2 changed files with 4 additions and 0 deletions

View File

@ -2098,6 +2098,7 @@ fn test_linux(target: &str) {
// FIXME: musl version using by mips build jobs 1.0.15 is ancient:
"ifmap" | "ifreq" | "ifconf" if mips32_musl => true,
// FIXME: remove once Ubuntu 20.04 LTS is released, somewhere in 2020.
// ucontext_t added a new field as of glibc 2.28; our struct definition is
// conservative and omits the field, but that means the size doesn't match for newer
// glibcs (see https://github.com/rust-lang/libc/issues/1410)

View File

@ -285,6 +285,9 @@ s_no_extra_traits! {
pub uc_mcontext: mcontext_t,
pub uc_sigmask: ::sigset_t,
__private: [u8; 512],
// FIXME: the shadow stack field requires glibc >= 2.28.
// Re-add once we drop compatibility with glibc versions older than 2.28.
// __ssp: [::c_ulonglong; 4],
}
}