At time of writing, illumos systems do not provide an implementation of
the openpty() and forkpty() wrappers provided on some other UNIX
systems. While we expect to grow an implementation, it seems prudent to
provide a compatibility routine here first to unblock illumos support in
the popular nix crate.
This change fixes two issues. First, the current cfmakeraw()
implementation in this crate appears to be making a stack copy of the
input "struct termios" before modifying it, rather than correctly
modifying the original through the pointer. Before this modification
the routine did not, thus, set the flags for raw mode.
Second, we address the default settings of the MIN and TIME terminal
options. On at least FreeBSD and Linux systems, the modern default
value for MIN appears to be 1; i.e., block and wait for at least one
input byte. On most Solaris and illumos systems, the MIN control
character slot overlaps with EOF, and thus has a default value of 4.
This breaks at least the examples in the "termion" crate, and probably
quite a lot of other software written first and foremost for Linux
systems. We need to force the MIN value to 1 while switching to raw
mode.
and Solaris-derived distributions (i.e. illumos). In addition, a number
of missing definitions (and compatability functions) that have been
found necessary to run a number of rust binaries on illumos have been
added.
Portions were contributed by Mike Zeller <mike@mikezeller.net>
Yuki Okushi
Joshua M. Clulow
gnzlbg
Jason King