2009-06-22 15:36:29 +02:00
|
|
|
/*
|
2009-11-06 13:52:22 +01:00
|
|
|
* Synopsys DesignWare I2C adapter driver (master only).
|
2009-06-22 15:36:29 +02:00
|
|
|
*
|
|
|
|
* Based on the TI DAVINCI I2C adapter driver.
|
|
|
|
*
|
|
|
|
* Copyright (C) 2006 Texas Instruments.
|
|
|
|
* Copyright (C) 2007 MontaVista Software Inc.
|
|
|
|
* Copyright (C) 2009 Provigent Ltd.
|
|
|
|
*
|
|
|
|
* ----------------------------------------------------------------------------
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program; if not, write to the Free Software
|
|
|
|
* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
|
|
|
|
* ----------------------------------------------------------------------------
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
#include <linux/clk.h>
|
|
|
|
#include <linux/errno.h>
|
|
|
|
#include <linux/err.h>
|
2011-10-29 11:57:23 +02:00
|
|
|
#include <linux/i2c.h>
|
2009-06-22 15:36:29 +02:00
|
|
|
#include <linux/interrupt.h>
|
|
|
|
#include <linux/io.h>
|
2011-10-29 11:57:23 +02:00
|
|
|
#include <linux/delay.h>
|
|
|
|
#include "i2c-designware-core.h"
|
2009-11-06 13:51:57 +01:00
|
|
|
|
2009-06-22 15:36:29 +02:00
|
|
|
static char *abort_sources[] = {
|
2009-11-06 13:52:22 +01:00
|
|
|
[ABRT_7B_ADDR_NOACK] =
|
2009-06-22 15:36:29 +02:00
|
|
|
"slave address not acknowledged (7bit mode)",
|
2009-11-06 13:52:22 +01:00
|
|
|
[ABRT_10ADDR1_NOACK] =
|
2009-06-22 15:36:29 +02:00
|
|
|
"first address byte not acknowledged (10bit mode)",
|
2009-11-06 13:52:22 +01:00
|
|
|
[ABRT_10ADDR2_NOACK] =
|
2009-06-22 15:36:29 +02:00
|
|
|
"second address byte not acknowledged (10bit mode)",
|
2009-11-06 13:52:22 +01:00
|
|
|
[ABRT_TXDATA_NOACK] =
|
2009-06-22 15:36:29 +02:00
|
|
|
"data not acknowledged",
|
2009-11-06 13:52:22 +01:00
|
|
|
[ABRT_GCALL_NOACK] =
|
2009-06-22 15:36:29 +02:00
|
|
|
"no acknowledgement for a general call",
|
2009-11-06 13:52:22 +01:00
|
|
|
[ABRT_GCALL_READ] =
|
2009-06-22 15:36:29 +02:00
|
|
|
"read after general call",
|
2009-11-06 13:52:22 +01:00
|
|
|
[ABRT_SBYTE_ACKDET] =
|
2009-06-22 15:36:29 +02:00
|
|
|
"start byte acknowledged",
|
2009-11-06 13:52:22 +01:00
|
|
|
[ABRT_SBYTE_NORSTRT] =
|
2009-06-22 15:36:29 +02:00
|
|
|
"trying to send start byte when restart is disabled",
|
2009-11-06 13:52:22 +01:00
|
|
|
[ABRT_10B_RD_NORSTRT] =
|
2009-06-22 15:36:29 +02:00
|
|
|
"trying to read when restart is disabled (10bit mode)",
|
2009-11-06 13:52:22 +01:00
|
|
|
[ABRT_MASTER_DIS] =
|
2009-06-22 15:36:29 +02:00
|
|
|
"trying to use disabled adapter",
|
2009-11-06 13:52:22 +01:00
|
|
|
[ARB_LOST] =
|
2009-06-22 15:36:29 +02:00
|
|
|
"lost arbitration",
|
|
|
|
};
|
|
|
|
|
2011-10-29 11:57:23 +02:00
|
|
|
u32 dw_readl(struct dw_i2c_dev *dev, int offset)
|
2011-10-06 20:26:25 +02:00
|
|
|
{
|
2011-10-06 20:26:27 +02:00
|
|
|
u32 value = readl(dev->base + offset);
|
|
|
|
|
|
|
|
if (dev->swab)
|
|
|
|
return swab32(value);
|
|
|
|
else
|
|
|
|
return value;
|
2011-10-06 20:26:25 +02:00
|
|
|
}
|
|
|
|
|
2011-10-29 11:57:23 +02:00
|
|
|
void dw_writel(struct dw_i2c_dev *dev, u32 b, int offset)
|
2011-10-06 20:26:25 +02:00
|
|
|
{
|
2011-10-06 20:26:27 +02:00
|
|
|
if (dev->swab)
|
|
|
|
b = swab32(b);
|
|
|
|
|
2011-10-06 20:26:25 +02:00
|
|
|
writel(b, dev->base + offset);
|
|
|
|
}
|
|
|
|
|
i2c-designware: Improved _HCNT/_LCNT calculation
* Calculate with accurate conditional expressions from DW manuals.
* Round ic_clk by adding 0.5 as it's important at high ic_clk rate.
* Take into account "tHD;STA" issue for _HCNT calculation.
* Take into account "tf" for _LCNT calculation.
* Add "cond" and "offset" fot further correction requirements.
For _HCNT calculation, there's one issue needs to be carefully
considered; DesignWare I2C core doesn't seem to have solid strategy
to meet the tHD;STA timing spec. If you configure _HCNT based on the
tHIGH timing spec, it easily results in violation of the tHD;STA spec.
After many trials, we came to the conclusion that the tHD;STA period
is proportional to (_HCNT + 3). For the safety's sake, this should be
selected by default.
As for _LCNT calculation, DW I2C core has one characteristic behavior;
he starts counting the SCL CNTs for the LOW period of the SCL clock
(tLOW) as soon as it pulls the SCL line. At that time, he doesn't take
into account the fall time of SCL signal (tf), IOW, he starts counting
CNTs without confirming the SCL input voltage has dropped to below VIL.
This characteristics becomes a problem on some platforms where tf is
considerably long, and results in violation of the tLOW timing spec.
To make the driver configurable as much as possible for various cases,
we'd have separated arguments "tf" and "offset", and for safety default
values should be 0.3 us and 0, respectively.
Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
2009-11-06 13:47:01 +01:00
|
|
|
static u32
|
|
|
|
i2c_dw_scl_hcnt(u32 ic_clk, u32 tSYMBOL, u32 tf, int cond, int offset)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* DesignWare I2C core doesn't seem to have solid strategy to meet
|
|
|
|
* the tHD;STA timing spec. Configuring _HCNT based on tHIGH spec
|
|
|
|
* will result in violation of the tHD;STA spec.
|
|
|
|
*/
|
|
|
|
if (cond)
|
|
|
|
/*
|
|
|
|
* Conditional expression:
|
|
|
|
*
|
|
|
|
* IC_[FS]S_SCL_HCNT + (1+4+3) >= IC_CLK * tHIGH
|
|
|
|
*
|
|
|
|
* This is based on the DW manuals, and represents an ideal
|
|
|
|
* configuration. The resulting I2C bus speed will be
|
|
|
|
* faster than any of the others.
|
|
|
|
*
|
|
|
|
* If your hardware is free from tHD;STA issue, try this one.
|
|
|
|
*/
|
|
|
|
return (ic_clk * tSYMBOL + 5000) / 10000 - 8 + offset;
|
|
|
|
else
|
|
|
|
/*
|
|
|
|
* Conditional expression:
|
|
|
|
*
|
|
|
|
* IC_[FS]S_SCL_HCNT + 3 >= IC_CLK * (tHD;STA + tf)
|
|
|
|
*
|
|
|
|
* This is just experimental rule; the tHD;STA period turned
|
|
|
|
* out to be proportinal to (_HCNT + 3). With this setting,
|
|
|
|
* we could meet both tHIGH and tHD;STA timing specs.
|
|
|
|
*
|
|
|
|
* If unsure, you'd better to take this alternative.
|
|
|
|
*
|
|
|
|
* The reason why we need to take into account "tf" here,
|
|
|
|
* is the same as described in i2c_dw_scl_lcnt().
|
|
|
|
*/
|
|
|
|
return (ic_clk * (tSYMBOL + tf) + 5000) / 10000 - 3 + offset;
|
|
|
|
}
|
|
|
|
|
|
|
|
static u32 i2c_dw_scl_lcnt(u32 ic_clk, u32 tLOW, u32 tf, int offset)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* Conditional expression:
|
|
|
|
*
|
|
|
|
* IC_[FS]S_SCL_LCNT + 1 >= IC_CLK * (tLOW + tf)
|
|
|
|
*
|
|
|
|
* DW I2C core starts counting the SCL CNTs for the LOW period
|
|
|
|
* of the SCL clock (tLOW) as soon as it pulls the SCL line.
|
|
|
|
* In order to meet the tLOW timing spec, we need to take into
|
|
|
|
* account the fall time of SCL signal (tf). Default tf value
|
|
|
|
* should be 0.3 us, for safety.
|
|
|
|
*/
|
|
|
|
return ((ic_clk * (tLOW + tf) + 5000) / 10000) - 1 + offset;
|
|
|
|
}
|
|
|
|
|
2009-06-22 15:36:29 +02:00
|
|
|
/**
|
|
|
|
* i2c_dw_init() - initialize the designware i2c master hardware
|
|
|
|
* @dev: device private data
|
|
|
|
*
|
|
|
|
* This functions configures and enables the I2C master.
|
|
|
|
* This function is called during I2C init function, and in case of timeout at
|
|
|
|
* run time.
|
|
|
|
*/
|
2011-10-29 11:57:23 +02:00
|
|
|
int i2c_dw_init(struct dw_i2c_dev *dev)
|
2009-06-22 15:36:29 +02:00
|
|
|
{
|
2011-10-06 20:26:30 +02:00
|
|
|
u32 input_clock_khz;
|
i2c-designware: Improved _HCNT/_LCNT calculation
* Calculate with accurate conditional expressions from DW manuals.
* Round ic_clk by adding 0.5 as it's important at high ic_clk rate.
* Take into account "tHD;STA" issue for _HCNT calculation.
* Take into account "tf" for _LCNT calculation.
* Add "cond" and "offset" fot further correction requirements.
For _HCNT calculation, there's one issue needs to be carefully
considered; DesignWare I2C core doesn't seem to have solid strategy
to meet the tHD;STA timing spec. If you configure _HCNT based on the
tHIGH timing spec, it easily results in violation of the tHD;STA spec.
After many trials, we came to the conclusion that the tHD;STA period
is proportional to (_HCNT + 3). For the safety's sake, this should be
selected by default.
As for _LCNT calculation, DW I2C core has one characteristic behavior;
he starts counting the SCL CNTs for the LOW period of the SCL clock
(tLOW) as soon as it pulls the SCL line. At that time, he doesn't take
into account the fall time of SCL signal (tf), IOW, he starts counting
CNTs without confirming the SCL input voltage has dropped to below VIL.
This characteristics becomes a problem on some platforms where tf is
considerably long, and results in violation of the tLOW timing spec.
To make the driver configurable as much as possible for various cases,
we'd have separated arguments "tf" and "offset", and for safety default
values should be 0.3 us and 0, respectively.
Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
2009-11-06 13:47:01 +01:00
|
|
|
u32 ic_con, hcnt, lcnt;
|
2011-10-06 20:26:28 +02:00
|
|
|
u32 reg;
|
|
|
|
|
2011-10-06 20:26:30 +02:00
|
|
|
input_clock_khz = dev->get_clk_rate_khz(dev);
|
|
|
|
|
2011-10-06 20:26:28 +02:00
|
|
|
/* Configure register endianess access */
|
|
|
|
reg = dw_readl(dev, DW_IC_COMP_TYPE);
|
|
|
|
if (reg == ___constant_swab32(DW_IC_COMP_TYPE_VALUE)) {
|
|
|
|
dev->swab = 1;
|
|
|
|
reg = DW_IC_COMP_TYPE_VALUE;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (reg != DW_IC_COMP_TYPE_VALUE) {
|
|
|
|
dev_err(dev->dev, "Unknown Synopsys component type: "
|
|
|
|
"0x%08x\n", reg);
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
2009-06-22 15:36:29 +02:00
|
|
|
|
|
|
|
/* Disable the adapter */
|
2011-10-06 20:26:25 +02:00
|
|
|
dw_writel(dev, 0, DW_IC_ENABLE);
|
2009-06-22 15:36:29 +02:00
|
|
|
|
|
|
|
/* set standard and fast speed deviders for high/low periods */
|
i2c-designware: Improved _HCNT/_LCNT calculation
* Calculate with accurate conditional expressions from DW manuals.
* Round ic_clk by adding 0.5 as it's important at high ic_clk rate.
* Take into account "tHD;STA" issue for _HCNT calculation.
* Take into account "tf" for _LCNT calculation.
* Add "cond" and "offset" fot further correction requirements.
For _HCNT calculation, there's one issue needs to be carefully
considered; DesignWare I2C core doesn't seem to have solid strategy
to meet the tHD;STA timing spec. If you configure _HCNT based on the
tHIGH timing spec, it easily results in violation of the tHD;STA spec.
After many trials, we came to the conclusion that the tHD;STA period
is proportional to (_HCNT + 3). For the safety's sake, this should be
selected by default.
As for _LCNT calculation, DW I2C core has one characteristic behavior;
he starts counting the SCL CNTs for the LOW period of the SCL clock
(tLOW) as soon as it pulls the SCL line. At that time, he doesn't take
into account the fall time of SCL signal (tf), IOW, he starts counting
CNTs without confirming the SCL input voltage has dropped to below VIL.
This characteristics becomes a problem on some platforms where tf is
considerably long, and results in violation of the tLOW timing spec.
To make the driver configurable as much as possible for various cases,
we'd have separated arguments "tf" and "offset", and for safety default
values should be 0.3 us and 0, respectively.
Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
2009-11-06 13:47:01 +01:00
|
|
|
|
|
|
|
/* Standard-mode */
|
|
|
|
hcnt = i2c_dw_scl_hcnt(input_clock_khz,
|
|
|
|
40, /* tHD;STA = tHIGH = 4.0 us */
|
|
|
|
3, /* tf = 0.3 us */
|
|
|
|
0, /* 0: DW default, 1: Ideal */
|
|
|
|
0); /* No offset */
|
|
|
|
lcnt = i2c_dw_scl_lcnt(input_clock_khz,
|
|
|
|
47, /* tLOW = 4.7 us */
|
|
|
|
3, /* tf = 0.3 us */
|
|
|
|
0); /* No offset */
|
2011-10-06 20:26:25 +02:00
|
|
|
dw_writel(dev, hcnt, DW_IC_SS_SCL_HCNT);
|
|
|
|
dw_writel(dev, lcnt, DW_IC_SS_SCL_LCNT);
|
i2c-designware: Improved _HCNT/_LCNT calculation
* Calculate with accurate conditional expressions from DW manuals.
* Round ic_clk by adding 0.5 as it's important at high ic_clk rate.
* Take into account "tHD;STA" issue for _HCNT calculation.
* Take into account "tf" for _LCNT calculation.
* Add "cond" and "offset" fot further correction requirements.
For _HCNT calculation, there's one issue needs to be carefully
considered; DesignWare I2C core doesn't seem to have solid strategy
to meet the tHD;STA timing spec. If you configure _HCNT based on the
tHIGH timing spec, it easily results in violation of the tHD;STA spec.
After many trials, we came to the conclusion that the tHD;STA period
is proportional to (_HCNT + 3). For the safety's sake, this should be
selected by default.
As for _LCNT calculation, DW I2C core has one characteristic behavior;
he starts counting the SCL CNTs for the LOW period of the SCL clock
(tLOW) as soon as it pulls the SCL line. At that time, he doesn't take
into account the fall time of SCL signal (tf), IOW, he starts counting
CNTs without confirming the SCL input voltage has dropped to below VIL.
This characteristics becomes a problem on some platforms where tf is
considerably long, and results in violation of the tLOW timing spec.
To make the driver configurable as much as possible for various cases,
we'd have separated arguments "tf" and "offset", and for safety default
values should be 0.3 us and 0, respectively.
Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
2009-11-06 13:47:01 +01:00
|
|
|
dev_dbg(dev->dev, "Standard-mode HCNT:LCNT = %d:%d\n", hcnt, lcnt);
|
|
|
|
|
|
|
|
/* Fast-mode */
|
|
|
|
hcnt = i2c_dw_scl_hcnt(input_clock_khz,
|
|
|
|
6, /* tHD;STA = tHIGH = 0.6 us */
|
|
|
|
3, /* tf = 0.3 us */
|
|
|
|
0, /* 0: DW default, 1: Ideal */
|
|
|
|
0); /* No offset */
|
|
|
|
lcnt = i2c_dw_scl_lcnt(input_clock_khz,
|
|
|
|
13, /* tLOW = 1.3 us */
|
|
|
|
3, /* tf = 0.3 us */
|
|
|
|
0); /* No offset */
|
2011-10-06 20:26:25 +02:00
|
|
|
dw_writel(dev, hcnt, DW_IC_FS_SCL_HCNT);
|
|
|
|
dw_writel(dev, lcnt, DW_IC_FS_SCL_LCNT);
|
i2c-designware: Improved _HCNT/_LCNT calculation
* Calculate with accurate conditional expressions from DW manuals.
* Round ic_clk by adding 0.5 as it's important at high ic_clk rate.
* Take into account "tHD;STA" issue for _HCNT calculation.
* Take into account "tf" for _LCNT calculation.
* Add "cond" and "offset" fot further correction requirements.
For _HCNT calculation, there's one issue needs to be carefully
considered; DesignWare I2C core doesn't seem to have solid strategy
to meet the tHD;STA timing spec. If you configure _HCNT based on the
tHIGH timing spec, it easily results in violation of the tHD;STA spec.
After many trials, we came to the conclusion that the tHD;STA period
is proportional to (_HCNT + 3). For the safety's sake, this should be
selected by default.
As for _LCNT calculation, DW I2C core has one characteristic behavior;
he starts counting the SCL CNTs for the LOW period of the SCL clock
(tLOW) as soon as it pulls the SCL line. At that time, he doesn't take
into account the fall time of SCL signal (tf), IOW, he starts counting
CNTs without confirming the SCL input voltage has dropped to below VIL.
This characteristics becomes a problem on some platforms where tf is
considerably long, and results in violation of the tLOW timing spec.
To make the driver configurable as much as possible for various cases,
we'd have separated arguments "tf" and "offset", and for safety default
values should be 0.3 us and 0, respectively.
Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
2009-11-06 13:47:01 +01:00
|
|
|
dev_dbg(dev->dev, "Fast-mode HCNT:LCNT = %d:%d\n", hcnt, lcnt);
|
2009-06-22 15:36:29 +02:00
|
|
|
|
2009-11-06 13:48:12 +01:00
|
|
|
/* Configure Tx/Rx FIFO threshold levels */
|
2011-10-06 20:26:25 +02:00
|
|
|
dw_writel(dev, dev->tx_fifo_depth - 1, DW_IC_TX_TL);
|
|
|
|
dw_writel(dev, 0, DW_IC_RX_TL);
|
2009-11-06 13:48:12 +01:00
|
|
|
|
2009-06-22 15:36:29 +02:00
|
|
|
/* configure the i2c master */
|
|
|
|
ic_con = DW_IC_CON_MASTER | DW_IC_CON_SLAVE_DISABLE |
|
|
|
|
DW_IC_CON_RESTART_EN | DW_IC_CON_SPEED_FAST;
|
2011-10-06 20:26:25 +02:00
|
|
|
dw_writel(dev, ic_con, DW_IC_CON);
|
2011-10-06 20:26:28 +02:00
|
|
|
return 0;
|
2009-06-22 15:36:29 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Waiting for bus not busy
|
|
|
|
*/
|
|
|
|
static int i2c_dw_wait_bus_not_busy(struct dw_i2c_dev *dev)
|
|
|
|
{
|
|
|
|
int timeout = TIMEOUT;
|
|
|
|
|
2011-10-06 20:26:25 +02:00
|
|
|
while (dw_readl(dev, DW_IC_STATUS) & DW_IC_STATUS_ACTIVITY) {
|
2009-06-22 15:36:29 +02:00
|
|
|
if (timeout <= 0) {
|
|
|
|
dev_warn(dev->dev, "timeout waiting for bus ready\n");
|
|
|
|
return -ETIMEDOUT;
|
|
|
|
}
|
|
|
|
timeout--;
|
|
|
|
mdelay(1);
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-11-06 13:48:55 +01:00
|
|
|
static void i2c_dw_xfer_init(struct dw_i2c_dev *dev)
|
|
|
|
{
|
|
|
|
struct i2c_msg *msgs = dev->msgs;
|
|
|
|
u32 ic_con;
|
|
|
|
|
|
|
|
/* Disable the adapter */
|
2011-10-06 20:26:25 +02:00
|
|
|
dw_writel(dev, 0, DW_IC_ENABLE);
|
2009-11-06 13:48:55 +01:00
|
|
|
|
|
|
|
/* set the slave (target) address */
|
2011-10-06 20:26:25 +02:00
|
|
|
dw_writel(dev, msgs[dev->msg_write_idx].addr, DW_IC_TAR);
|
2009-11-06 13:48:55 +01:00
|
|
|
|
|
|
|
/* if the slave address is ten bit address, enable 10BITADDR */
|
2011-10-06 20:26:25 +02:00
|
|
|
ic_con = dw_readl(dev, DW_IC_CON);
|
2009-11-06 13:48:55 +01:00
|
|
|
if (msgs[dev->msg_write_idx].flags & I2C_M_TEN)
|
|
|
|
ic_con |= DW_IC_CON_10BITADDR_MASTER;
|
|
|
|
else
|
|
|
|
ic_con &= ~DW_IC_CON_10BITADDR_MASTER;
|
2011-10-06 20:26:25 +02:00
|
|
|
dw_writel(dev, ic_con, DW_IC_CON);
|
2009-11-06 13:48:55 +01:00
|
|
|
|
|
|
|
/* Enable the adapter */
|
2011-10-06 20:26:25 +02:00
|
|
|
dw_writel(dev, 1, DW_IC_ENABLE);
|
2009-11-06 13:50:40 +01:00
|
|
|
|
|
|
|
/* Enable interrupts */
|
2011-10-06 20:26:25 +02:00
|
|
|
dw_writel(dev, DW_IC_INTR_DEFAULT_MASK, DW_IC_INTR_MASK);
|
2009-11-06 13:48:55 +01:00
|
|
|
}
|
|
|
|
|
2009-06-22 15:36:29 +02:00
|
|
|
/*
|
2009-11-06 13:50:40 +01:00
|
|
|
* Initiate (and continue) low level master read/write transaction.
|
|
|
|
* This function is only called from i2c_dw_isr, and pumping i2c_msg
|
|
|
|
* messages into the tx buffer. Even if the size of i2c_msg data is
|
|
|
|
* longer than the size of the tx buffer, it handles everything.
|
2009-06-22 15:36:29 +02:00
|
|
|
*/
|
2011-10-29 11:57:23 +02:00
|
|
|
void
|
2009-11-06 13:46:04 +01:00
|
|
|
i2c_dw_xfer_msg(struct dw_i2c_dev *dev)
|
2009-06-22 15:36:29 +02:00
|
|
|
{
|
|
|
|
struct i2c_msg *msgs = dev->msgs;
|
2009-11-06 13:48:55 +01:00
|
|
|
u32 intr_mask;
|
2009-11-06 13:49:39 +01:00
|
|
|
int tx_limit, rx_limit;
|
2009-11-06 13:43:52 +01:00
|
|
|
u32 addr = msgs[dev->msg_write_idx].addr;
|
|
|
|
u32 buf_len = dev->tx_buf_len;
|
2011-07-27 08:06:29 +02:00
|
|
|
u8 *buf = dev->tx_buf;
|
2009-06-22 15:36:29 +02:00
|
|
|
|
2009-11-06 13:50:40 +01:00
|
|
|
intr_mask = DW_IC_INTR_DEFAULT_MASK;
|
2009-11-06 13:47:30 +01:00
|
|
|
|
2009-11-06 13:46:29 +01:00
|
|
|
for (; dev->msg_write_idx < dev->msgs_num; dev->msg_write_idx++) {
|
2009-11-06 13:52:22 +01:00
|
|
|
/*
|
|
|
|
* if target address has changed, we need to
|
2009-06-22 15:36:29 +02:00
|
|
|
* reprogram the target address in the i2c
|
|
|
|
* adapter when we are done with this transfer
|
|
|
|
*/
|
2009-11-06 13:51:18 +01:00
|
|
|
if (msgs[dev->msg_write_idx].addr != addr) {
|
|
|
|
dev_err(dev->dev,
|
|
|
|
"%s: invalid target address\n", __func__);
|
|
|
|
dev->msg_err = -EINVAL;
|
|
|
|
break;
|
|
|
|
}
|
2009-06-22 15:36:29 +02:00
|
|
|
|
|
|
|
if (msgs[dev->msg_write_idx].len == 0) {
|
|
|
|
dev_err(dev->dev,
|
|
|
|
"%s: invalid message length\n", __func__);
|
|
|
|
dev->msg_err = -EINVAL;
|
2009-11-06 13:51:18 +01:00
|
|
|
break;
|
2009-06-22 15:36:29 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
if (!(dev->status & STATUS_WRITE_IN_PROGRESS)) {
|
|
|
|
/* new i2c_msg */
|
2009-11-06 13:49:14 +01:00
|
|
|
buf = msgs[dev->msg_write_idx].buf;
|
2009-06-22 15:36:29 +02:00
|
|
|
buf_len = msgs[dev->msg_write_idx].len;
|
|
|
|
}
|
|
|
|
|
2011-10-06 20:26:25 +02:00
|
|
|
tx_limit = dev->tx_fifo_depth - dw_readl(dev, DW_IC_TXFLR);
|
|
|
|
rx_limit = dev->rx_fifo_depth - dw_readl(dev, DW_IC_RXFLR);
|
2009-11-06 13:49:39 +01:00
|
|
|
|
2009-06-22 15:36:29 +02:00
|
|
|
while (buf_len > 0 && tx_limit > 0 && rx_limit > 0) {
|
|
|
|
if (msgs[dev->msg_write_idx].flags & I2C_M_RD) {
|
2011-10-06 20:26:25 +02:00
|
|
|
dw_writel(dev, 0x100, DW_IC_DATA_CMD);
|
2009-06-22 15:36:29 +02:00
|
|
|
rx_limit--;
|
|
|
|
} else
|
2011-10-06 20:26:25 +02:00
|
|
|
dw_writel(dev, *buf++, DW_IC_DATA_CMD);
|
2009-06-22 15:36:29 +02:00
|
|
|
tx_limit--; buf_len--;
|
|
|
|
}
|
2009-11-06 13:47:30 +01:00
|
|
|
|
2009-11-06 13:49:14 +01:00
|
|
|
dev->tx_buf = buf;
|
2009-11-06 13:47:30 +01:00
|
|
|
dev->tx_buf_len = buf_len;
|
|
|
|
|
|
|
|
if (buf_len > 0) {
|
|
|
|
/* more bytes to be written */
|
|
|
|
dev->status |= STATUS_WRITE_IN_PROGRESS;
|
|
|
|
break;
|
2009-11-06 13:51:00 +01:00
|
|
|
} else
|
2009-11-06 13:47:30 +01:00
|
|
|
dev->status &= ~STATUS_WRITE_IN_PROGRESS;
|
2009-06-22 15:36:29 +02:00
|
|
|
}
|
|
|
|
|
2009-11-06 13:51:00 +01:00
|
|
|
/*
|
|
|
|
* If i2c_msg index search is completed, we don't need TX_EMPTY
|
|
|
|
* interrupt any more.
|
|
|
|
*/
|
|
|
|
if (dev->msg_write_idx == dev->msgs_num)
|
|
|
|
intr_mask &= ~DW_IC_INTR_TX_EMPTY;
|
|
|
|
|
2009-11-06 13:51:18 +01:00
|
|
|
if (dev->msg_err)
|
|
|
|
intr_mask = 0;
|
|
|
|
|
2011-10-29 11:57:23 +02:00
|
|
|
dw_writel(dev, intr_mask, DW_IC_INTR_MASK);
|
2009-06-22 15:36:29 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
2009-11-06 13:45:39 +01:00
|
|
|
i2c_dw_read(struct dw_i2c_dev *dev)
|
2009-06-22 15:36:29 +02:00
|
|
|
{
|
|
|
|
struct i2c_msg *msgs = dev->msgs;
|
2009-11-06 13:49:39 +01:00
|
|
|
int rx_valid;
|
2009-06-22 15:36:29 +02:00
|
|
|
|
2009-11-06 13:46:29 +01:00
|
|
|
for (; dev->msg_read_idx < dev->msgs_num; dev->msg_read_idx++) {
|
2009-11-06 13:43:52 +01:00
|
|
|
u32 len;
|
2009-06-22 15:36:29 +02:00
|
|
|
u8 *buf;
|
|
|
|
|
|
|
|
if (!(msgs[dev->msg_read_idx].flags & I2C_M_RD))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (!(dev->status & STATUS_READ_IN_PROGRESS)) {
|
|
|
|
len = msgs[dev->msg_read_idx].len;
|
|
|
|
buf = msgs[dev->msg_read_idx].buf;
|
|
|
|
} else {
|
|
|
|
len = dev->rx_buf_len;
|
|
|
|
buf = dev->rx_buf;
|
|
|
|
}
|
|
|
|
|
2011-10-06 20:26:25 +02:00
|
|
|
rx_valid = dw_readl(dev, DW_IC_RXFLR);
|
2009-11-06 13:49:39 +01:00
|
|
|
|
2009-06-22 15:36:29 +02:00
|
|
|
for (; len > 0 && rx_valid > 0; len--, rx_valid--)
|
2011-10-06 20:26:25 +02:00
|
|
|
*buf++ = dw_readl(dev, DW_IC_DATA_CMD);
|
2009-06-22 15:36:29 +02:00
|
|
|
|
|
|
|
if (len > 0) {
|
|
|
|
dev->status |= STATUS_READ_IN_PROGRESS;
|
|
|
|
dev->rx_buf_len = len;
|
|
|
|
dev->rx_buf = buf;
|
|
|
|
return;
|
|
|
|
} else
|
|
|
|
dev->status &= ~STATUS_READ_IN_PROGRESS;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-11-06 13:51:57 +01:00
|
|
|
static int i2c_dw_handle_tx_abort(struct dw_i2c_dev *dev)
|
|
|
|
{
|
|
|
|
unsigned long abort_source = dev->abort_source;
|
|
|
|
int i;
|
|
|
|
|
2009-11-16 12:40:14 +01:00
|
|
|
if (abort_source & DW_IC_TX_ABRT_NOACK) {
|
2010-03-05 22:41:37 +01:00
|
|
|
for_each_set_bit(i, &abort_source, ARRAY_SIZE(abort_sources))
|
2009-11-16 12:40:14 +01:00
|
|
|
dev_dbg(dev->dev,
|
|
|
|
"%s: %s\n", __func__, abort_sources[i]);
|
|
|
|
return -EREMOTEIO;
|
|
|
|
}
|
|
|
|
|
2010-03-05 22:41:37 +01:00
|
|
|
for_each_set_bit(i, &abort_source, ARRAY_SIZE(abort_sources))
|
2009-11-06 13:51:57 +01:00
|
|
|
dev_err(dev->dev, "%s: %s\n", __func__, abort_sources[i]);
|
|
|
|
|
|
|
|
if (abort_source & DW_IC_TX_ARB_LOST)
|
|
|
|
return -EAGAIN;
|
|
|
|
else if (abort_source & DW_IC_TX_ABRT_GCALL_READ)
|
|
|
|
return -EINVAL; /* wrong msgs[] data */
|
|
|
|
else
|
|
|
|
return -EIO;
|
|
|
|
}
|
|
|
|
|
2009-06-22 15:36:29 +02:00
|
|
|
/*
|
|
|
|
* Prepare controller for a transaction and call i2c_dw_xfer_msg
|
|
|
|
*/
|
2011-10-29 11:57:23 +02:00
|
|
|
int
|
2009-06-22 15:36:29 +02:00
|
|
|
i2c_dw_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
|
|
|
|
{
|
|
|
|
struct dw_i2c_dev *dev = i2c_get_adapdata(adap);
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
dev_dbg(dev->dev, "%s: msgs: %d\n", __func__, num);
|
|
|
|
|
|
|
|
mutex_lock(&dev->lock);
|
|
|
|
|
|
|
|
INIT_COMPLETION(dev->cmd_complete);
|
|
|
|
dev->msgs = msgs;
|
|
|
|
dev->msgs_num = num;
|
|
|
|
dev->cmd_err = 0;
|
|
|
|
dev->msg_write_idx = 0;
|
|
|
|
dev->msg_read_idx = 0;
|
|
|
|
dev->msg_err = 0;
|
|
|
|
dev->status = STATUS_IDLE;
|
2009-11-06 13:51:57 +01:00
|
|
|
dev->abort_source = 0;
|
2009-06-22 15:36:29 +02:00
|
|
|
|
|
|
|
ret = i2c_dw_wait_bus_not_busy(dev);
|
|
|
|
if (ret < 0)
|
|
|
|
goto done;
|
|
|
|
|
|
|
|
/* start the transfers */
|
2009-11-06 13:48:55 +01:00
|
|
|
i2c_dw_xfer_init(dev);
|
2009-06-22 15:36:29 +02:00
|
|
|
|
|
|
|
/* wait for tx to complete */
|
|
|
|
ret = wait_for_completion_interruptible_timeout(&dev->cmd_complete, HZ);
|
|
|
|
if (ret == 0) {
|
|
|
|
dev_err(dev->dev, "controller timed out\n");
|
|
|
|
i2c_dw_init(dev);
|
|
|
|
ret = -ETIMEDOUT;
|
|
|
|
goto done;
|
|
|
|
} else if (ret < 0)
|
|
|
|
goto done;
|
|
|
|
|
|
|
|
if (dev->msg_err) {
|
|
|
|
ret = dev->msg_err;
|
|
|
|
goto done;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* no error */
|
|
|
|
if (likely(!dev->cmd_err)) {
|
i2c-designware: Process i2c_msg messages in the interrupt handler
Symptom:
--------
When we're going to send/receive the longer size of data than the Tx
FIFO length, the I2C transaction will be divided into several separated
transactions, limited by the Tx FIFO length.
Details:
--------
As a hardware feature, DW I2C core generates a STOP condition whenever
the Tx FIFO becomes empty (strictly speaking, whenever the last byte in
the Tx FIFO is sent out), even if we have more bytes to be written.
Then, once a new transmit data is written to the Tx FIFO, DW I2C core
will initiate a new transaction, which leads to another START condition.
This explains how the transaction in question goes, and implies that
current tasklet-based dw_i2c_pump_msg() strategy couldn't meet the
timing constraint required for avoiding Tx FIFO underrun.
To avoid this scenario, we must keep providing new transmit data within
a given time period. In case of Fast-mode + 32-byte Tx FIFO, for
instance, it takes about 22.5[us] to process single byte, and 720[us] in
total.
This patch removes the existing tasklet-based "pump" system, and move
its jobs into the interrupt handler.
Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
2009-11-06 13:47:51 +01:00
|
|
|
/* Disable the adapter */
|
2011-10-06 20:26:25 +02:00
|
|
|
dw_writel(dev, 0, DW_IC_ENABLE);
|
2009-06-22 15:36:29 +02:00
|
|
|
ret = num;
|
|
|
|
goto done;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* We have an error */
|
|
|
|
if (dev->cmd_err == DW_IC_ERR_TX_ABRT) {
|
2009-11-06 13:51:57 +01:00
|
|
|
ret = i2c_dw_handle_tx_abort(dev);
|
|
|
|
goto done;
|
2009-06-22 15:36:29 +02:00
|
|
|
}
|
|
|
|
ret = -EIO;
|
|
|
|
|
|
|
|
done:
|
|
|
|
mutex_unlock(&dev->lock);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2011-10-29 11:57:23 +02:00
|
|
|
u32 i2c_dw_func(struct i2c_adapter *adap)
|
2009-06-22 15:36:29 +02:00
|
|
|
{
|
2011-10-06 20:26:31 +02:00
|
|
|
struct dw_i2c_dev *dev = i2c_get_adapdata(adap);
|
|
|
|
return dev->functionality;
|
2009-06-22 15:36:29 +02:00
|
|
|
}
|
|
|
|
|
2009-11-06 13:44:37 +01:00
|
|
|
static u32 i2c_dw_read_clear_intrbits(struct dw_i2c_dev *dev)
|
|
|
|
{
|
|
|
|
u32 stat;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The IC_INTR_STAT register just indicates "enabled" interrupts.
|
|
|
|
* Ths unmasked raw version of interrupt status bits are available
|
|
|
|
* in the IC_RAW_INTR_STAT register.
|
|
|
|
*
|
|
|
|
* That is,
|
2011-10-29 11:57:23 +02:00
|
|
|
* stat = dw_readl(IC_INTR_STAT);
|
2009-11-06 13:44:37 +01:00
|
|
|
* equals to,
|
2011-10-29 11:57:23 +02:00
|
|
|
* stat = dw_readl(IC_RAW_INTR_STAT) & dw_readl(IC_INTR_MASK);
|
2009-11-06 13:44:37 +01:00
|
|
|
*
|
|
|
|
* The raw version might be useful for debugging purposes.
|
|
|
|
*/
|
2011-10-06 20:26:25 +02:00
|
|
|
stat = dw_readl(dev, DW_IC_INTR_STAT);
|
2009-11-06 13:44:37 +01:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Do not use the IC_CLR_INTR register to clear interrupts, or
|
|
|
|
* you'll miss some interrupts, triggered during the period from
|
2011-10-29 11:57:23 +02:00
|
|
|
* dw_readl(IC_INTR_STAT) to dw_readl(IC_CLR_INTR).
|
2009-11-06 13:44:37 +01:00
|
|
|
*
|
|
|
|
* Instead, use the separately-prepared IC_CLR_* registers.
|
|
|
|
*/
|
|
|
|
if (stat & DW_IC_INTR_RX_UNDER)
|
2011-10-06 20:26:25 +02:00
|
|
|
dw_readl(dev, DW_IC_CLR_RX_UNDER);
|
2009-11-06 13:44:37 +01:00
|
|
|
if (stat & DW_IC_INTR_RX_OVER)
|
2011-10-06 20:26:25 +02:00
|
|
|
dw_readl(dev, DW_IC_CLR_RX_OVER);
|
2009-11-06 13:44:37 +01:00
|
|
|
if (stat & DW_IC_INTR_TX_OVER)
|
2011-10-06 20:26:25 +02:00
|
|
|
dw_readl(dev, DW_IC_CLR_TX_OVER);
|
2009-11-06 13:44:37 +01:00
|
|
|
if (stat & DW_IC_INTR_RD_REQ)
|
2011-10-06 20:26:25 +02:00
|
|
|
dw_readl(dev, DW_IC_CLR_RD_REQ);
|
2009-11-06 13:44:37 +01:00
|
|
|
if (stat & DW_IC_INTR_TX_ABRT) {
|
|
|
|
/*
|
|
|
|
* The IC_TX_ABRT_SOURCE register is cleared whenever
|
|
|
|
* the IC_CLR_TX_ABRT is read. Preserve it beforehand.
|
|
|
|
*/
|
2011-10-06 20:26:25 +02:00
|
|
|
dev->abort_source = dw_readl(dev, DW_IC_TX_ABRT_SOURCE);
|
|
|
|
dw_readl(dev, DW_IC_CLR_TX_ABRT);
|
2009-11-06 13:44:37 +01:00
|
|
|
}
|
|
|
|
if (stat & DW_IC_INTR_RX_DONE)
|
2011-10-06 20:26:25 +02:00
|
|
|
dw_readl(dev, DW_IC_CLR_RX_DONE);
|
2009-11-06 13:44:37 +01:00
|
|
|
if (stat & DW_IC_INTR_ACTIVITY)
|
2011-10-06 20:26:25 +02:00
|
|
|
dw_readl(dev, DW_IC_CLR_ACTIVITY);
|
2009-11-06 13:44:37 +01:00
|
|
|
if (stat & DW_IC_INTR_STOP_DET)
|
2011-10-06 20:26:25 +02:00
|
|
|
dw_readl(dev, DW_IC_CLR_STOP_DET);
|
2009-11-06 13:44:37 +01:00
|
|
|
if (stat & DW_IC_INTR_START_DET)
|
2011-10-06 20:26:25 +02:00
|
|
|
dw_readl(dev, DW_IC_CLR_START_DET);
|
2009-11-06 13:44:37 +01:00
|
|
|
if (stat & DW_IC_INTR_GEN_CALL)
|
2011-10-06 20:26:25 +02:00
|
|
|
dw_readl(dev, DW_IC_CLR_GEN_CALL);
|
2009-11-06 13:44:37 +01:00
|
|
|
|
|
|
|
return stat;
|
|
|
|
}
|
|
|
|
|
2009-06-22 15:36:29 +02:00
|
|
|
/*
|
|
|
|
* Interrupt service routine. This gets called whenever an I2C interrupt
|
|
|
|
* occurs.
|
|
|
|
*/
|
2011-10-29 11:57:23 +02:00
|
|
|
irqreturn_t i2c_dw_isr(int this_irq, void *dev_id)
|
2009-06-22 15:36:29 +02:00
|
|
|
{
|
|
|
|
struct dw_i2c_dev *dev = dev_id;
|
2009-11-06 13:43:52 +01:00
|
|
|
u32 stat;
|
2009-06-22 15:36:29 +02:00
|
|
|
|
2009-11-06 13:44:37 +01:00
|
|
|
stat = i2c_dw_read_clear_intrbits(dev);
|
2009-06-22 15:36:29 +02:00
|
|
|
dev_dbg(dev->dev, "%s: stat=0x%x\n", __func__, stat);
|
2009-11-06 13:44:37 +01:00
|
|
|
|
2009-06-22 15:36:29 +02:00
|
|
|
if (stat & DW_IC_INTR_TX_ABRT) {
|
|
|
|
dev->cmd_err |= DW_IC_ERR_TX_ABRT;
|
|
|
|
dev->status = STATUS_IDLE;
|
2009-11-06 13:51:36 +01:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Anytime TX_ABRT is set, the contents of the tx/rx
|
|
|
|
* buffers are flushed. Make sure to skip them.
|
|
|
|
*/
|
2011-10-06 20:26:25 +02:00
|
|
|
dw_writel(dev, 0, DW_IC_INTR_MASK);
|
2009-11-06 13:51:36 +01:00
|
|
|
goto tx_aborted;
|
i2c-designware: Process i2c_msg messages in the interrupt handler
Symptom:
--------
When we're going to send/receive the longer size of data than the Tx
FIFO length, the I2C transaction will be divided into several separated
transactions, limited by the Tx FIFO length.
Details:
--------
As a hardware feature, DW I2C core generates a STOP condition whenever
the Tx FIFO becomes empty (strictly speaking, whenever the last byte in
the Tx FIFO is sent out), even if we have more bytes to be written.
Then, once a new transmit data is written to the Tx FIFO, DW I2C core
will initiate a new transaction, which leads to another START condition.
This explains how the transaction in question goes, and implies that
current tasklet-based dw_i2c_pump_msg() strategy couldn't meet the
timing constraint required for avoiding Tx FIFO underrun.
To avoid this scenario, we must keep providing new transmit data within
a given time period. In case of Fast-mode + 32-byte Tx FIFO, for
instance, it takes about 22.5[us] to process single byte, and 720[us] in
total.
This patch removes the existing tasklet-based "pump" system, and move
its jobs into the interrupt handler.
Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
2009-11-06 13:47:51 +01:00
|
|
|
}
|
|
|
|
|
2009-11-06 13:48:33 +01:00
|
|
|
if (stat & DW_IC_INTR_RX_FULL)
|
i2c-designware: Process i2c_msg messages in the interrupt handler
Symptom:
--------
When we're going to send/receive the longer size of data than the Tx
FIFO length, the I2C transaction will be divided into several separated
transactions, limited by the Tx FIFO length.
Details:
--------
As a hardware feature, DW I2C core generates a STOP condition whenever
the Tx FIFO becomes empty (strictly speaking, whenever the last byte in
the Tx FIFO is sent out), even if we have more bytes to be written.
Then, once a new transmit data is written to the Tx FIFO, DW I2C core
will initiate a new transaction, which leads to another START condition.
This explains how the transaction in question goes, and implies that
current tasklet-based dw_i2c_pump_msg() strategy couldn't meet the
timing constraint required for avoiding Tx FIFO underrun.
To avoid this scenario, we must keep providing new transmit data within
a given time period. In case of Fast-mode + 32-byte Tx FIFO, for
instance, it takes about 22.5[us] to process single byte, and 720[us] in
total.
This patch removes the existing tasklet-based "pump" system, and move
its jobs into the interrupt handler.
Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
2009-11-06 13:47:51 +01:00
|
|
|
i2c_dw_read(dev);
|
2009-11-06 13:48:33 +01:00
|
|
|
|
|
|
|
if (stat & DW_IC_INTR_TX_EMPTY)
|
i2c-designware: Process i2c_msg messages in the interrupt handler
Symptom:
--------
When we're going to send/receive the longer size of data than the Tx
FIFO length, the I2C transaction will be divided into several separated
transactions, limited by the Tx FIFO length.
Details:
--------
As a hardware feature, DW I2C core generates a STOP condition whenever
the Tx FIFO becomes empty (strictly speaking, whenever the last byte in
the Tx FIFO is sent out), even if we have more bytes to be written.
Then, once a new transmit data is written to the Tx FIFO, DW I2C core
will initiate a new transaction, which leads to another START condition.
This explains how the transaction in question goes, and implies that
current tasklet-based dw_i2c_pump_msg() strategy couldn't meet the
timing constraint required for avoiding Tx FIFO underrun.
To avoid this scenario, we must keep providing new transmit data within
a given time period. In case of Fast-mode + 32-byte Tx FIFO, for
instance, it takes about 22.5[us] to process single byte, and 720[us] in
total.
This patch removes the existing tasklet-based "pump" system, and move
its jobs into the interrupt handler.
Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
2009-11-06 13:47:51 +01:00
|
|
|
i2c_dw_xfer_msg(dev);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* No need to modify or disable the interrupt mask here.
|
|
|
|
* i2c_dw_xfer_msg() will take care of it according to
|
|
|
|
* the current transmit status.
|
|
|
|
*/
|
2009-06-22 15:36:29 +02:00
|
|
|
|
2009-11-06 13:51:36 +01:00
|
|
|
tx_aborted:
|
2009-11-06 13:51:18 +01:00
|
|
|
if ((stat & (DW_IC_INTR_TX_ABRT | DW_IC_INTR_STOP_DET)) || dev->msg_err)
|
2009-06-22 15:36:29 +02:00
|
|
|
complete(&dev->cmd_complete);
|
|
|
|
|
|
|
|
return IRQ_HANDLED;
|
|
|
|
}
|