License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 15:07:57 +01:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
2013-02-28 02:03:01 +01:00
|
|
|
/*
|
|
|
|
* linux/fs/hfsplus/attributes.c
|
|
|
|
*
|
|
|
|
* Vyacheslav Dubeyko <slava@dubeyko.com>
|
|
|
|
*
|
|
|
|
* Handling of records in attributes tree
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "hfsplus_fs.h"
|
|
|
|
#include "hfsplus_raw.h"
|
|
|
|
|
|
|
|
static struct kmem_cache *hfsplus_attr_tree_cachep;
|
|
|
|
|
2014-04-03 23:50:35 +02:00
|
|
|
int __init hfsplus_create_attr_tree_cache(void)
|
2013-02-28 02:03:01 +01:00
|
|
|
{
|
|
|
|
if (hfsplus_attr_tree_cachep)
|
|
|
|
return -EEXIST;
|
|
|
|
|
|
|
|
hfsplus_attr_tree_cachep =
|
|
|
|
kmem_cache_create("hfsplus_attr_cache",
|
|
|
|
sizeof(hfsplus_attr_entry), 0,
|
|
|
|
SLAB_HWCACHE_ALIGN, NULL);
|
|
|
|
if (!hfsplus_attr_tree_cachep)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
void hfsplus_destroy_attr_tree_cache(void)
|
|
|
|
{
|
|
|
|
kmem_cache_destroy(hfsplus_attr_tree_cachep);
|
|
|
|
}
|
|
|
|
|
|
|
|
int hfsplus_attr_bin_cmp_key(const hfsplus_btree_key *k1,
|
|
|
|
const hfsplus_btree_key *k2)
|
|
|
|
{
|
|
|
|
__be32 k1_cnid, k2_cnid;
|
|
|
|
|
|
|
|
k1_cnid = k1->attr.cnid;
|
|
|
|
k2_cnid = k2->attr.cnid;
|
|
|
|
if (k1_cnid != k2_cnid)
|
|
|
|
return be32_to_cpu(k1_cnid) < be32_to_cpu(k2_cnid) ? -1 : 1;
|
|
|
|
|
|
|
|
return hfsplus_strcmp(
|
|
|
|
(const struct hfsplus_unistr *)&k1->attr.key_name,
|
|
|
|
(const struct hfsplus_unistr *)&k2->attr.key_name);
|
|
|
|
}
|
|
|
|
|
|
|
|
int hfsplus_attr_build_key(struct super_block *sb, hfsplus_btree_key *key,
|
|
|
|
u32 cnid, const char *name)
|
|
|
|
{
|
|
|
|
int len;
|
|
|
|
|
|
|
|
memset(key, 0, sizeof(struct hfsplus_attr_key));
|
|
|
|
key->attr.cnid = cpu_to_be32(cnid);
|
|
|
|
if (name) {
|
hfsplus: correct usage of HFSPLUS_ATTR_MAX_STRLEN for non-English attributes
HFSPLUS_ATTR_MAX_STRLEN (=127) is the limit of attribute names for the
number of unicode character (UTF-16BE) storable in the HFS+ file system.
Almost all the current usage of it is wrong, in relation to NLS to
on-disk conversion.
Except for one use calling hfsplus_asc2uni (which should stay the same)
and its uses in calling hfsplus_uni2asc (which was corrected in the
earlier patch in this series concerning usage of hfsplus_uni2asc), all
the other uses are of the forms:
- char buffer[size]
- bound check: "if (namespace_adjusted_input_length > size) return failure;"
Conversion between on-disk unicode representation and NLS char strings
(in whichever direction) always needs to accommodate the worst-case NLS
conversion, so all char buffers of that size need to have a
NLS_MAX_CHARSET_SIZE x .
The bound checks are all wrong, since they compare nls_length derived
from strlen() to a unicode length limit.
It turns out that all the bound-checks do is to protect
hfsplus_asc2uni(), which can fail if the input is too large.
There is only one usage of it as far as attributes are concerned, in
hfsplus_attr_build_key(). It is in turn used by hfsplus_find_attr(),
hfsplus_create_attr(), hfsplus_delete_attr(). Thus making sure that
errors from hfsplus_asc2uni() is caught in hfsplus_attr_build_key() and
propagated is sufficient to replace all the bound checks.
Unpropagated errors from hfsplus_asc2uni() in the file catalog code was
addressed recently in an independent patch "hfsplus: fix longname
handling" by Sougata Santra.
Before this patch, trying to set a 55 CJK character (in a UTF-8 locale,
> 127/3=42) attribute plus user prefix fails with:
$ setfattr -n user.`cat testing-string` -v `cat testing-string` \
testing-string
setfattr: testing-string: Operation not supported
and retrieving a stored long attributes is particular ugly(!):
find /mnt/* -type f -exec getfattr -d {} \;
getfattr: /mnt/testing-string: Input/output error
with console log:
[268008.389781] hfsplus: unicode conversion failed
After the patch, both of the above works.
FYI, the test attribute string is prepared with:
echo -e -n \
"\xe9\x80\x99\xe6\x98\xaf\xe4\xb8\x80\xe5\x80\x8b\xe9\x9d\x9e\xe5" \
"\xb8\xb8\xe6\xbc\xab\xe9\x95\xb7\xe8\x80\x8c\xe6\xa5\xb5\xe5\x85" \
"\xb6\xe4\xb9\x8f\xe5\x91\xb3\xe5\x92\x8c\xe7\x9b\xb8\xe7\x95\xb6" \
"\xe7\x84\xa1\xe8\xb6\xa3\xe3\x80\x81\xe4\xbb\xa5\xe5\x8f\x8a\xe7" \
"\x84\xa1\xe7\x94\xa8\xe7\x9a\x84\xe3\x80\x81\xe5\x86\x8d\xe5\x8a" \
"\xa0\xe4\xb8\x8a\xe6\xaf\xab\xe7\x84\xa1\xe6\x84\x8f\xe7\xbe\xa9" \
"\xe7\x9a\x84\xe6\x93\xb4\xe5\xb1\x95\xe5\xb1\xac\xe6\x80\xa7\xef" \
"\xbc\x8c\xe8\x80\x8c\xe5\x85\xb6\xe5\x94\xaf\xe4\xb8\x80\xe5\x89" \
"\xb5\xe5\xbb\xba\xe7\x9b\xae\xe7\x9a\x84\xe5\x83\x85\xe6\x98\xaf" \
"\xe7\x82\xba\xe4\xba\x86\xe6\xb8\xac\xe8\xa9\xa6\xe4\xbd\x9c\xe7" \
"\x94\xa8\xe3\x80\x82" | tr -d ' '
(= "pointlessly long attribute for testing", elaborate Chinese in
UTF-8 enoding).
However, it is not possible to set double the size (110 + 5 is still
under 127) in a UTF-8 locale:
$setfattr -n user.`cat testing-string testing-string` -v \
`cat testing-string testing-string` testing-string
setfattr: testing-string: Numerical result out of range
110 CJK char in UTF-8 is 330 bytes - the generic get/set attribute
system call code in linux/fs/xattr.c imposes a 255 byte limit. One can
use a combination of iconv to encode content, changing terminal locale
for viewing, and an nls=cp932/cp936/cp949/cp950 mount option to fully
use 127-unicode attribute in a double-byte locale.
Also, as an additional information, it is possible to (mis-)use unicode
half-width/full-width forms (U+FFxx) to write attributes which looks
like english but not actually ascii.
Thanks Anton Altaparmakov for reviewing the earlier ideas behind this
change.
[akpm@linux-foundation.org: fix build]
[akpm@linux-foundation.org: fix build]
Signed-off-by: Hin-Tak Leung <htl10@users.sourceforge.net>
Cc: Anton Altaparmakov <anton@tuxera.com>
Cc: Vyacheslav Dubeyko <slava@dubeyko.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Sougata Santra <sougata@tuxera.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-06-06 23:36:22 +02:00
|
|
|
int res = hfsplus_asc2uni(sb,
|
2013-02-28 02:03:01 +01:00
|
|
|
(struct hfsplus_unistr *)&key->attr.key_name,
|
hfsplus: correct usage of HFSPLUS_ATTR_MAX_STRLEN for non-English attributes
HFSPLUS_ATTR_MAX_STRLEN (=127) is the limit of attribute names for the
number of unicode character (UTF-16BE) storable in the HFS+ file system.
Almost all the current usage of it is wrong, in relation to NLS to
on-disk conversion.
Except for one use calling hfsplus_asc2uni (which should stay the same)
and its uses in calling hfsplus_uni2asc (which was corrected in the
earlier patch in this series concerning usage of hfsplus_uni2asc), all
the other uses are of the forms:
- char buffer[size]
- bound check: "if (namespace_adjusted_input_length > size) return failure;"
Conversion between on-disk unicode representation and NLS char strings
(in whichever direction) always needs to accommodate the worst-case NLS
conversion, so all char buffers of that size need to have a
NLS_MAX_CHARSET_SIZE x .
The bound checks are all wrong, since they compare nls_length derived
from strlen() to a unicode length limit.
It turns out that all the bound-checks do is to protect
hfsplus_asc2uni(), which can fail if the input is too large.
There is only one usage of it as far as attributes are concerned, in
hfsplus_attr_build_key(). It is in turn used by hfsplus_find_attr(),
hfsplus_create_attr(), hfsplus_delete_attr(). Thus making sure that
errors from hfsplus_asc2uni() is caught in hfsplus_attr_build_key() and
propagated is sufficient to replace all the bound checks.
Unpropagated errors from hfsplus_asc2uni() in the file catalog code was
addressed recently in an independent patch "hfsplus: fix longname
handling" by Sougata Santra.
Before this patch, trying to set a 55 CJK character (in a UTF-8 locale,
> 127/3=42) attribute plus user prefix fails with:
$ setfattr -n user.`cat testing-string` -v `cat testing-string` \
testing-string
setfattr: testing-string: Operation not supported
and retrieving a stored long attributes is particular ugly(!):
find /mnt/* -type f -exec getfattr -d {} \;
getfattr: /mnt/testing-string: Input/output error
with console log:
[268008.389781] hfsplus: unicode conversion failed
After the patch, both of the above works.
FYI, the test attribute string is prepared with:
echo -e -n \
"\xe9\x80\x99\xe6\x98\xaf\xe4\xb8\x80\xe5\x80\x8b\xe9\x9d\x9e\xe5" \
"\xb8\xb8\xe6\xbc\xab\xe9\x95\xb7\xe8\x80\x8c\xe6\xa5\xb5\xe5\x85" \
"\xb6\xe4\xb9\x8f\xe5\x91\xb3\xe5\x92\x8c\xe7\x9b\xb8\xe7\x95\xb6" \
"\xe7\x84\xa1\xe8\xb6\xa3\xe3\x80\x81\xe4\xbb\xa5\xe5\x8f\x8a\xe7" \
"\x84\xa1\xe7\x94\xa8\xe7\x9a\x84\xe3\x80\x81\xe5\x86\x8d\xe5\x8a" \
"\xa0\xe4\xb8\x8a\xe6\xaf\xab\xe7\x84\xa1\xe6\x84\x8f\xe7\xbe\xa9" \
"\xe7\x9a\x84\xe6\x93\xb4\xe5\xb1\x95\xe5\xb1\xac\xe6\x80\xa7\xef" \
"\xbc\x8c\xe8\x80\x8c\xe5\x85\xb6\xe5\x94\xaf\xe4\xb8\x80\xe5\x89" \
"\xb5\xe5\xbb\xba\xe7\x9b\xae\xe7\x9a\x84\xe5\x83\x85\xe6\x98\xaf" \
"\xe7\x82\xba\xe4\xba\x86\xe6\xb8\xac\xe8\xa9\xa6\xe4\xbd\x9c\xe7" \
"\x94\xa8\xe3\x80\x82" | tr -d ' '
(= "pointlessly long attribute for testing", elaborate Chinese in
UTF-8 enoding).
However, it is not possible to set double the size (110 + 5 is still
under 127) in a UTF-8 locale:
$setfattr -n user.`cat testing-string testing-string` -v \
`cat testing-string testing-string` testing-string
setfattr: testing-string: Numerical result out of range
110 CJK char in UTF-8 is 330 bytes - the generic get/set attribute
system call code in linux/fs/xattr.c imposes a 255 byte limit. One can
use a combination of iconv to encode content, changing terminal locale
for viewing, and an nls=cp932/cp936/cp949/cp950 mount option to fully
use 127-unicode attribute in a double-byte locale.
Also, as an additional information, it is possible to (mis-)use unicode
half-width/full-width forms (U+FFxx) to write attributes which looks
like english but not actually ascii.
Thanks Anton Altaparmakov for reviewing the earlier ideas behind this
change.
[akpm@linux-foundation.org: fix build]
[akpm@linux-foundation.org: fix build]
Signed-off-by: Hin-Tak Leung <htl10@users.sourceforge.net>
Cc: Anton Altaparmakov <anton@tuxera.com>
Cc: Vyacheslav Dubeyko <slava@dubeyko.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Sougata Santra <sougata@tuxera.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-06-06 23:36:22 +02:00
|
|
|
HFSPLUS_ATTR_MAX_STRLEN, name, strlen(name));
|
|
|
|
if (res)
|
|
|
|
return res;
|
2013-02-28 02:03:01 +01:00
|
|
|
len = be16_to_cpu(key->attr.key_name.length);
|
|
|
|
} else {
|
|
|
|
key->attr.key_name.length = 0;
|
|
|
|
len = 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* The length of the key, as stored in key_len field, does not include
|
|
|
|
* the size of the key_len field itself.
|
|
|
|
* So, offsetof(hfsplus_attr_key, key_name) is a trick because
|
|
|
|
* it takes into consideration key_len field (__be16) of
|
|
|
|
* hfsplus_attr_key structure instead of length field (__be16) of
|
|
|
|
* hfsplus_attr_unistr structure.
|
|
|
|
*/
|
|
|
|
key->key_len =
|
|
|
|
cpu_to_be16(offsetof(struct hfsplus_attr_key, key_name) +
|
|
|
|
2 * len);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
hfsplus_attr_entry *hfsplus_alloc_attr_entry(void)
|
|
|
|
{
|
|
|
|
return kmem_cache_alloc(hfsplus_attr_tree_cachep, GFP_KERNEL);
|
|
|
|
}
|
|
|
|
|
|
|
|
void hfsplus_destroy_attr_entry(hfsplus_attr_entry *entry)
|
|
|
|
{
|
|
|
|
if (entry)
|
|
|
|
kmem_cache_free(hfsplus_attr_tree_cachep, entry);
|
|
|
|
}
|
|
|
|
|
|
|
|
#define HFSPLUS_INVALID_ATTR_RECORD -1
|
|
|
|
|
|
|
|
static int hfsplus_attr_build_record(hfsplus_attr_entry *entry, int record_type,
|
|
|
|
u32 cnid, const void *value, size_t size)
|
|
|
|
{
|
|
|
|
if (record_type == HFSPLUS_ATTR_FORK_DATA) {
|
|
|
|
/*
|
|
|
|
* Mac OS X supports only inline data attributes.
|
|
|
|
* Do nothing
|
|
|
|
*/
|
|
|
|
memset(entry, 0, sizeof(*entry));
|
|
|
|
return sizeof(struct hfsplus_attr_fork_data);
|
|
|
|
} else if (record_type == HFSPLUS_ATTR_EXTENTS) {
|
|
|
|
/*
|
|
|
|
* Mac OS X supports only inline data attributes.
|
|
|
|
* Do nothing.
|
|
|
|
*/
|
|
|
|
memset(entry, 0, sizeof(*entry));
|
|
|
|
return sizeof(struct hfsplus_attr_extents);
|
|
|
|
} else if (record_type == HFSPLUS_ATTR_INLINE_DATA) {
|
|
|
|
u16 len;
|
|
|
|
|
|
|
|
memset(entry, 0, sizeof(struct hfsplus_attr_inline_data));
|
|
|
|
entry->inline_data.record_type = cpu_to_be32(record_type);
|
|
|
|
if (size <= HFSPLUS_MAX_INLINE_DATA_SIZE)
|
|
|
|
len = size;
|
|
|
|
else
|
|
|
|
return HFSPLUS_INVALID_ATTR_RECORD;
|
|
|
|
entry->inline_data.length = cpu_to_be16(len);
|
|
|
|
memcpy(entry->inline_data.raw_bytes, value, len);
|
|
|
|
/*
|
|
|
|
* Align len on two-byte boundary.
|
|
|
|
* It needs to add pad byte if we have odd len.
|
|
|
|
*/
|
|
|
|
len = round_up(len, 2);
|
|
|
|
return offsetof(struct hfsplus_attr_inline_data, raw_bytes) +
|
|
|
|
len;
|
|
|
|
} else /* invalid input */
|
|
|
|
memset(entry, 0, sizeof(*entry));
|
|
|
|
|
|
|
|
return HFSPLUS_INVALID_ATTR_RECORD;
|
|
|
|
}
|
|
|
|
|
|
|
|
int hfsplus_find_attr(struct super_block *sb, u32 cnid,
|
|
|
|
const char *name, struct hfs_find_data *fd)
|
|
|
|
{
|
|
|
|
int err = 0;
|
|
|
|
|
2013-05-01 00:27:54 +02:00
|
|
|
hfs_dbg(ATTR_MOD, "find_attr: %s,%d\n", name ? name : NULL, cnid);
|
2013-02-28 02:03:01 +01:00
|
|
|
|
|
|
|
if (!HFSPLUS_SB(sb)->attr_tree) {
|
2013-05-01 00:27:55 +02:00
|
|
|
pr_err("attributes file doesn't exist\n");
|
2013-02-28 02:03:01 +01:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (name) {
|
|
|
|
err = hfsplus_attr_build_key(sb, fd->search_key, cnid, name);
|
|
|
|
if (err)
|
|
|
|
goto failed_find_attr;
|
|
|
|
err = hfs_brec_find(fd, hfs_find_rec_by_key);
|
|
|
|
if (err)
|
|
|
|
goto failed_find_attr;
|
|
|
|
} else {
|
|
|
|
err = hfsplus_attr_build_key(sb, fd->search_key, cnid, NULL);
|
|
|
|
if (err)
|
|
|
|
goto failed_find_attr;
|
|
|
|
err = hfs_brec_find(fd, hfs_find_1st_rec_by_cnid);
|
|
|
|
if (err)
|
|
|
|
goto failed_find_attr;
|
|
|
|
}
|
|
|
|
|
|
|
|
failed_find_attr:
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
int hfsplus_attr_exists(struct inode *inode, const char *name)
|
|
|
|
{
|
|
|
|
int err = 0;
|
|
|
|
struct super_block *sb = inode->i_sb;
|
|
|
|
struct hfs_find_data fd;
|
|
|
|
|
|
|
|
if (!HFSPLUS_SB(sb)->attr_tree)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
err = hfs_find_init(HFSPLUS_SB(sb)->attr_tree, &fd);
|
|
|
|
if (err)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
err = hfsplus_find_attr(sb, inode->i_ino, name, &fd);
|
|
|
|
if (err)
|
|
|
|
goto attr_not_found;
|
|
|
|
|
|
|
|
hfs_find_exit(&fd);
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
attr_not_found:
|
|
|
|
hfs_find_exit(&fd);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
int hfsplus_create_attr(struct inode *inode,
|
|
|
|
const char *name,
|
|
|
|
const void *value, size_t size)
|
|
|
|
{
|
|
|
|
struct super_block *sb = inode->i_sb;
|
|
|
|
struct hfs_find_data fd;
|
|
|
|
hfsplus_attr_entry *entry_ptr;
|
|
|
|
int entry_size;
|
|
|
|
int err;
|
|
|
|
|
2013-05-01 00:27:54 +02:00
|
|
|
hfs_dbg(ATTR_MOD, "create_attr: %s,%ld\n",
|
2013-02-28 02:03:01 +01:00
|
|
|
name ? name : NULL, inode->i_ino);
|
|
|
|
|
|
|
|
if (!HFSPLUS_SB(sb)->attr_tree) {
|
2013-05-01 00:27:55 +02:00
|
|
|
pr_err("attributes file doesn't exist\n");
|
2013-02-28 02:03:01 +01:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
entry_ptr = hfsplus_alloc_attr_entry();
|
|
|
|
if (!entry_ptr)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
err = hfs_find_init(HFSPLUS_SB(sb)->attr_tree, &fd);
|
|
|
|
if (err)
|
|
|
|
goto failed_init_create_attr;
|
|
|
|
|
2018-10-30 23:06:14 +01:00
|
|
|
/* Fail early and avoid ENOSPC during the btree operation */
|
|
|
|
err = hfs_bmap_reserve(fd.tree, fd.tree->depth + 1);
|
|
|
|
if (err)
|
|
|
|
goto failed_create_attr;
|
|
|
|
|
2013-02-28 02:03:01 +01:00
|
|
|
if (name) {
|
|
|
|
err = hfsplus_attr_build_key(sb, fd.search_key,
|
|
|
|
inode->i_ino, name);
|
|
|
|
if (err)
|
|
|
|
goto failed_create_attr;
|
|
|
|
} else {
|
|
|
|
err = -EINVAL;
|
|
|
|
goto failed_create_attr;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Mac OS X supports only inline data attributes. */
|
|
|
|
entry_size = hfsplus_attr_build_record(entry_ptr,
|
|
|
|
HFSPLUS_ATTR_INLINE_DATA,
|
|
|
|
inode->i_ino,
|
|
|
|
value, size);
|
|
|
|
if (entry_size == HFSPLUS_INVALID_ATTR_RECORD) {
|
|
|
|
err = -EINVAL;
|
|
|
|
goto failed_create_attr;
|
|
|
|
}
|
|
|
|
|
|
|
|
err = hfs_brec_find(&fd, hfs_find_rec_by_key);
|
|
|
|
if (err != -ENOENT) {
|
|
|
|
if (!err)
|
|
|
|
err = -EEXIST;
|
|
|
|
goto failed_create_attr;
|
|
|
|
}
|
|
|
|
|
|
|
|
err = hfs_brec_insert(&fd, entry_ptr, entry_size);
|
|
|
|
if (err)
|
|
|
|
goto failed_create_attr;
|
|
|
|
|
|
|
|
hfsplus_mark_inode_dirty(inode, HFSPLUS_I_ATTR_DIRTY);
|
|
|
|
|
|
|
|
failed_create_attr:
|
|
|
|
hfs_find_exit(&fd);
|
|
|
|
|
|
|
|
failed_init_create_attr:
|
|
|
|
hfsplus_destroy_attr_entry(entry_ptr);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int __hfsplus_delete_attr(struct inode *inode, u32 cnid,
|
|
|
|
struct hfs_find_data *fd)
|
|
|
|
{
|
|
|
|
int err = 0;
|
|
|
|
__be32 found_cnid, record_type;
|
|
|
|
|
|
|
|
hfs_bnode_read(fd->bnode, &found_cnid,
|
|
|
|
fd->keyoffset +
|
|
|
|
offsetof(struct hfsplus_attr_key, cnid),
|
|
|
|
sizeof(__be32));
|
|
|
|
if (cnid != be32_to_cpu(found_cnid))
|
|
|
|
return -ENOENT;
|
|
|
|
|
|
|
|
hfs_bnode_read(fd->bnode, &record_type,
|
|
|
|
fd->entryoffset, sizeof(record_type));
|
|
|
|
|
|
|
|
switch (be32_to_cpu(record_type)) {
|
|
|
|
case HFSPLUS_ATTR_INLINE_DATA:
|
|
|
|
/* All is OK. Do nothing. */
|
|
|
|
break;
|
|
|
|
case HFSPLUS_ATTR_FORK_DATA:
|
|
|
|
case HFSPLUS_ATTR_EXTENTS:
|
2013-05-01 00:27:55 +02:00
|
|
|
pr_err("only inline data xattr are supported\n");
|
2013-02-28 02:03:01 +01:00
|
|
|
return -EOPNOTSUPP;
|
|
|
|
default:
|
2013-05-01 00:27:55 +02:00
|
|
|
pr_err("invalid extended attribute record\n");
|
2013-02-28 02:03:01 +01:00
|
|
|
return -ENOENT;
|
|
|
|
}
|
|
|
|
|
2020-04-10 23:32:16 +02:00
|
|
|
/* Avoid btree corruption */
|
|
|
|
hfs_bnode_read(fd->bnode, fd->search_key,
|
|
|
|
fd->keyoffset, fd->keylength);
|
|
|
|
|
2013-02-28 02:03:01 +01:00
|
|
|
err = hfs_brec_remove(fd);
|
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
|
|
|
|
hfsplus_mark_inode_dirty(inode, HFSPLUS_I_ATTR_DIRTY);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
int hfsplus_delete_attr(struct inode *inode, const char *name)
|
|
|
|
{
|
|
|
|
int err = 0;
|
|
|
|
struct super_block *sb = inode->i_sb;
|
|
|
|
struct hfs_find_data fd;
|
|
|
|
|
2013-05-01 00:27:54 +02:00
|
|
|
hfs_dbg(ATTR_MOD, "delete_attr: %s,%ld\n",
|
2013-02-28 02:03:01 +01:00
|
|
|
name ? name : NULL, inode->i_ino);
|
|
|
|
|
|
|
|
if (!HFSPLUS_SB(sb)->attr_tree) {
|
2013-05-01 00:27:55 +02:00
|
|
|
pr_err("attributes file doesn't exist\n");
|
2013-02-28 02:03:01 +01:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
err = hfs_find_init(HFSPLUS_SB(sb)->attr_tree, &fd);
|
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
|
2018-10-30 23:06:14 +01:00
|
|
|
/* Fail early and avoid ENOSPC during the btree operation */
|
|
|
|
err = hfs_bmap_reserve(fd.tree, fd.tree->depth);
|
|
|
|
if (err)
|
|
|
|
goto out;
|
|
|
|
|
2013-02-28 02:03:01 +01:00
|
|
|
if (name) {
|
|
|
|
err = hfsplus_attr_build_key(sb, fd.search_key,
|
|
|
|
inode->i_ino, name);
|
|
|
|
if (err)
|
|
|
|
goto out;
|
|
|
|
} else {
|
2013-05-01 00:27:55 +02:00
|
|
|
pr_err("invalid extended attribute name\n");
|
2013-02-28 02:03:01 +01:00
|
|
|
err = -EINVAL;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
err = hfs_brec_find(&fd, hfs_find_rec_by_key);
|
|
|
|
if (err)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
err = __hfsplus_delete_attr(inode, inode->i_ino, &fd);
|
|
|
|
if (err)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
out:
|
|
|
|
hfs_find_exit(&fd);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
int hfsplus_delete_all_attrs(struct inode *dir, u32 cnid)
|
|
|
|
{
|
|
|
|
int err = 0;
|
|
|
|
struct hfs_find_data fd;
|
|
|
|
|
2013-05-01 00:27:54 +02:00
|
|
|
hfs_dbg(ATTR_MOD, "delete_all_attrs: %d\n", cnid);
|
2013-02-28 02:03:01 +01:00
|
|
|
|
|
|
|
if (!HFSPLUS_SB(dir->i_sb)->attr_tree) {
|
2013-05-01 00:27:55 +02:00
|
|
|
pr_err("attributes file doesn't exist\n");
|
2013-02-28 02:03:01 +01:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
err = hfs_find_init(HFSPLUS_SB(dir->i_sb)->attr_tree, &fd);
|
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
|
|
|
|
for (;;) {
|
|
|
|
err = hfsplus_find_attr(dir->i_sb, cnid, NULL, &fd);
|
|
|
|
if (err) {
|
|
|
|
if (err != -ENOENT)
|
2013-05-01 00:27:55 +02:00
|
|
|
pr_err("xattr search failed\n");
|
2013-02-28 02:03:01 +01:00
|
|
|
goto end_delete_all;
|
|
|
|
}
|
|
|
|
|
|
|
|
err = __hfsplus_delete_attr(dir, cnid, &fd);
|
|
|
|
if (err)
|
|
|
|
goto end_delete_all;
|
|
|
|
}
|
|
|
|
|
|
|
|
end_delete_all:
|
|
|
|
hfs_find_exit(&fd);
|
|
|
|
return err;
|
|
|
|
}
|