2008-04-30 09:55:01 +02:00
|
|
|
/*
|
|
|
|
* Generic infrastructure for lifetime debugging of objects.
|
|
|
|
*
|
|
|
|
* Started by Thomas Gleixner
|
|
|
|
*
|
|
|
|
* Copyright (C) 2008, Thomas Gleixner <tglx@linutronix.de>
|
|
|
|
*
|
|
|
|
* For licencing details see kernel-base/COPYING
|
|
|
|
*/
|
2014-06-05 01:06:04 +02:00
|
|
|
|
|
|
|
#define pr_fmt(fmt) "ODEBUG: " fmt
|
|
|
|
|
2008-04-30 09:55:01 +02:00
|
|
|
#include <linux/debugobjects.h>
|
|
|
|
#include <linux/interrupt.h>
|
2009-10-07 15:09:06 +02:00
|
|
|
#include <linux/sched.h>
|
2008-04-30 09:55:01 +02:00
|
|
|
#include <linux/seq_file.h>
|
|
|
|
#include <linux/debugfs.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 09:04:11 +01:00
|
|
|
#include <linux/slab.h>
|
2008-04-30 09:55:01 +02:00
|
|
|
#include <linux/hash.h>
|
|
|
|
|
|
|
|
#define ODEBUG_HASH_BITS 14
|
|
|
|
#define ODEBUG_HASH_SIZE (1 << ODEBUG_HASH_BITS)
|
|
|
|
|
|
|
|
#define ODEBUG_POOL_SIZE 512
|
|
|
|
#define ODEBUG_POOL_MIN_LEVEL 256
|
|
|
|
|
|
|
|
#define ODEBUG_CHUNK_SHIFT PAGE_SHIFT
|
|
|
|
#define ODEBUG_CHUNK_SIZE (1 << ODEBUG_CHUNK_SHIFT)
|
|
|
|
#define ODEBUG_CHUNK_MASK (~(ODEBUG_CHUNK_SIZE - 1))
|
|
|
|
|
|
|
|
struct debug_bucket {
|
|
|
|
struct hlist_head list;
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spinlock_t lock;
|
2008-04-30 09:55:01 +02:00
|
|
|
};
|
|
|
|
|
|
|
|
static struct debug_bucket obj_hash[ODEBUG_HASH_SIZE];
|
|
|
|
|
2009-03-16 18:53:18 +01:00
|
|
|
static struct debug_obj obj_static_pool[ODEBUG_POOL_SIZE] __initdata;
|
2008-04-30 09:55:01 +02:00
|
|
|
|
2009-11-17 18:11:28 +01:00
|
|
|
static DEFINE_RAW_SPINLOCK(pool_lock);
|
2008-04-30 09:55:01 +02:00
|
|
|
|
|
|
|
static HLIST_HEAD(obj_pool);
|
|
|
|
|
|
|
|
static int obj_pool_min_free = ODEBUG_POOL_SIZE;
|
|
|
|
static int obj_pool_free = ODEBUG_POOL_SIZE;
|
|
|
|
static int obj_pool_used;
|
|
|
|
static int obj_pool_max_used;
|
|
|
|
static struct kmem_cache *obj_cache;
|
|
|
|
|
|
|
|
static int debug_objects_maxchain __read_mostly;
|
|
|
|
static int debug_objects_fixups __read_mostly;
|
|
|
|
static int debug_objects_warnings __read_mostly;
|
2008-11-26 10:02:00 +01:00
|
|
|
static int debug_objects_enabled __read_mostly
|
|
|
|
= CONFIG_DEBUG_OBJECTS_ENABLE_DEFAULT;
|
|
|
|
|
2008-04-30 09:55:01 +02:00
|
|
|
static struct debug_obj_descr *descr_test __read_mostly;
|
|
|
|
|
2009-03-16 10:04:53 +01:00
|
|
|
static void free_obj_work(struct work_struct *work);
|
|
|
|
static DECLARE_WORK(debug_obj_work, free_obj_work);
|
|
|
|
|
2008-04-30 09:55:01 +02:00
|
|
|
static int __init enable_object_debug(char *str)
|
|
|
|
{
|
|
|
|
debug_objects_enabled = 1;
|
|
|
|
return 0;
|
|
|
|
}
|
2009-03-02 02:41:41 +01:00
|
|
|
|
|
|
|
static int __init disable_object_debug(char *str)
|
|
|
|
{
|
|
|
|
debug_objects_enabled = 0;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-04-30 09:55:01 +02:00
|
|
|
early_param("debug_objects", enable_object_debug);
|
2009-03-02 02:41:41 +01:00
|
|
|
early_param("no_debug_objects", disable_object_debug);
|
2008-04-30 09:55:01 +02:00
|
|
|
|
|
|
|
static const char *obj_states[ODEBUG_STATE_MAX] = {
|
|
|
|
[ODEBUG_STATE_NONE] = "none",
|
|
|
|
[ODEBUG_STATE_INIT] = "initialized",
|
|
|
|
[ODEBUG_STATE_INACTIVE] = "inactive",
|
|
|
|
[ODEBUG_STATE_ACTIVE] = "active",
|
|
|
|
[ODEBUG_STATE_DESTROYED] = "destroyed",
|
|
|
|
[ODEBUG_STATE_NOTAVAILABLE] = "not available",
|
|
|
|
};
|
|
|
|
|
2012-04-11 11:52:18 +02:00
|
|
|
static void fill_pool(void)
|
2008-04-30 09:55:01 +02:00
|
|
|
{
|
|
|
|
gfp_t gfp = GFP_ATOMIC | __GFP_NORETRY | __GFP_NOWARN;
|
|
|
|
struct debug_obj *new;
|
2008-06-15 00:47:36 +02:00
|
|
|
unsigned long flags;
|
2008-04-30 09:55:01 +02:00
|
|
|
|
|
|
|
if (likely(obj_pool_free >= ODEBUG_POOL_MIN_LEVEL))
|
2012-04-11 11:52:18 +02:00
|
|
|
return;
|
2008-04-30 09:55:01 +02:00
|
|
|
|
|
|
|
if (unlikely(!obj_cache))
|
2012-04-11 11:52:18 +02:00
|
|
|
return;
|
2008-04-30 09:55:01 +02:00
|
|
|
|
|
|
|
while (obj_pool_free < ODEBUG_POOL_MIN_LEVEL) {
|
|
|
|
|
|
|
|
new = kmem_cache_zalloc(obj_cache, gfp);
|
|
|
|
if (!new)
|
2012-04-18 13:28:10 +02:00
|
|
|
return;
|
2008-04-30 09:55:01 +02:00
|
|
|
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_lock_irqsave(&pool_lock, flags);
|
2008-04-30 09:55:01 +02:00
|
|
|
hlist_add_head(&new->node, &obj_pool);
|
|
|
|
obj_pool_free++;
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_unlock_irqrestore(&pool_lock, flags);
|
2008-04-30 09:55:01 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Lookup an object in the hash bucket.
|
|
|
|
*/
|
|
|
|
static struct debug_obj *lookup_object(void *addr, struct debug_bucket *b)
|
|
|
|
{
|
|
|
|
struct debug_obj *obj;
|
|
|
|
int cnt = 0;
|
|
|
|
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 02:06:00 +01:00
|
|
|
hlist_for_each_entry(obj, &b->list, node) {
|
2008-04-30 09:55:01 +02:00
|
|
|
cnt++;
|
|
|
|
if (obj->object == addr)
|
|
|
|
return obj;
|
|
|
|
}
|
|
|
|
if (cnt > debug_objects_maxchain)
|
|
|
|
debug_objects_maxchain = cnt;
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2008-06-15 00:47:36 +02:00
|
|
|
* Allocate a new object. If the pool is empty, switch off the debugger.
|
2008-08-31 23:39:21 +02:00
|
|
|
* Must be called with interrupts disabled.
|
2008-04-30 09:55:01 +02:00
|
|
|
*/
|
|
|
|
static struct debug_obj *
|
|
|
|
alloc_object(void *addr, struct debug_bucket *b, struct debug_obj_descr *descr)
|
|
|
|
{
|
|
|
|
struct debug_obj *obj = NULL;
|
|
|
|
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_lock(&pool_lock);
|
2008-04-30 09:55:01 +02:00
|
|
|
if (obj_pool.first) {
|
|
|
|
obj = hlist_entry(obj_pool.first, typeof(*obj), node);
|
|
|
|
|
|
|
|
obj->object = addr;
|
|
|
|
obj->descr = descr;
|
|
|
|
obj->state = ODEBUG_STATE_NONE;
|
2010-04-17 14:48:38 +02:00
|
|
|
obj->astate = 0;
|
2008-04-30 09:55:01 +02:00
|
|
|
hlist_del(&obj->node);
|
|
|
|
|
|
|
|
hlist_add_head(&obj->node, &b->list);
|
|
|
|
|
|
|
|
obj_pool_used++;
|
|
|
|
if (obj_pool_used > obj_pool_max_used)
|
|
|
|
obj_pool_max_used = obj_pool_used;
|
|
|
|
|
|
|
|
obj_pool_free--;
|
|
|
|
if (obj_pool_free < obj_pool_min_free)
|
|
|
|
obj_pool_min_free = obj_pool_free;
|
|
|
|
}
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_unlock(&pool_lock);
|
2008-04-30 09:55:01 +02:00
|
|
|
|
|
|
|
return obj;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2009-03-16 10:04:53 +01:00
|
|
|
* workqueue function to free objects.
|
2008-04-30 09:55:01 +02:00
|
|
|
*/
|
2009-03-16 10:04:53 +01:00
|
|
|
static void free_obj_work(struct work_struct *work)
|
2008-04-30 09:55:01 +02:00
|
|
|
{
|
2009-03-16 10:04:53 +01:00
|
|
|
struct debug_obj *obj;
|
2008-08-31 23:39:21 +02:00
|
|
|
unsigned long flags;
|
2008-04-30 09:55:01 +02:00
|
|
|
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_lock_irqsave(&pool_lock, flags);
|
2009-03-16 10:04:53 +01:00
|
|
|
while (obj_pool_free > ODEBUG_POOL_SIZE) {
|
|
|
|
obj = hlist_entry(obj_pool.first, typeof(*obj), node);
|
|
|
|
hlist_del(&obj->node);
|
|
|
|
obj_pool_free--;
|
|
|
|
/*
|
|
|
|
* We release pool_lock across kmem_cache_free() to
|
|
|
|
* avoid contention on pool_lock.
|
|
|
|
*/
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_unlock_irqrestore(&pool_lock, flags);
|
2008-04-30 09:55:01 +02:00
|
|
|
kmem_cache_free(obj_cache, obj);
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_lock_irqsave(&pool_lock, flags);
|
2008-04-30 09:55:01 +02:00
|
|
|
}
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_unlock_irqrestore(&pool_lock, flags);
|
2009-03-16 10:04:53 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Put the object back into the pool and schedule work to free objects
|
|
|
|
* if necessary.
|
|
|
|
*/
|
|
|
|
static void free_object(struct debug_obj *obj)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
int sched = 0;
|
|
|
|
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_lock_irqsave(&pool_lock, flags);
|
2009-03-16 10:04:53 +01:00
|
|
|
/*
|
|
|
|
* schedule work when the pool is filled and the cache is
|
|
|
|
* initialized:
|
|
|
|
*/
|
|
|
|
if (obj_pool_free > ODEBUG_POOL_SIZE && obj_cache)
|
2013-11-13 00:09:49 +01:00
|
|
|
sched = keventd_up();
|
2009-03-16 10:04:53 +01:00
|
|
|
hlist_add_head(&obj->node, &obj_pool);
|
|
|
|
obj_pool_free++;
|
|
|
|
obj_pool_used--;
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_unlock_irqrestore(&pool_lock, flags);
|
2009-03-16 10:04:53 +01:00
|
|
|
if (sched)
|
|
|
|
schedule_work(&debug_obj_work);
|
2008-04-30 09:55:01 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We run out of memory. That means we probably have tons of objects
|
|
|
|
* allocated.
|
|
|
|
*/
|
|
|
|
static void debug_objects_oom(void)
|
|
|
|
{
|
|
|
|
struct debug_bucket *db = obj_hash;
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 02:06:00 +01:00
|
|
|
struct hlist_node *tmp;
|
2008-08-31 23:39:21 +02:00
|
|
|
HLIST_HEAD(freelist);
|
2008-04-30 09:55:01 +02:00
|
|
|
struct debug_obj *obj;
|
|
|
|
unsigned long flags;
|
|
|
|
int i;
|
|
|
|
|
2014-06-05 01:06:04 +02:00
|
|
|
pr_warn("Out of memory. ODEBUG disabled\n");
|
2008-04-30 09:55:01 +02:00
|
|
|
|
|
|
|
for (i = 0; i < ODEBUG_HASH_SIZE; i++, db++) {
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_lock_irqsave(&db->lock, flags);
|
2008-08-31 23:39:21 +02:00
|
|
|
hlist_move_list(&db->list, &freelist);
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_unlock_irqrestore(&db->lock, flags);
|
2008-08-31 23:39:21 +02:00
|
|
|
|
|
|
|
/* Now free them */
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 02:06:00 +01:00
|
|
|
hlist_for_each_entry_safe(obj, tmp, &freelist, node) {
|
2008-04-30 09:55:01 +02:00
|
|
|
hlist_del(&obj->node);
|
|
|
|
free_object(obj);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We use the pfn of the address for the hash. That way we can check
|
|
|
|
* for freed objects simply by checking the affected bucket.
|
|
|
|
*/
|
|
|
|
static struct debug_bucket *get_bucket(unsigned long addr)
|
|
|
|
{
|
|
|
|
unsigned long hash;
|
|
|
|
|
|
|
|
hash = hash_long((addr >> ODEBUG_CHUNK_SHIFT), ODEBUG_HASH_BITS);
|
|
|
|
return &obj_hash[hash];
|
|
|
|
}
|
|
|
|
|
|
|
|
static void debug_print_object(struct debug_obj *obj, char *msg)
|
|
|
|
{
|
2011-03-07 09:58:33 +01:00
|
|
|
struct debug_obj_descr *descr = obj->descr;
|
2008-04-30 09:55:01 +02:00
|
|
|
static int limit;
|
|
|
|
|
2011-03-07 09:58:33 +01:00
|
|
|
if (limit < 5 && descr != descr_test) {
|
|
|
|
void *hint = descr->debug_hint ?
|
|
|
|
descr->debug_hint(obj->object) : NULL;
|
2008-04-30 09:55:01 +02:00
|
|
|
limit++;
|
2010-04-17 14:48:38 +02:00
|
|
|
WARN(1, KERN_ERR "ODEBUG: %s %s (active state %u) "
|
2011-03-07 09:58:33 +01:00
|
|
|
"object type: %s hint: %pS\n",
|
2010-04-17 14:48:38 +02:00
|
|
|
msg, obj_states[obj->state], obj->astate,
|
2011-03-07 09:58:33 +01:00
|
|
|
descr->name, hint);
|
2008-04-30 09:55:01 +02:00
|
|
|
}
|
|
|
|
debug_objects_warnings++;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Try to repair the damage, so we have a better chance to get useful
|
|
|
|
* debug output.
|
|
|
|
*/
|
2011-11-08 04:48:26 +01:00
|
|
|
static int
|
2008-04-30 09:55:01 +02:00
|
|
|
debug_object_fixup(int (*fixup)(void *addr, enum debug_obj_state state),
|
|
|
|
void * addr, enum debug_obj_state state)
|
|
|
|
{
|
2011-11-08 04:48:26 +01:00
|
|
|
int fixed = 0;
|
|
|
|
|
2008-04-30 09:55:01 +02:00
|
|
|
if (fixup)
|
2011-11-08 04:48:26 +01:00
|
|
|
fixed = fixup(addr, state);
|
|
|
|
debug_objects_fixups += fixed;
|
|
|
|
return fixed;
|
2008-04-30 09:55:01 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
static void debug_object_is_on_stack(void *addr, int onstack)
|
|
|
|
{
|
|
|
|
int is_on_stack;
|
|
|
|
static int limit;
|
|
|
|
|
|
|
|
if (limit > 4)
|
|
|
|
return;
|
|
|
|
|
2008-07-24 06:26:53 +02:00
|
|
|
is_on_stack = object_is_on_stack(addr);
|
2008-04-30 09:55:01 +02:00
|
|
|
if (is_on_stack == onstack)
|
|
|
|
return;
|
|
|
|
|
|
|
|
limit++;
|
|
|
|
if (is_on_stack)
|
2014-06-05 01:06:04 +02:00
|
|
|
pr_warn("object is on stack, but not annotated\n");
|
2008-04-30 09:55:01 +02:00
|
|
|
else
|
2014-06-05 01:06:04 +02:00
|
|
|
pr_warn("object is not on stack, but annotated\n");
|
2008-04-30 09:55:01 +02:00
|
|
|
WARN_ON(1);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
__debug_object_init(void *addr, struct debug_obj_descr *descr, int onstack)
|
|
|
|
{
|
|
|
|
enum debug_obj_state state;
|
|
|
|
struct debug_bucket *db;
|
|
|
|
struct debug_obj *obj;
|
|
|
|
unsigned long flags;
|
|
|
|
|
2008-06-15 00:47:36 +02:00
|
|
|
fill_pool();
|
|
|
|
|
2008-04-30 09:55:01 +02:00
|
|
|
db = get_bucket((unsigned long) addr);
|
|
|
|
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_lock_irqsave(&db->lock, flags);
|
2008-04-30 09:55:01 +02:00
|
|
|
|
|
|
|
obj = lookup_object(addr, db);
|
|
|
|
if (!obj) {
|
|
|
|
obj = alloc_object(addr, db, descr);
|
|
|
|
if (!obj) {
|
|
|
|
debug_objects_enabled = 0;
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_unlock_irqrestore(&db->lock, flags);
|
2008-04-30 09:55:01 +02:00
|
|
|
debug_objects_oom();
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
debug_object_is_on_stack(addr, onstack);
|
|
|
|
}
|
|
|
|
|
|
|
|
switch (obj->state) {
|
|
|
|
case ODEBUG_STATE_NONE:
|
|
|
|
case ODEBUG_STATE_INIT:
|
|
|
|
case ODEBUG_STATE_INACTIVE:
|
|
|
|
obj->state = ODEBUG_STATE_INIT;
|
|
|
|
break;
|
|
|
|
|
|
|
|
case ODEBUG_STATE_ACTIVE:
|
|
|
|
debug_print_object(obj, "init");
|
|
|
|
state = obj->state;
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_unlock_irqrestore(&db->lock, flags);
|
2008-04-30 09:55:01 +02:00
|
|
|
debug_object_fixup(descr->fixup_init, addr, state);
|
|
|
|
return;
|
|
|
|
|
|
|
|
case ODEBUG_STATE_DESTROYED:
|
|
|
|
debug_print_object(obj, "init");
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_unlock_irqrestore(&db->lock, flags);
|
2008-04-30 09:55:01 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* debug_object_init - debug checks when an object is initialized
|
|
|
|
* @addr: address of the object
|
|
|
|
* @descr: pointer to an object specific debug description structure
|
|
|
|
*/
|
|
|
|
void debug_object_init(void *addr, struct debug_obj_descr *descr)
|
|
|
|
{
|
|
|
|
if (!debug_objects_enabled)
|
|
|
|
return;
|
|
|
|
|
|
|
|
__debug_object_init(addr, descr, 0);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* debug_object_init_on_stack - debug checks when an object on stack is
|
|
|
|
* initialized
|
|
|
|
* @addr: address of the object
|
|
|
|
* @descr: pointer to an object specific debug description structure
|
|
|
|
*/
|
|
|
|
void debug_object_init_on_stack(void *addr, struct debug_obj_descr *descr)
|
|
|
|
{
|
|
|
|
if (!debug_objects_enabled)
|
|
|
|
return;
|
|
|
|
|
|
|
|
__debug_object_init(addr, descr, 1);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* debug_object_activate - debug checks when an object is activated
|
|
|
|
* @addr: address of the object
|
|
|
|
* @descr: pointer to an object specific debug description structure
|
2013-04-23 21:51:11 +02:00
|
|
|
* Returns 0 for success, -EINVAL for check failed.
|
2008-04-30 09:55:01 +02:00
|
|
|
*/
|
2013-04-23 21:51:11 +02:00
|
|
|
int debug_object_activate(void *addr, struct debug_obj_descr *descr)
|
2008-04-30 09:55:01 +02:00
|
|
|
{
|
|
|
|
enum debug_obj_state state;
|
|
|
|
struct debug_bucket *db;
|
|
|
|
struct debug_obj *obj;
|
|
|
|
unsigned long flags;
|
2013-04-23 21:51:11 +02:00
|
|
|
int ret;
|
2011-11-08 04:48:26 +01:00
|
|
|
struct debug_obj o = { .object = addr,
|
|
|
|
.state = ODEBUG_STATE_NOTAVAILABLE,
|
|
|
|
.descr = descr };
|
2008-04-30 09:55:01 +02:00
|
|
|
|
|
|
|
if (!debug_objects_enabled)
|
2013-04-23 21:51:11 +02:00
|
|
|
return 0;
|
2008-04-30 09:55:01 +02:00
|
|
|
|
|
|
|
db = get_bucket((unsigned long) addr);
|
|
|
|
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_lock_irqsave(&db->lock, flags);
|
2008-04-30 09:55:01 +02:00
|
|
|
|
|
|
|
obj = lookup_object(addr, db);
|
|
|
|
if (obj) {
|
|
|
|
switch (obj->state) {
|
|
|
|
case ODEBUG_STATE_INIT:
|
|
|
|
case ODEBUG_STATE_INACTIVE:
|
|
|
|
obj->state = ODEBUG_STATE_ACTIVE;
|
2013-04-23 21:51:11 +02:00
|
|
|
ret = 0;
|
2008-04-30 09:55:01 +02:00
|
|
|
break;
|
|
|
|
|
|
|
|
case ODEBUG_STATE_ACTIVE:
|
|
|
|
debug_print_object(obj, "activate");
|
|
|
|
state = obj->state;
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_unlock_irqrestore(&db->lock, flags);
|
2013-04-23 21:51:11 +02:00
|
|
|
ret = debug_object_fixup(descr->fixup_activate, addr, state);
|
|
|
|
return ret ? -EINVAL : 0;
|
2008-04-30 09:55:01 +02:00
|
|
|
|
|
|
|
case ODEBUG_STATE_DESTROYED:
|
|
|
|
debug_print_object(obj, "activate");
|
2013-04-23 21:51:11 +02:00
|
|
|
ret = -EINVAL;
|
2008-04-30 09:55:01 +02:00
|
|
|
break;
|
|
|
|
default:
|
2013-04-23 21:51:11 +02:00
|
|
|
ret = 0;
|
2008-04-30 09:55:01 +02:00
|
|
|
break;
|
|
|
|
}
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_unlock_irqrestore(&db->lock, flags);
|
2013-04-23 21:51:11 +02:00
|
|
|
return ret;
|
2008-04-30 09:55:01 +02:00
|
|
|
}
|
|
|
|
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_unlock_irqrestore(&db->lock, flags);
|
2008-04-30 09:55:01 +02:00
|
|
|
/*
|
|
|
|
* This happens when a static object is activated. We
|
|
|
|
* let the type specific code decide whether this is
|
|
|
|
* true or not.
|
|
|
|
*/
|
2011-11-08 04:48:26 +01:00
|
|
|
if (debug_object_fixup(descr->fixup_activate, addr,
|
2013-04-23 21:51:11 +02:00
|
|
|
ODEBUG_STATE_NOTAVAILABLE)) {
|
2011-11-08 04:48:26 +01:00
|
|
|
debug_print_object(&o, "activate");
|
2013-04-23 21:51:11 +02:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
return 0;
|
2008-04-30 09:55:01 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* debug_object_deactivate - debug checks when an object is deactivated
|
|
|
|
* @addr: address of the object
|
|
|
|
* @descr: pointer to an object specific debug description structure
|
|
|
|
*/
|
|
|
|
void debug_object_deactivate(void *addr, struct debug_obj_descr *descr)
|
|
|
|
{
|
|
|
|
struct debug_bucket *db;
|
|
|
|
struct debug_obj *obj;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
if (!debug_objects_enabled)
|
|
|
|
return;
|
|
|
|
|
|
|
|
db = get_bucket((unsigned long) addr);
|
|
|
|
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_lock_irqsave(&db->lock, flags);
|
2008-04-30 09:55:01 +02:00
|
|
|
|
|
|
|
obj = lookup_object(addr, db);
|
|
|
|
if (obj) {
|
|
|
|
switch (obj->state) {
|
|
|
|
case ODEBUG_STATE_INIT:
|
|
|
|
case ODEBUG_STATE_INACTIVE:
|
|
|
|
case ODEBUG_STATE_ACTIVE:
|
2010-04-17 14:48:38 +02:00
|
|
|
if (!obj->astate)
|
|
|
|
obj->state = ODEBUG_STATE_INACTIVE;
|
|
|
|
else
|
|
|
|
debug_print_object(obj, "deactivate");
|
2008-04-30 09:55:01 +02:00
|
|
|
break;
|
|
|
|
|
|
|
|
case ODEBUG_STATE_DESTROYED:
|
|
|
|
debug_print_object(obj, "deactivate");
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
struct debug_obj o = { .object = addr,
|
|
|
|
.state = ODEBUG_STATE_NOTAVAILABLE,
|
|
|
|
.descr = descr };
|
|
|
|
|
|
|
|
debug_print_object(&o, "deactivate");
|
|
|
|
}
|
|
|
|
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_unlock_irqrestore(&db->lock, flags);
|
2008-04-30 09:55:01 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* debug_object_destroy - debug checks when an object is destroyed
|
|
|
|
* @addr: address of the object
|
|
|
|
* @descr: pointer to an object specific debug description structure
|
|
|
|
*/
|
|
|
|
void debug_object_destroy(void *addr, struct debug_obj_descr *descr)
|
|
|
|
{
|
|
|
|
enum debug_obj_state state;
|
|
|
|
struct debug_bucket *db;
|
|
|
|
struct debug_obj *obj;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
if (!debug_objects_enabled)
|
|
|
|
return;
|
|
|
|
|
|
|
|
db = get_bucket((unsigned long) addr);
|
|
|
|
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_lock_irqsave(&db->lock, flags);
|
2008-04-30 09:55:01 +02:00
|
|
|
|
|
|
|
obj = lookup_object(addr, db);
|
|
|
|
if (!obj)
|
|
|
|
goto out_unlock;
|
|
|
|
|
|
|
|
switch (obj->state) {
|
|
|
|
case ODEBUG_STATE_NONE:
|
|
|
|
case ODEBUG_STATE_INIT:
|
|
|
|
case ODEBUG_STATE_INACTIVE:
|
|
|
|
obj->state = ODEBUG_STATE_DESTROYED;
|
|
|
|
break;
|
|
|
|
case ODEBUG_STATE_ACTIVE:
|
|
|
|
debug_print_object(obj, "destroy");
|
|
|
|
state = obj->state;
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_unlock_irqrestore(&db->lock, flags);
|
2008-04-30 09:55:01 +02:00
|
|
|
debug_object_fixup(descr->fixup_destroy, addr, state);
|
|
|
|
return;
|
|
|
|
|
|
|
|
case ODEBUG_STATE_DESTROYED:
|
|
|
|
debug_print_object(obj, "destroy");
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
out_unlock:
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_unlock_irqrestore(&db->lock, flags);
|
2008-04-30 09:55:01 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* debug_object_free - debug checks when an object is freed
|
|
|
|
* @addr: address of the object
|
|
|
|
* @descr: pointer to an object specific debug description structure
|
|
|
|
*/
|
|
|
|
void debug_object_free(void *addr, struct debug_obj_descr *descr)
|
|
|
|
{
|
|
|
|
enum debug_obj_state state;
|
|
|
|
struct debug_bucket *db;
|
|
|
|
struct debug_obj *obj;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
if (!debug_objects_enabled)
|
|
|
|
return;
|
|
|
|
|
|
|
|
db = get_bucket((unsigned long) addr);
|
|
|
|
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_lock_irqsave(&db->lock, flags);
|
2008-04-30 09:55:01 +02:00
|
|
|
|
|
|
|
obj = lookup_object(addr, db);
|
|
|
|
if (!obj)
|
|
|
|
goto out_unlock;
|
|
|
|
|
|
|
|
switch (obj->state) {
|
|
|
|
case ODEBUG_STATE_ACTIVE:
|
|
|
|
debug_print_object(obj, "free");
|
|
|
|
state = obj->state;
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_unlock_irqrestore(&db->lock, flags);
|
2008-04-30 09:55:01 +02:00
|
|
|
debug_object_fixup(descr->fixup_free, addr, state);
|
|
|
|
return;
|
|
|
|
default:
|
|
|
|
hlist_del(&obj->node);
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_unlock_irqrestore(&db->lock, flags);
|
2008-04-30 09:55:01 +02:00
|
|
|
free_object(obj);
|
2008-08-31 23:39:21 +02:00
|
|
|
return;
|
2008-04-30 09:55:01 +02:00
|
|
|
}
|
|
|
|
out_unlock:
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_unlock_irqrestore(&db->lock, flags);
|
2008-04-30 09:55:01 +02:00
|
|
|
}
|
|
|
|
|
2011-11-08 04:48:27 +01:00
|
|
|
/**
|
|
|
|
* debug_object_assert_init - debug checks when object should be init-ed
|
|
|
|
* @addr: address of the object
|
|
|
|
* @descr: pointer to an object specific debug description structure
|
|
|
|
*/
|
|
|
|
void debug_object_assert_init(void *addr, struct debug_obj_descr *descr)
|
|
|
|
{
|
|
|
|
struct debug_bucket *db;
|
|
|
|
struct debug_obj *obj;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
if (!debug_objects_enabled)
|
|
|
|
return;
|
|
|
|
|
|
|
|
db = get_bucket((unsigned long) addr);
|
|
|
|
|
|
|
|
raw_spin_lock_irqsave(&db->lock, flags);
|
|
|
|
|
|
|
|
obj = lookup_object(addr, db);
|
|
|
|
if (!obj) {
|
|
|
|
struct debug_obj o = { .object = addr,
|
|
|
|
.state = ODEBUG_STATE_NOTAVAILABLE,
|
|
|
|
.descr = descr };
|
|
|
|
|
|
|
|
raw_spin_unlock_irqrestore(&db->lock, flags);
|
|
|
|
/*
|
|
|
|
* Maybe the object is static. Let the type specific
|
|
|
|
* code decide what to do.
|
|
|
|
*/
|
|
|
|
if (debug_object_fixup(descr->fixup_assert_init, addr,
|
|
|
|
ODEBUG_STATE_NOTAVAILABLE))
|
|
|
|
debug_print_object(&o, "assert_init");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
raw_spin_unlock_irqrestore(&db->lock, flags);
|
|
|
|
}
|
|
|
|
|
2010-04-17 14:48:38 +02:00
|
|
|
/**
|
|
|
|
* debug_object_active_state - debug checks object usage state machine
|
|
|
|
* @addr: address of the object
|
|
|
|
* @descr: pointer to an object specific debug description structure
|
|
|
|
* @expect: expected state
|
|
|
|
* @next: state to move to if expected state is found
|
|
|
|
*/
|
|
|
|
void
|
|
|
|
debug_object_active_state(void *addr, struct debug_obj_descr *descr,
|
|
|
|
unsigned int expect, unsigned int next)
|
|
|
|
{
|
|
|
|
struct debug_bucket *db;
|
|
|
|
struct debug_obj *obj;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
if (!debug_objects_enabled)
|
|
|
|
return;
|
|
|
|
|
|
|
|
db = get_bucket((unsigned long) addr);
|
|
|
|
|
|
|
|
raw_spin_lock_irqsave(&db->lock, flags);
|
|
|
|
|
|
|
|
obj = lookup_object(addr, db);
|
|
|
|
if (obj) {
|
|
|
|
switch (obj->state) {
|
|
|
|
case ODEBUG_STATE_ACTIVE:
|
|
|
|
if (obj->astate == expect)
|
|
|
|
obj->astate = next;
|
|
|
|
else
|
|
|
|
debug_print_object(obj, "active_state");
|
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
|
|
|
debug_print_object(obj, "active_state");
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
struct debug_obj o = { .object = addr,
|
|
|
|
.state = ODEBUG_STATE_NOTAVAILABLE,
|
|
|
|
.descr = descr };
|
|
|
|
|
|
|
|
debug_print_object(&o, "active_state");
|
|
|
|
}
|
|
|
|
|
|
|
|
raw_spin_unlock_irqrestore(&db->lock, flags);
|
|
|
|
}
|
|
|
|
|
2008-04-30 09:55:01 +02:00
|
|
|
#ifdef CONFIG_DEBUG_OBJECTS_FREE
|
|
|
|
static void __debug_check_no_obj_freed(const void *address, unsigned long size)
|
|
|
|
{
|
|
|
|
unsigned long flags, oaddr, saddr, eaddr, paddr, chunks;
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 02:06:00 +01:00
|
|
|
struct hlist_node *tmp;
|
2008-08-31 23:39:21 +02:00
|
|
|
HLIST_HEAD(freelist);
|
2008-04-30 09:55:01 +02:00
|
|
|
struct debug_obj_descr *descr;
|
|
|
|
enum debug_obj_state state;
|
|
|
|
struct debug_bucket *db;
|
|
|
|
struct debug_obj *obj;
|
|
|
|
int cnt;
|
|
|
|
|
|
|
|
saddr = (unsigned long) address;
|
|
|
|
eaddr = saddr + size;
|
|
|
|
paddr = saddr & ODEBUG_CHUNK_MASK;
|
|
|
|
chunks = ((eaddr - paddr) + (ODEBUG_CHUNK_SIZE - 1));
|
|
|
|
chunks >>= ODEBUG_CHUNK_SHIFT;
|
|
|
|
|
|
|
|
for (;chunks > 0; chunks--, paddr += ODEBUG_CHUNK_SIZE) {
|
|
|
|
db = get_bucket(paddr);
|
|
|
|
|
|
|
|
repeat:
|
|
|
|
cnt = 0;
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_lock_irqsave(&db->lock, flags);
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 02:06:00 +01:00
|
|
|
hlist_for_each_entry_safe(obj, tmp, &db->list, node) {
|
2008-04-30 09:55:01 +02:00
|
|
|
cnt++;
|
|
|
|
oaddr = (unsigned long) obj->object;
|
|
|
|
if (oaddr < saddr || oaddr >= eaddr)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
switch (obj->state) {
|
|
|
|
case ODEBUG_STATE_ACTIVE:
|
|
|
|
debug_print_object(obj, "free");
|
|
|
|
descr = obj->descr;
|
|
|
|
state = obj->state;
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_unlock_irqrestore(&db->lock, flags);
|
2008-04-30 09:55:01 +02:00
|
|
|
debug_object_fixup(descr->fixup_free,
|
|
|
|
(void *) oaddr, state);
|
|
|
|
goto repeat;
|
|
|
|
default:
|
|
|
|
hlist_del(&obj->node);
|
2008-08-31 23:39:21 +02:00
|
|
|
hlist_add_head(&obj->node, &freelist);
|
2008-04-30 09:55:01 +02:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_unlock_irqrestore(&db->lock, flags);
|
2008-08-31 23:39:21 +02:00
|
|
|
|
|
|
|
/* Now free them */
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 02:06:00 +01:00
|
|
|
hlist_for_each_entry_safe(obj, tmp, &freelist, node) {
|
2008-08-31 23:39:21 +02:00
|
|
|
hlist_del(&obj->node);
|
|
|
|
free_object(obj);
|
|
|
|
}
|
|
|
|
|
2008-04-30 09:55:01 +02:00
|
|
|
if (cnt > debug_objects_maxchain)
|
|
|
|
debug_objects_maxchain = cnt;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void debug_check_no_obj_freed(const void *address, unsigned long size)
|
|
|
|
{
|
|
|
|
if (debug_objects_enabled)
|
|
|
|
__debug_check_no_obj_freed(address, size);
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
|
|
|
#ifdef CONFIG_DEBUG_FS
|
|
|
|
|
|
|
|
static int debug_stats_show(struct seq_file *m, void *v)
|
|
|
|
{
|
|
|
|
seq_printf(m, "max_chain :%d\n", debug_objects_maxchain);
|
|
|
|
seq_printf(m, "warnings :%d\n", debug_objects_warnings);
|
|
|
|
seq_printf(m, "fixups :%d\n", debug_objects_fixups);
|
|
|
|
seq_printf(m, "pool_free :%d\n", obj_pool_free);
|
|
|
|
seq_printf(m, "pool_min_free :%d\n", obj_pool_min_free);
|
|
|
|
seq_printf(m, "pool_used :%d\n", obj_pool_used);
|
|
|
|
seq_printf(m, "pool_max_used :%d\n", obj_pool_max_used);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int debug_stats_open(struct inode *inode, struct file *filp)
|
|
|
|
{
|
|
|
|
return single_open(filp, debug_stats_show, NULL);
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct file_operations debug_stats_fops = {
|
|
|
|
.open = debug_stats_open,
|
|
|
|
.read = seq_read,
|
|
|
|
.llseek = seq_lseek,
|
|
|
|
.release = single_release,
|
|
|
|
};
|
|
|
|
|
|
|
|
static int __init debug_objects_init_debugfs(void)
|
|
|
|
{
|
|
|
|
struct dentry *dbgdir, *dbgstats;
|
|
|
|
|
|
|
|
if (!debug_objects_enabled)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
dbgdir = debugfs_create_dir("debug_objects", NULL);
|
|
|
|
if (!dbgdir)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
dbgstats = debugfs_create_file("stats", 0444, dbgdir, NULL,
|
|
|
|
&debug_stats_fops);
|
|
|
|
if (!dbgstats)
|
|
|
|
goto err;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
err:
|
|
|
|
debugfs_remove(dbgdir);
|
|
|
|
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
__initcall(debug_objects_init_debugfs);
|
|
|
|
|
|
|
|
#else
|
|
|
|
static inline void debug_objects_init_debugfs(void) { }
|
|
|
|
#endif
|
|
|
|
|
|
|
|
#ifdef CONFIG_DEBUG_OBJECTS_SELFTEST
|
|
|
|
|
|
|
|
/* Random data structure for the self test */
|
|
|
|
struct self_test {
|
|
|
|
unsigned long dummy1[6];
|
|
|
|
int static_init;
|
|
|
|
unsigned long dummy2[3];
|
|
|
|
};
|
|
|
|
|
|
|
|
static __initdata struct debug_obj_descr descr_type_test;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* fixup_init is called when:
|
|
|
|
* - an active object is initialized
|
|
|
|
*/
|
|
|
|
static int __init fixup_init(void *addr, enum debug_obj_state state)
|
|
|
|
{
|
|
|
|
struct self_test *obj = addr;
|
|
|
|
|
|
|
|
switch (state) {
|
|
|
|
case ODEBUG_STATE_ACTIVE:
|
|
|
|
debug_object_deactivate(obj, &descr_type_test);
|
|
|
|
debug_object_init(obj, &descr_type_test);
|
|
|
|
return 1;
|
|
|
|
default:
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* fixup_activate is called when:
|
|
|
|
* - an active object is activated
|
|
|
|
* - an unknown object is activated (might be a statically initialized object)
|
|
|
|
*/
|
|
|
|
static int __init fixup_activate(void *addr, enum debug_obj_state state)
|
|
|
|
{
|
|
|
|
struct self_test *obj = addr;
|
|
|
|
|
|
|
|
switch (state) {
|
|
|
|
case ODEBUG_STATE_NOTAVAILABLE:
|
|
|
|
if (obj->static_init == 1) {
|
|
|
|
debug_object_init(obj, &descr_type_test);
|
|
|
|
debug_object_activate(obj, &descr_type_test);
|
2012-03-05 23:59:17 +01:00
|
|
|
return 0;
|
2008-04-30 09:55:01 +02:00
|
|
|
}
|
2012-03-05 23:59:17 +01:00
|
|
|
return 1;
|
2008-04-30 09:55:01 +02:00
|
|
|
|
|
|
|
case ODEBUG_STATE_ACTIVE:
|
|
|
|
debug_object_deactivate(obj, &descr_type_test);
|
|
|
|
debug_object_activate(obj, &descr_type_test);
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
default:
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* fixup_destroy is called when:
|
|
|
|
* - an active object is destroyed
|
|
|
|
*/
|
|
|
|
static int __init fixup_destroy(void *addr, enum debug_obj_state state)
|
|
|
|
{
|
|
|
|
struct self_test *obj = addr;
|
|
|
|
|
|
|
|
switch (state) {
|
|
|
|
case ODEBUG_STATE_ACTIVE:
|
|
|
|
debug_object_deactivate(obj, &descr_type_test);
|
|
|
|
debug_object_destroy(obj, &descr_type_test);
|
|
|
|
return 1;
|
|
|
|
default:
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* fixup_free is called when:
|
|
|
|
* - an active object is freed
|
|
|
|
*/
|
|
|
|
static int __init fixup_free(void *addr, enum debug_obj_state state)
|
|
|
|
{
|
|
|
|
struct self_test *obj = addr;
|
|
|
|
|
|
|
|
switch (state) {
|
|
|
|
case ODEBUG_STATE_ACTIVE:
|
|
|
|
debug_object_deactivate(obj, &descr_type_test);
|
|
|
|
debug_object_free(obj, &descr_type_test);
|
|
|
|
return 1;
|
|
|
|
default:
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-03-26 20:38:35 +01:00
|
|
|
static int __init
|
2008-04-30 09:55:01 +02:00
|
|
|
check_results(void *addr, enum debug_obj_state state, int fixups, int warnings)
|
|
|
|
{
|
|
|
|
struct debug_bucket *db;
|
|
|
|
struct debug_obj *obj;
|
|
|
|
unsigned long flags;
|
|
|
|
int res = -EINVAL;
|
|
|
|
|
|
|
|
db = get_bucket((unsigned long) addr);
|
|
|
|
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_lock_irqsave(&db->lock, flags);
|
2008-04-30 09:55:01 +02:00
|
|
|
|
|
|
|
obj = lookup_object(addr, db);
|
|
|
|
if (!obj && state != ODEBUG_STATE_NONE) {
|
2008-07-26 04:45:39 +02:00
|
|
|
WARN(1, KERN_ERR "ODEBUG: selftest object not found\n");
|
2008-04-30 09:55:01 +02:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
if (obj && obj->state != state) {
|
2008-07-26 04:45:39 +02:00
|
|
|
WARN(1, KERN_ERR "ODEBUG: selftest wrong state: %d != %d\n",
|
2008-04-30 09:55:01 +02:00
|
|
|
obj->state, state);
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
if (fixups != debug_objects_fixups) {
|
2008-07-26 04:45:39 +02:00
|
|
|
WARN(1, KERN_ERR "ODEBUG: selftest fixups failed %d != %d\n",
|
2008-04-30 09:55:01 +02:00
|
|
|
fixups, debug_objects_fixups);
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
if (warnings != debug_objects_warnings) {
|
2008-07-26 04:45:39 +02:00
|
|
|
WARN(1, KERN_ERR "ODEBUG: selftest warnings failed %d != %d\n",
|
2008-04-30 09:55:01 +02:00
|
|
|
warnings, debug_objects_warnings);
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
res = 0;
|
|
|
|
out:
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_unlock_irqrestore(&db->lock, flags);
|
2008-04-30 09:55:01 +02:00
|
|
|
if (res)
|
|
|
|
debug_objects_enabled = 0;
|
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
|
|
|
static __initdata struct debug_obj_descr descr_type_test = {
|
|
|
|
.name = "selftest",
|
|
|
|
.fixup_init = fixup_init,
|
|
|
|
.fixup_activate = fixup_activate,
|
|
|
|
.fixup_destroy = fixup_destroy,
|
|
|
|
.fixup_free = fixup_free,
|
|
|
|
};
|
|
|
|
|
|
|
|
static __initdata struct self_test obj = { .static_init = 0 };
|
|
|
|
|
|
|
|
static void __init debug_objects_selftest(void)
|
|
|
|
{
|
|
|
|
int fixups, oldfixups, warnings, oldwarnings;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
local_irq_save(flags);
|
|
|
|
|
|
|
|
fixups = oldfixups = debug_objects_fixups;
|
|
|
|
warnings = oldwarnings = debug_objects_warnings;
|
|
|
|
descr_test = &descr_type_test;
|
|
|
|
|
|
|
|
debug_object_init(&obj, &descr_type_test);
|
|
|
|
if (check_results(&obj, ODEBUG_STATE_INIT, fixups, warnings))
|
|
|
|
goto out;
|
|
|
|
debug_object_activate(&obj, &descr_type_test);
|
|
|
|
if (check_results(&obj, ODEBUG_STATE_ACTIVE, fixups, warnings))
|
|
|
|
goto out;
|
|
|
|
debug_object_activate(&obj, &descr_type_test);
|
|
|
|
if (check_results(&obj, ODEBUG_STATE_ACTIVE, ++fixups, ++warnings))
|
|
|
|
goto out;
|
|
|
|
debug_object_deactivate(&obj, &descr_type_test);
|
|
|
|
if (check_results(&obj, ODEBUG_STATE_INACTIVE, fixups, warnings))
|
|
|
|
goto out;
|
|
|
|
debug_object_destroy(&obj, &descr_type_test);
|
|
|
|
if (check_results(&obj, ODEBUG_STATE_DESTROYED, fixups, warnings))
|
|
|
|
goto out;
|
|
|
|
debug_object_init(&obj, &descr_type_test);
|
|
|
|
if (check_results(&obj, ODEBUG_STATE_DESTROYED, fixups, ++warnings))
|
|
|
|
goto out;
|
|
|
|
debug_object_activate(&obj, &descr_type_test);
|
|
|
|
if (check_results(&obj, ODEBUG_STATE_DESTROYED, fixups, ++warnings))
|
|
|
|
goto out;
|
|
|
|
debug_object_deactivate(&obj, &descr_type_test);
|
|
|
|
if (check_results(&obj, ODEBUG_STATE_DESTROYED, fixups, ++warnings))
|
|
|
|
goto out;
|
|
|
|
debug_object_free(&obj, &descr_type_test);
|
|
|
|
if (check_results(&obj, ODEBUG_STATE_NONE, fixups, warnings))
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
obj.static_init = 1;
|
|
|
|
debug_object_activate(&obj, &descr_type_test);
|
2012-03-05 23:59:17 +01:00
|
|
|
if (check_results(&obj, ODEBUG_STATE_ACTIVE, fixups, warnings))
|
2008-04-30 09:55:01 +02:00
|
|
|
goto out;
|
|
|
|
debug_object_init(&obj, &descr_type_test);
|
|
|
|
if (check_results(&obj, ODEBUG_STATE_INIT, ++fixups, ++warnings))
|
|
|
|
goto out;
|
|
|
|
debug_object_free(&obj, &descr_type_test);
|
|
|
|
if (check_results(&obj, ODEBUG_STATE_NONE, fixups, warnings))
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
#ifdef CONFIG_DEBUG_OBJECTS_FREE
|
|
|
|
debug_object_init(&obj, &descr_type_test);
|
|
|
|
if (check_results(&obj, ODEBUG_STATE_INIT, fixups, warnings))
|
|
|
|
goto out;
|
|
|
|
debug_object_activate(&obj, &descr_type_test);
|
|
|
|
if (check_results(&obj, ODEBUG_STATE_ACTIVE, fixups, warnings))
|
|
|
|
goto out;
|
|
|
|
__debug_check_no_obj_freed(&obj, sizeof(obj));
|
|
|
|
if (check_results(&obj, ODEBUG_STATE_NONE, ++fixups, ++warnings))
|
|
|
|
goto out;
|
|
|
|
#endif
|
2014-06-05 01:06:04 +02:00
|
|
|
pr_info("selftest passed\n");
|
2008-04-30 09:55:01 +02:00
|
|
|
|
|
|
|
out:
|
|
|
|
debug_objects_fixups = oldfixups;
|
|
|
|
debug_objects_warnings = oldwarnings;
|
|
|
|
descr_test = NULL;
|
|
|
|
|
|
|
|
local_irq_restore(flags);
|
|
|
|
}
|
|
|
|
#else
|
|
|
|
static inline void debug_objects_selftest(void) { }
|
|
|
|
#endif
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Called during early boot to initialize the hash buckets and link
|
|
|
|
* the static object pool objects into the poll list. After this call
|
|
|
|
* the object tracker is fully operational.
|
|
|
|
*/
|
|
|
|
void __init debug_objects_early_init(void)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < ODEBUG_HASH_SIZE; i++)
|
2009-11-17 18:11:28 +01:00
|
|
|
raw_spin_lock_init(&obj_hash[i].lock);
|
2008-04-30 09:55:01 +02:00
|
|
|
|
|
|
|
for (i = 0; i < ODEBUG_POOL_SIZE; i++)
|
|
|
|
hlist_add_head(&obj_static_pool[i].node, &obj_pool);
|
|
|
|
}
|
|
|
|
|
2009-03-16 18:53:18 +01:00
|
|
|
/*
|
|
|
|
* Convert the statically allocated objects to dynamic ones:
|
|
|
|
*/
|
2010-03-26 20:38:35 +01:00
|
|
|
static int __init debug_objects_replace_static_objects(void)
|
2009-03-16 18:53:18 +01:00
|
|
|
{
|
|
|
|
struct debug_bucket *db = obj_hash;
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 02:06:00 +01:00
|
|
|
struct hlist_node *tmp;
|
2009-03-16 18:53:18 +01:00
|
|
|
struct debug_obj *obj, *new;
|
|
|
|
HLIST_HEAD(objects);
|
|
|
|
int i, cnt = 0;
|
|
|
|
|
|
|
|
for (i = 0; i < ODEBUG_POOL_SIZE; i++) {
|
|
|
|
obj = kmem_cache_zalloc(obj_cache, GFP_KERNEL);
|
|
|
|
if (!obj)
|
|
|
|
goto free;
|
|
|
|
hlist_add_head(&obj->node, &objects);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* When debug_objects_mem_init() is called we know that only
|
|
|
|
* one CPU is up, so disabling interrupts is enough
|
|
|
|
* protection. This avoids the lockdep hell of lock ordering.
|
|
|
|
*/
|
|
|
|
local_irq_disable();
|
|
|
|
|
|
|
|
/* Remove the statically allocated objects from the pool */
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 02:06:00 +01:00
|
|
|
hlist_for_each_entry_safe(obj, tmp, &obj_pool, node)
|
2009-03-16 18:53:18 +01:00
|
|
|
hlist_del(&obj->node);
|
|
|
|
/* Move the allocated objects to the pool */
|
|
|
|
hlist_move_list(&objects, &obj_pool);
|
|
|
|
|
|
|
|
/* Replace the active object references */
|
|
|
|
for (i = 0; i < ODEBUG_HASH_SIZE; i++, db++) {
|
|
|
|
hlist_move_list(&db->list, &objects);
|
|
|
|
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 02:06:00 +01:00
|
|
|
hlist_for_each_entry(obj, &objects, node) {
|
2009-03-16 18:53:18 +01:00
|
|
|
new = hlist_entry(obj_pool.first, typeof(*obj), node);
|
|
|
|
hlist_del(&new->node);
|
|
|
|
/* copy object data */
|
|
|
|
*new = *obj;
|
|
|
|
hlist_add_head(&new->node, &db->list);
|
|
|
|
cnt++;
|
|
|
|
}
|
|
|
|
}
|
2012-04-11 11:54:27 +02:00
|
|
|
local_irq_enable();
|
2009-03-16 18:53:18 +01:00
|
|
|
|
|
|
|
printk(KERN_DEBUG "ODEBUG: %d of %d active objects replaced\n", cnt,
|
|
|
|
obj_pool_used);
|
|
|
|
return 0;
|
|
|
|
free:
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 02:06:00 +01:00
|
|
|
hlist_for_each_entry_safe(obj, tmp, &objects, node) {
|
2009-03-16 18:53:18 +01:00
|
|
|
hlist_del(&obj->node);
|
|
|
|
kmem_cache_free(obj_cache, obj);
|
|
|
|
}
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
|
2008-04-30 09:55:01 +02:00
|
|
|
/*
|
|
|
|
* Called after the kmem_caches are functional to setup a dedicated
|
|
|
|
* cache pool, which has the SLAB_DEBUG_OBJECTS flag set. This flag
|
|
|
|
* prevents that the debug code is called on kmem_cache_free() for the
|
|
|
|
* debug tracker objects to avoid recursive calls.
|
|
|
|
*/
|
|
|
|
void __init debug_objects_mem_init(void)
|
|
|
|
{
|
|
|
|
if (!debug_objects_enabled)
|
|
|
|
return;
|
|
|
|
|
|
|
|
obj_cache = kmem_cache_create("debug_objects_cache",
|
|
|
|
sizeof (struct debug_obj), 0,
|
|
|
|
SLAB_DEBUG_OBJECTS, NULL);
|
|
|
|
|
2009-03-16 18:53:18 +01:00
|
|
|
if (!obj_cache || debug_objects_replace_static_objects()) {
|
2008-04-30 09:55:01 +02:00
|
|
|
debug_objects_enabled = 0;
|
2009-03-16 18:53:18 +01:00
|
|
|
if (obj_cache)
|
|
|
|
kmem_cache_destroy(obj_cache);
|
2014-06-05 01:06:04 +02:00
|
|
|
pr_warn("out of memory.\n");
|
2009-03-16 18:53:18 +01:00
|
|
|
} else
|
2008-04-30 09:55:01 +02:00
|
|
|
debug_objects_selftest();
|
|
|
|
}
|