2019-06-04 10:11:33 +02:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-only
|
2007-07-27 15:43:23 +02:00
|
|
|
/*
|
|
|
|
* Copyright 2002-2005, Instant802 Networks, Inc.
|
|
|
|
* Copyright 2005-2006, Devicescape Software, Inc.
|
|
|
|
* Copyright 2006-2007 Jiri Benc <jbenc@suse.cz>
|
2008-04-08 17:56:52 +02:00
|
|
|
* Copyright 2007-2008 Johannes Berg <johannes@sipsolutions.net>
|
2014-09-03 14:24:57 +02:00
|
|
|
* Copyright 2013-2014 Intel Mobile Communications GmbH
|
2017-09-05 14:54:54 +02:00
|
|
|
* Copyright 2015-2017 Intel Deutschland GmbH
|
2007-07-27 15:43:23 +02:00
|
|
|
*/
|
|
|
|
|
2007-08-28 23:01:55 +02:00
|
|
|
#include <linux/if_ether.h>
|
|
|
|
#include <linux/etherdevice.h>
|
|
|
|
#include <linux/list.h>
|
[MAC80211]: fix race conditions with keys
During receive processing, we select the key long before using it and
because there's no locking it is possible that we kfree() the key
after having selected it but before using it for crypto operations.
Obviously, this is bad.
Secondly, during transmit processing, there are two possible races: We
have a similar race between select_key() and using it for encryption,
but we also have a race here between select_key() and hardware
encryption (both when a key is removed.)
This patch solves these issues by using RCU: when a key is to be freed,
we first remove the pointer from the appropriate places (sdata->keys,
sdata->default_key, sta->key) using rcu_assign_pointer() and then
synchronize_rcu(). Then, we can safely kfree() the key and remove it
from the hardware. There's a window here where the hardware may still
be using it for decryption, but we can't work around that without having
two hardware callbacks, one to disable the key for RX and one to disable
it for TX; but the worst thing that will happen is that we receive a
packet decrypted that we don't find a key for any more and then drop it.
When we add a key, we first need to upload it to the hardware and then,
using rcu_assign_pointer() again, link it into our structures.
In the code using keys (TX/RX paths) we use rcu_dereference() to get the
key and enclose the whole tx/rx section in a rcu_read_lock() ...
rcu_read_unlock() block. Because we've uploaded the key to hardware
before linking it into internal structures, we can guarantee that it is
valid once get to into tx().
One possible race condition remains, however: when we have hardware
acceleration enabled and the driver shuts down the queues, we end up
queueing the frame. If now somebody removes the key, the key will be
removed from hwaccel and then then driver will be asked to encrypt the
frame with a key index that has been removed. Hence, drivers will need
to be aware that the hw_key_index they are passed might not be under
all circumstances. Most drivers will, however, simply ignore that
condition and encrypt the frame with the selected key anyway, this
only results in a frame being encrypted with a wrong key or dropped
(rightfully) because the key was not valid. There isn't much we can
do about it unless we want to walk the pending frame queue every time
a key is removed and remove all frames that used it.
This race condition, however, will most likely be solved once we add
multiqueue support to mac80211 because then frames will be queued
further up the stack instead of after being processed.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Acked-by: Michael Wu <flamingice@sourmilk.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2007-09-14 17:10:24 +02:00
|
|
|
#include <linux/rcupdate.h>
|
2008-02-25 16:27:45 +01:00
|
|
|
#include <linux/rtnetlink.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 09:04:11 +01:00
|
|
|
#include <linux/slab.h>
|
2011-07-15 17:47:34 +02:00
|
|
|
#include <linux/export.h>
|
2007-07-27 15:43:23 +02:00
|
|
|
#include <net/mac80211.h>
|
2017-10-17 20:32:07 +02:00
|
|
|
#include <crypto/algapi.h>
|
2012-02-20 11:38:41 +01:00
|
|
|
#include <asm/unaligned.h>
|
2007-07-27 15:43:23 +02:00
|
|
|
#include "ieee80211_i.h"
|
2009-04-23 18:52:52 +02:00
|
|
|
#include "driver-ops.h"
|
2007-07-27 15:43:23 +02:00
|
|
|
#include "debugfs_key.h"
|
|
|
|
#include "aes_ccm.h"
|
2009-01-08 12:32:02 +01:00
|
|
|
#include "aes_cmac.h"
|
2015-01-24 18:52:09 +01:00
|
|
|
#include "aes_gmac.h"
|
2015-01-24 18:52:06 +01:00
|
|
|
#include "aes_gcm.h"
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2007-08-28 23:01:55 +02:00
|
|
|
|
2008-02-26 14:34:06 +01:00
|
|
|
/**
|
|
|
|
* DOC: Key handling basics
|
2007-08-28 23:01:55 +02:00
|
|
|
*
|
|
|
|
* Key handling in mac80211 is done based on per-interface (sub_if_data)
|
|
|
|
* keys and per-station keys. Since each station belongs to an interface,
|
|
|
|
* each station key also belongs to that interface.
|
|
|
|
*
|
2011-01-03 19:51:09 +01:00
|
|
|
* Hardware acceleration is done on a best-effort basis for algorithms
|
|
|
|
* that are implemented in software, for each key the hardware is asked
|
|
|
|
* to enable that key for offloading but if it cannot do that the key is
|
|
|
|
* simply kept for software encryption (unless it is for an algorithm
|
|
|
|
* that isn't implemented in software).
|
|
|
|
* There is currently no way of knowing whether a key is handled in SW
|
|
|
|
* or HW except by looking into debugfs.
|
2007-08-28 23:01:55 +02:00
|
|
|
*
|
2011-01-03 19:51:09 +01:00
|
|
|
* All key management is internally protected by a mutex. Within all
|
|
|
|
* other parts of mac80211, key references are, just as STA structure
|
|
|
|
* references, protected by RCU. Note, however, that some things are
|
|
|
|
* unprotected, namely the key->sta dereferences within the hardware
|
|
|
|
* acceleration functions. This means that sta_info_destroy() must
|
|
|
|
* remove the key which waits for an RCU grace period.
|
2007-08-28 23:01:55 +02:00
|
|
|
*/
|
|
|
|
|
|
|
|
static const u8 bcast_addr[ETH_ALEN] = { 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF };
|
|
|
|
|
2010-06-01 10:19:19 +02:00
|
|
|
static void assert_key_lock(struct ieee80211_local *local)
|
2008-04-08 17:56:52 +02:00
|
|
|
{
|
2010-09-15 13:28:15 +02:00
|
|
|
lockdep_assert_held(&local->key_mtx);
|
2008-04-08 17:56:52 +02:00
|
|
|
}
|
|
|
|
|
2015-05-13 11:16:48 +02:00
|
|
|
static void
|
|
|
|
update_vlan_tailroom_need_count(struct ieee80211_sub_if_data *sdata, int delta)
|
|
|
|
{
|
|
|
|
struct ieee80211_sub_if_data *vlan;
|
|
|
|
|
|
|
|
if (sdata->vif.type != NL80211_IFTYPE_AP)
|
|
|
|
return;
|
|
|
|
|
2015-06-17 13:54:54 +02:00
|
|
|
/* crypto_tx_tailroom_needed_cnt is protected by this */
|
|
|
|
assert_key_lock(sdata->local);
|
2015-05-13 11:16:48 +02:00
|
|
|
|
2015-06-17 13:54:54 +02:00
|
|
|
rcu_read_lock();
|
|
|
|
|
|
|
|
list_for_each_entry_rcu(vlan, &sdata->u.ap.vlans, u.vlan.list)
|
2015-05-13 11:16:48 +02:00
|
|
|
vlan->crypto_tx_tailroom_needed_cnt += delta;
|
|
|
|
|
2015-06-17 13:54:54 +02:00
|
|
|
rcu_read_unlock();
|
2015-05-13 11:16:48 +02:00
|
|
|
}
|
|
|
|
|
2011-06-28 15:11:37 +02:00
|
|
|
static void increment_tailroom_need_count(struct ieee80211_sub_if_data *sdata)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* When this count is zero, SKB resizing for allocating tailroom
|
|
|
|
* for IV or MMIC is skipped. But, this check has created two race
|
|
|
|
* cases in xmit path while transiting from zero count to one:
|
|
|
|
*
|
|
|
|
* 1. SKB resize was skipped because no key was added but just before
|
|
|
|
* the xmit key is added and SW encryption kicks off.
|
|
|
|
*
|
|
|
|
* 2. SKB resize was skipped because all the keys were hw planted but
|
|
|
|
* just before xmit one of the key is deleted and SW encryption kicks
|
|
|
|
* off.
|
|
|
|
*
|
|
|
|
* In both the above case SW encryption will find not enough space for
|
|
|
|
* tailroom and exits with WARN_ON. (See WARN_ONs at wpa.c)
|
|
|
|
*
|
|
|
|
* Solution has been explained at
|
|
|
|
* http://mid.gmane.org/1308590980.4322.19.camel@jlt3.sipsolutions.net
|
|
|
|
*/
|
|
|
|
|
2015-06-17 13:54:54 +02:00
|
|
|
assert_key_lock(sdata->local);
|
|
|
|
|
2015-05-13 11:16:48 +02:00
|
|
|
update_vlan_tailroom_need_count(sdata, 1);
|
|
|
|
|
2011-06-28 15:11:37 +02:00
|
|
|
if (!sdata->crypto_tx_tailroom_needed_cnt++) {
|
|
|
|
/*
|
|
|
|
* Flush all XMIT packets currently using HW encryption or no
|
|
|
|
* encryption at all if the count transition is from 0 -> 1.
|
|
|
|
*/
|
|
|
|
synchronize_net();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-05-13 11:16:48 +02:00
|
|
|
static void decrease_tailroom_need_count(struct ieee80211_sub_if_data *sdata,
|
|
|
|
int delta)
|
|
|
|
{
|
2015-06-17 13:54:54 +02:00
|
|
|
assert_key_lock(sdata->local);
|
|
|
|
|
2015-05-13 11:16:48 +02:00
|
|
|
WARN_ON_ONCE(sdata->crypto_tx_tailroom_needed_cnt < delta);
|
|
|
|
|
|
|
|
update_vlan_tailroom_need_count(sdata, -delta);
|
|
|
|
sdata->crypto_tx_tailroom_needed_cnt -= delta;
|
|
|
|
}
|
|
|
|
|
2010-08-27 13:26:52 +02:00
|
|
|
static int ieee80211_key_enable_hw_accel(struct ieee80211_key *key)
|
2007-08-28 23:01:55 +02:00
|
|
|
{
|
2018-03-28 15:04:19 +02:00
|
|
|
struct ieee80211_sub_if_data *sdata = key->sdata;
|
2012-01-20 13:55:19 +01:00
|
|
|
struct sta_info *sta;
|
2015-01-22 18:44:19 +01:00
|
|
|
int ret = -EOPNOTSUPP;
|
2007-08-28 23:01:55 +02:00
|
|
|
|
2008-04-08 17:56:52 +02:00
|
|
|
might_sleep();
|
|
|
|
|
2014-10-13 13:43:29 +02:00
|
|
|
if (key->flags & KEY_FLAG_TAINTED) {
|
|
|
|
/* If we get here, it's during resume and the key is
|
|
|
|
* tainted so shouldn't be used/programmed any more.
|
|
|
|
* However, its flags may still indicate that it was
|
|
|
|
* programmed into the device (since we're in resume)
|
|
|
|
* so clear that flag now to avoid trying to remove
|
|
|
|
* it again later.
|
|
|
|
*/
|
2019-03-16 21:44:43 +01:00
|
|
|
if (key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE &&
|
|
|
|
!(key->conf.flags & (IEEE80211_KEY_FLAG_GENERATE_MMIC |
|
|
|
|
IEEE80211_KEY_FLAG_PUT_MIC_SPACE |
|
|
|
|
IEEE80211_KEY_FLAG_RESERVE_TAILROOM)))
|
|
|
|
increment_tailroom_need_count(sdata);
|
|
|
|
|
2014-10-13 13:43:29 +02:00
|
|
|
key->flags &= ~KEY_FLAG_UPLOADED_TO_HARDWARE;
|
2013-08-07 20:11:55 +02:00
|
|
|
return -EINVAL;
|
2014-10-13 13:43:29 +02:00
|
|
|
}
|
2013-08-07 20:11:55 +02:00
|
|
|
|
2010-10-05 19:39:30 +02:00
|
|
|
if (!key->local->ops->set_key)
|
2010-08-27 13:26:52 +02:00
|
|
|
goto out_unsupported;
|
2007-08-28 23:01:55 +02:00
|
|
|
|
2010-06-01 10:19:19 +02:00
|
|
|
assert_key_lock(key->local);
|
|
|
|
|
2012-01-20 13:55:19 +01:00
|
|
|
sta = key->sta;
|
2008-12-29 12:55:09 +01:00
|
|
|
|
2010-10-05 19:39:30 +02:00
|
|
|
/*
|
|
|
|
* If this is a per-STA GTK, check if it
|
|
|
|
* is supported; if not, return.
|
|
|
|
*/
|
|
|
|
if (sta && !(key->conf.flags & IEEE80211_KEY_FLAG_PAIRWISE) &&
|
2015-06-02 21:39:54 +02:00
|
|
|
!ieee80211_hw_check(&key->local->hw, SUPPORTS_PER_STA_GTK))
|
2010-10-05 19:39:30 +02:00
|
|
|
goto out_unsupported;
|
|
|
|
|
2012-01-20 13:55:19 +01:00
|
|
|
if (sta && !sta->uploaded)
|
|
|
|
goto out_unsupported;
|
|
|
|
|
2010-11-19 08:11:01 +01:00
|
|
|
if (sdata->vif.type == NL80211_IFTYPE_AP_VLAN) {
|
|
|
|
/*
|
|
|
|
* The driver doesn't know anything about VLAN interfaces.
|
|
|
|
* Hence, don't send GTKs for VLAN interfaces to the driver.
|
|
|
|
*/
|
2019-02-09 15:01:38 +01:00
|
|
|
if (!(key->conf.flags & IEEE80211_KEY_FLAG_PAIRWISE)) {
|
|
|
|
ret = 1;
|
2010-11-19 08:11:01 +01:00
|
|
|
goto out_unsupported;
|
2019-02-09 15:01:38 +01:00
|
|
|
}
|
2010-11-19 08:11:01 +01:00
|
|
|
}
|
2007-08-28 23:01:55 +02:00
|
|
|
|
2012-01-20 13:55:19 +01:00
|
|
|
ret = drv_set_key(key->local, SET_KEY, sdata,
|
|
|
|
sta ? &sta->sta : NULL, &key->conf);
|
2007-08-28 23:01:55 +02:00
|
|
|
|
2010-10-05 19:39:30 +02:00
|
|
|
if (!ret) {
|
2007-08-28 23:01:55 +02:00
|
|
|
key->flags |= KEY_FLAG_UPLOADED_TO_HARDWARE;
|
2011-06-28 15:11:37 +02:00
|
|
|
|
2019-03-16 21:44:43 +01:00
|
|
|
if (!(key->conf.flags & (IEEE80211_KEY_FLAG_GENERATE_MMIC |
|
|
|
|
IEEE80211_KEY_FLAG_PUT_MIC_SPACE |
|
|
|
|
IEEE80211_KEY_FLAG_RESERVE_TAILROOM)))
|
2015-05-13 11:16:48 +02:00
|
|
|
decrease_tailroom_need_count(sdata, 1);
|
2011-06-28 15:11:37 +02:00
|
|
|
|
2011-10-23 08:21:41 +02:00
|
|
|
WARN_ON((key->conf.flags & IEEE80211_KEY_FLAG_PUT_IV_SPACE) &&
|
|
|
|
(key->conf.flags & IEEE80211_KEY_FLAG_GENERATE_IV));
|
|
|
|
|
2017-12-01 12:50:52 +01:00
|
|
|
WARN_ON((key->conf.flags & IEEE80211_KEY_FLAG_PUT_MIC_SPACE) &&
|
|
|
|
(key->conf.flags & IEEE80211_KEY_FLAG_GENERATE_MMIC));
|
|
|
|
|
2010-10-05 19:39:30 +02:00
|
|
|
return 0;
|
|
|
|
}
|
2007-08-28 23:01:55 +02:00
|
|
|
|
2015-01-22 18:44:19 +01:00
|
|
|
if (ret != -ENOSPC && ret != -EOPNOTSUPP && ret != 1)
|
2012-06-22 11:29:50 +02:00
|
|
|
sdata_err(sdata,
|
2010-08-21 01:25:38 +02:00
|
|
|
"failed to set key (%d, %pM) to hardware (%d)\n",
|
2012-01-20 13:55:19 +01:00
|
|
|
key->conf.keyidx,
|
|
|
|
sta ? sta->sta.addr : bcast_addr, ret);
|
2010-08-27 13:26:52 +02:00
|
|
|
|
2010-10-05 19:39:30 +02:00
|
|
|
out_unsupported:
|
|
|
|
switch (key->conf.cipher) {
|
|
|
|
case WLAN_CIPHER_SUITE_WEP40:
|
|
|
|
case WLAN_CIPHER_SUITE_WEP104:
|
|
|
|
case WLAN_CIPHER_SUITE_TKIP:
|
|
|
|
case WLAN_CIPHER_SUITE_CCMP:
|
2015-01-24 18:52:07 +01:00
|
|
|
case WLAN_CIPHER_SUITE_CCMP_256:
|
2010-10-05 19:39:30 +02:00
|
|
|
case WLAN_CIPHER_SUITE_AES_CMAC:
|
2015-01-24 18:52:08 +01:00
|
|
|
case WLAN_CIPHER_SUITE_BIP_CMAC_256:
|
2015-01-24 18:52:09 +01:00
|
|
|
case WLAN_CIPHER_SUITE_BIP_GMAC_128:
|
|
|
|
case WLAN_CIPHER_SUITE_BIP_GMAC_256:
|
2015-01-24 18:52:06 +01:00
|
|
|
case WLAN_CIPHER_SUITE_GCMP:
|
|
|
|
case WLAN_CIPHER_SUITE_GCMP_256:
|
2015-01-22 18:44:19 +01:00
|
|
|
/* all of these we can do in software - if driver can */
|
|
|
|
if (ret == 1)
|
|
|
|
return 0;
|
2019-02-09 15:01:38 +01:00
|
|
|
if (ieee80211_hw_check(&key->local->hw, SW_CRYPTO_CONTROL))
|
2015-01-22 18:44:19 +01:00
|
|
|
return -EINVAL;
|
2010-10-05 19:39:30 +02:00
|
|
|
return 0;
|
|
|
|
default:
|
|
|
|
return -EINVAL;
|
2010-08-27 13:26:52 +02:00
|
|
|
}
|
2007-08-28 23:01:55 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
static void ieee80211_key_disable_hw_accel(struct ieee80211_key *key)
|
|
|
|
{
|
2008-12-29 12:55:09 +01:00
|
|
|
struct ieee80211_sub_if_data *sdata;
|
2012-01-20 13:55:19 +01:00
|
|
|
struct sta_info *sta;
|
2007-08-28 23:01:55 +02:00
|
|
|
int ret;
|
|
|
|
|
2008-04-08 17:56:52 +02:00
|
|
|
might_sleep();
|
|
|
|
|
2008-02-25 16:27:45 +01:00
|
|
|
if (!key || !key->local->ops->set_key)
|
2007-08-28 23:01:55 +02:00
|
|
|
return;
|
|
|
|
|
2010-06-01 10:19:19 +02:00
|
|
|
assert_key_lock(key->local);
|
|
|
|
|
|
|
|
if (!(key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE))
|
2007-08-28 23:01:55 +02:00
|
|
|
return;
|
|
|
|
|
2012-01-20 13:55:19 +01:00
|
|
|
sta = key->sta;
|
2008-12-29 12:55:09 +01:00
|
|
|
sdata = key->sdata;
|
|
|
|
|
2019-03-16 21:44:43 +01:00
|
|
|
if (!(key->conf.flags & (IEEE80211_KEY_FLAG_GENERATE_MMIC |
|
|
|
|
IEEE80211_KEY_FLAG_PUT_MIC_SPACE |
|
|
|
|
IEEE80211_KEY_FLAG_RESERVE_TAILROOM)))
|
2011-06-28 15:11:37 +02:00
|
|
|
increment_tailroom_need_count(sdata);
|
|
|
|
|
2018-08-31 15:00:38 +02:00
|
|
|
key->flags &= ~KEY_FLAG_UPLOADED_TO_HARDWARE;
|
2009-11-25 20:30:31 +01:00
|
|
|
ret = drv_set_key(key->local, DISABLE_KEY, sdata,
|
2012-01-20 13:55:19 +01:00
|
|
|
sta ? &sta->sta : NULL, &key->conf);
|
2007-08-28 23:01:55 +02:00
|
|
|
|
|
|
|
if (ret)
|
2012-06-22 11:29:50 +02:00
|
|
|
sdata_err(sdata,
|
2010-08-21 01:25:38 +02:00
|
|
|
"failed to remove key (%d, %pM) from hardware (%d)\n",
|
2012-01-20 13:55:19 +01:00
|
|
|
key->conf.keyidx,
|
|
|
|
sta ? sta->sta.addr : bcast_addr, ret);
|
2018-08-31 15:00:38 +02:00
|
|
|
}
|
2007-08-28 23:01:55 +02:00
|
|
|
|
2019-03-19 21:34:08 +01:00
|
|
|
int ieee80211_set_tx_key(struct ieee80211_key *key)
|
|
|
|
{
|
|
|
|
struct sta_info *sta = key->sta;
|
|
|
|
struct ieee80211_local *local = key->local;
|
|
|
|
|
|
|
|
assert_key_lock(local);
|
|
|
|
|
|
|
|
sta->ptk_idx = key->conf.keyidx;
|
|
|
|
ieee80211_check_fast_xmit(sta);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2018-08-31 15:00:38 +02:00
|
|
|
static int ieee80211_hw_key_replace(struct ieee80211_key *old_key,
|
|
|
|
struct ieee80211_key *new_key,
|
2019-03-19 21:34:08 +01:00
|
|
|
bool pairwise)
|
2018-08-31 15:00:38 +02:00
|
|
|
{
|
|
|
|
struct ieee80211_sub_if_data *sdata;
|
|
|
|
struct ieee80211_local *local;
|
|
|
|
struct sta_info *sta;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
/* Aggregation sessions are OK when running on SW crypto.
|
|
|
|
* A broken remote STA may cause issues not observed with HW
|
|
|
|
* crypto, though.
|
|
|
|
*/
|
|
|
|
if (!(old_key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
assert_key_lock(old_key->local);
|
|
|
|
sta = old_key->sta;
|
|
|
|
|
2019-03-19 21:34:08 +01:00
|
|
|
/* Unicast rekey without Extended Key ID needs special handling */
|
|
|
|
if (new_key && sta && pairwise &&
|
|
|
|
rcu_access_pointer(sta->ptk[sta->ptk_idx]) == old_key) {
|
2018-08-31 15:00:38 +02:00
|
|
|
local = old_key->local;
|
|
|
|
sdata = old_key->sdata;
|
|
|
|
|
|
|
|
/* Stop TX till we are on the new key */
|
|
|
|
old_key->flags |= KEY_FLAG_TAINTED;
|
|
|
|
ieee80211_clear_fast_xmit(sta);
|
|
|
|
|
|
|
|
/* Aggregation sessions during rekey are complicated due to the
|
|
|
|
* reorder buffer and retransmits. Side step that by blocking
|
|
|
|
* aggregation during rekey and tear down running sessions.
|
|
|
|
*/
|
|
|
|
if (ieee80211_hw_check(&local->hw, AMPDU_AGGREGATION)) {
|
|
|
|
set_sta_flag(sta, WLAN_STA_BLOCK_BA);
|
|
|
|
ieee80211_sta_tear_down_BA_sessions(sta,
|
|
|
|
AGG_STOP_LOCAL_REQUEST);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!wiphy_ext_feature_isset(local->hw.wiphy,
|
|
|
|
NL80211_EXT_FEATURE_CAN_REPLACE_PTK0)) {
|
|
|
|
pr_warn_ratelimited("Rekeying PTK for STA %pM but driver can't safely do that.",
|
|
|
|
sta->sta.addr);
|
|
|
|
/* Flushing the driver queues *may* help prevent
|
|
|
|
* the clear text leaks and freezes.
|
|
|
|
*/
|
|
|
|
ieee80211_flush_queues(local, sdata, false);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
ieee80211_key_disable_hw_accel(old_key);
|
|
|
|
|
|
|
|
if (new_key)
|
|
|
|
ret = ieee80211_key_enable_hw_accel(new_key);
|
|
|
|
else
|
|
|
|
ret = 0;
|
|
|
|
|
|
|
|
return ret;
|
2008-04-08 17:56:52 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
static void __ieee80211_set_default_key(struct ieee80211_sub_if_data *sdata,
|
2010-12-09 19:49:02 +01:00
|
|
|
int idx, bool uni, bool multi)
|
2008-04-08 17:56:52 +02:00
|
|
|
{
|
|
|
|
struct ieee80211_key *key = NULL;
|
|
|
|
|
2010-06-01 10:19:19 +02:00
|
|
|
assert_key_lock(sdata->local);
|
|
|
|
|
2008-04-08 17:56:52 +02:00
|
|
|
if (idx >= 0 && idx < NUM_DEFAULT_KEYS)
|
2011-05-13 14:15:49 +02:00
|
|
|
key = key_mtx_dereference(sdata->local, sdata->keys[idx]);
|
2008-04-08 17:56:52 +02:00
|
|
|
|
2012-05-30 10:36:39 +02:00
|
|
|
if (uni) {
|
2010-12-09 19:49:02 +01:00
|
|
|
rcu_assign_pointer(sdata->default_unicast_key, key);
|
2015-03-21 15:25:43 +01:00
|
|
|
ieee80211_check_fast_xmit_iface(sdata);
|
2016-12-13 09:39:18 +01:00
|
|
|
if (sdata->vif.type != NL80211_IFTYPE_AP_VLAN)
|
|
|
|
drv_set_default_unicast_key(sdata->local, sdata, idx);
|
2012-05-30 10:36:39 +02:00
|
|
|
}
|
|
|
|
|
2010-12-09 19:49:02 +01:00
|
|
|
if (multi)
|
|
|
|
rcu_assign_pointer(sdata->default_multicast_key, key);
|
2008-04-08 17:56:52 +02:00
|
|
|
|
2010-12-09 19:49:02 +01:00
|
|
|
ieee80211_debugfs_key_update_default(sdata);
|
2008-04-08 17:56:52 +02:00
|
|
|
}
|
|
|
|
|
2010-12-09 19:49:02 +01:00
|
|
|
void ieee80211_set_default_key(struct ieee80211_sub_if_data *sdata, int idx,
|
|
|
|
bool uni, bool multi)
|
2008-04-08 17:56:52 +02:00
|
|
|
{
|
2010-06-01 10:19:19 +02:00
|
|
|
mutex_lock(&sdata->local->key_mtx);
|
2010-12-09 19:49:02 +01:00
|
|
|
__ieee80211_set_default_key(sdata, idx, uni, multi);
|
2010-06-01 10:19:19 +02:00
|
|
|
mutex_unlock(&sdata->local->key_mtx);
|
2008-04-08 17:56:52 +02:00
|
|
|
}
|
|
|
|
|
2009-01-08 12:32:02 +01:00
|
|
|
static void
|
|
|
|
__ieee80211_set_default_mgmt_key(struct ieee80211_sub_if_data *sdata, int idx)
|
|
|
|
{
|
|
|
|
struct ieee80211_key *key = NULL;
|
|
|
|
|
2010-06-01 10:19:19 +02:00
|
|
|
assert_key_lock(sdata->local);
|
|
|
|
|
2009-01-08 12:32:02 +01:00
|
|
|
if (idx >= NUM_DEFAULT_KEYS &&
|
|
|
|
idx < NUM_DEFAULT_KEYS + NUM_DEFAULT_MGMT_KEYS)
|
2011-05-13 14:15:49 +02:00
|
|
|
key = key_mtx_dereference(sdata->local, sdata->keys[idx]);
|
2009-01-08 12:32:02 +01:00
|
|
|
|
|
|
|
rcu_assign_pointer(sdata->default_mgmt_key, key);
|
|
|
|
|
2010-12-09 19:49:02 +01:00
|
|
|
ieee80211_debugfs_key_update_default(sdata);
|
2009-01-08 12:32:02 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
void ieee80211_set_default_mgmt_key(struct ieee80211_sub_if_data *sdata,
|
|
|
|
int idx)
|
|
|
|
{
|
2010-06-01 10:19:19 +02:00
|
|
|
mutex_lock(&sdata->local->key_mtx);
|
2009-01-08 12:32:02 +01:00
|
|
|
__ieee80211_set_default_mgmt_key(sdata, idx);
|
2010-06-01 10:19:19 +02:00
|
|
|
mutex_unlock(&sdata->local->key_mtx);
|
2009-01-08 12:32:02 +01:00
|
|
|
}
|
|
|
|
|
2008-04-08 17:56:52 +02:00
|
|
|
|
2018-08-31 15:00:38 +02:00
|
|
|
static int ieee80211_key_replace(struct ieee80211_sub_if_data *sdata,
|
2013-03-06 22:58:23 +01:00
|
|
|
struct sta_info *sta,
|
|
|
|
bool pairwise,
|
|
|
|
struct ieee80211_key *old,
|
|
|
|
struct ieee80211_key *new)
|
2008-04-08 17:56:52 +02:00
|
|
|
{
|
2010-12-09 19:49:02 +01:00
|
|
|
int idx;
|
2018-08-31 15:00:38 +02:00
|
|
|
int ret;
|
2010-12-09 19:49:02 +01:00
|
|
|
bool defunikey, defmultikey, defmgmtkey;
|
2008-04-08 17:56:52 +02:00
|
|
|
|
2013-10-29 10:00:08 +01:00
|
|
|
/* caller must provide at least one old/new */
|
|
|
|
if (WARN_ON(!new && !old))
|
2018-08-31 15:00:38 +02:00
|
|
|
return 0;
|
2013-10-29 10:00:08 +01:00
|
|
|
|
2008-04-08 17:56:52 +02:00
|
|
|
if (new)
|
2015-11-17 09:24:37 +01:00
|
|
|
list_add_tail_rcu(&new->list, &sdata->key_list);
|
2008-04-08 17:56:52 +02:00
|
|
|
|
2013-03-24 13:23:27 +01:00
|
|
|
WARN_ON(new && old && new->conf.keyidx != old->conf.keyidx);
|
2008-04-08 17:56:52 +02:00
|
|
|
|
2018-08-31 15:00:38 +02:00
|
|
|
if (old) {
|
2013-03-24 13:23:27 +01:00
|
|
|
idx = old->conf.keyidx;
|
2018-08-31 15:00:38 +02:00
|
|
|
ret = ieee80211_hw_key_replace(old, new, pairwise);
|
|
|
|
} else {
|
2018-09-04 15:20:01 +02:00
|
|
|
/* new must be provided in case old is not */
|
2013-03-24 13:23:27 +01:00
|
|
|
idx = new->conf.keyidx;
|
2018-09-04 15:20:01 +02:00
|
|
|
if (!new->local->wowlan)
|
2018-08-31 15:00:38 +02:00
|
|
|
ret = ieee80211_key_enable_hw_accel(new);
|
|
|
|
else
|
|
|
|
ret = 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
2008-04-08 17:56:52 +02:00
|
|
|
|
2013-03-24 13:23:27 +01:00
|
|
|
if (sta) {
|
|
|
|
if (pairwise) {
|
|
|
|
rcu_assign_pointer(sta->ptk[idx], new);
|
2019-03-19 21:34:08 +01:00
|
|
|
if (new &&
|
|
|
|
!(new->conf.flags & IEEE80211_KEY_FLAG_NO_AUTO_TX)) {
|
|
|
|
sta->ptk_idx = idx;
|
2018-08-31 15:00:38 +02:00
|
|
|
clear_sta_flag(sta, WLAN_STA_BLOCK_BA);
|
|
|
|
ieee80211_check_fast_xmit(sta);
|
|
|
|
}
|
2013-03-24 13:23:27 +01:00
|
|
|
} else {
|
|
|
|
rcu_assign_pointer(sta->gtk[idx], new);
|
|
|
|
}
|
2019-03-19 21:34:08 +01:00
|
|
|
/* Only needed for transition from no key -> key.
|
|
|
|
* Still triggers unnecessary when using Extended Key ID
|
|
|
|
* and installing the second key ID the first time.
|
|
|
|
*/
|
|
|
|
if (new && !old)
|
2018-08-31 15:00:38 +02:00
|
|
|
ieee80211_check_fast_rx(sta);
|
2013-03-24 13:23:27 +01:00
|
|
|
} else {
|
2011-05-13 14:15:49 +02:00
|
|
|
defunikey = old &&
|
|
|
|
old == key_mtx_dereference(sdata->local,
|
|
|
|
sdata->default_unicast_key);
|
|
|
|
defmultikey = old &&
|
|
|
|
old == key_mtx_dereference(sdata->local,
|
|
|
|
sdata->default_multicast_key);
|
|
|
|
defmgmtkey = old &&
|
|
|
|
old == key_mtx_dereference(sdata->local,
|
|
|
|
sdata->default_mgmt_key);
|
2008-04-08 17:56:52 +02:00
|
|
|
|
2010-12-09 19:49:02 +01:00
|
|
|
if (defunikey && !new)
|
|
|
|
__ieee80211_set_default_key(sdata, -1, true, false);
|
|
|
|
if (defmultikey && !new)
|
|
|
|
__ieee80211_set_default_key(sdata, -1, false, true);
|
2009-01-08 12:32:02 +01:00
|
|
|
if (defmgmtkey && !new)
|
|
|
|
__ieee80211_set_default_mgmt_key(sdata, -1);
|
2008-04-08 17:56:52 +02:00
|
|
|
|
|
|
|
rcu_assign_pointer(sdata->keys[idx], new);
|
2010-12-09 19:49:02 +01:00
|
|
|
if (defunikey && new)
|
|
|
|
__ieee80211_set_default_key(sdata, new->conf.keyidx,
|
|
|
|
true, false);
|
|
|
|
if (defmultikey && new)
|
|
|
|
__ieee80211_set_default_key(sdata, new->conf.keyidx,
|
|
|
|
false, true);
|
2009-01-08 12:32:02 +01:00
|
|
|
if (defmgmtkey && new)
|
|
|
|
__ieee80211_set_default_mgmt_key(sdata,
|
|
|
|
new->conf.keyidx);
|
2008-04-08 17:56:52 +02:00
|
|
|
}
|
|
|
|
|
2011-01-03 19:51:09 +01:00
|
|
|
if (old)
|
2015-11-17 09:24:37 +01:00
|
|
|
list_del_rcu(&old->list);
|
2018-08-31 15:00:38 +02:00
|
|
|
|
|
|
|
return 0;
|
2007-08-28 23:01:55 +02:00
|
|
|
}
|
|
|
|
|
2013-03-24 13:23:27 +01:00
|
|
|
struct ieee80211_key *
|
|
|
|
ieee80211_key_alloc(u32 cipher, int idx, size_t key_len,
|
|
|
|
const u8 *key_data,
|
|
|
|
size_t seq_len, const u8 *seq,
|
|
|
|
const struct ieee80211_cipher_scheme *cs)
|
2007-07-27 15:43:23 +02:00
|
|
|
{
|
|
|
|
struct ieee80211_key *key;
|
2010-08-01 18:37:03 +02:00
|
|
|
int i, j, err;
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2014-04-29 17:55:26 +02:00
|
|
|
if (WARN_ON(idx < 0 || idx >= NUM_DEFAULT_KEYS + NUM_DEFAULT_MGMT_KEYS))
|
|
|
|
return ERR_PTR(-EINVAL);
|
2007-08-28 23:01:55 +02:00
|
|
|
|
|
|
|
key = kzalloc(sizeof(struct ieee80211_key) + key_len, GFP_KERNEL);
|
2007-07-27 15:43:23 +02:00
|
|
|
if (!key)
|
2010-08-01 18:37:03 +02:00
|
|
|
return ERR_PTR(-ENOMEM);
|
2007-08-28 23:01:55 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Default to software encryption; we'll later upload the
|
|
|
|
* key to the hardware if possible.
|
|
|
|
*/
|
|
|
|
key->conf.flags = 0;
|
|
|
|
key->flags = 0;
|
|
|
|
|
2010-08-10 09:46:38 +02:00
|
|
|
key->conf.cipher = cipher;
|
2007-08-28 23:01:55 +02:00
|
|
|
key->conf.keyidx = idx;
|
|
|
|
key->conf.keylen = key_len;
|
2010-08-10 09:46:38 +02:00
|
|
|
switch (cipher) {
|
|
|
|
case WLAN_CIPHER_SUITE_WEP40:
|
|
|
|
case WLAN_CIPHER_SUITE_WEP104:
|
2013-05-08 13:09:08 +02:00
|
|
|
key->conf.iv_len = IEEE80211_WEP_IV_LEN;
|
|
|
|
key->conf.icv_len = IEEE80211_WEP_ICV_LEN;
|
2008-10-05 18:02:48 +02:00
|
|
|
break;
|
2010-08-10 09:46:38 +02:00
|
|
|
case WLAN_CIPHER_SUITE_TKIP:
|
2013-05-08 13:09:08 +02:00
|
|
|
key->conf.iv_len = IEEE80211_TKIP_IV_LEN;
|
|
|
|
key->conf.icv_len = IEEE80211_TKIP_ICV_LEN;
|
2009-05-15 11:38:32 +02:00
|
|
|
if (seq) {
|
2012-11-14 23:22:21 +01:00
|
|
|
for (i = 0; i < IEEE80211_NUM_TIDS; i++) {
|
2009-05-11 20:57:58 +02:00
|
|
|
key->u.tkip.rx[i].iv32 =
|
|
|
|
get_unaligned_le32(&seq[2]);
|
|
|
|
key->u.tkip.rx[i].iv16 =
|
|
|
|
get_unaligned_le16(seq);
|
|
|
|
}
|
|
|
|
}
|
mac80211: fix TKIP races, make API easier to use
Our current TKIP code races against itself on TX
since we can process multiple packets at the same
time on different ACs, but they all share the TX
context for TKIP. This can lead to bad IVs etc.
Also, the crypto offload helper code just obtains
the P1K/P2K from the cache, and can update it as
well, but there's no guarantee that packets are
really processed in order.
To fix these issues, first introduce a spinlock
that will protect the IV16/IV32 values in the TX
context. This first step makes sure that we don't
assign the same IV multiple times or get confused
in other ways.
Secondly, change the way the P1K cache works. I
add a field "p1k_iv32" that stores the value of
the IV32 when the P1K was last recomputed, and
if different from the last time, then a new P1K
is recomputed. This can cause the P1K computation
to flip back and forth if packets are processed
out of order. All this also happens under the new
spinlock.
Finally, because there are argument differences,
split up the ieee80211_get_tkip_key() API into
ieee80211_get_tkip_p1k() and ieee80211_get_tkip_p2k()
and give them the correct arguments.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2011-07-07 22:28:01 +02:00
|
|
|
spin_lock_init(&key->u.tkip.txlock);
|
2008-10-05 18:02:48 +02:00
|
|
|
break;
|
2010-08-10 09:46:38 +02:00
|
|
|
case WLAN_CIPHER_SUITE_CCMP:
|
2013-05-08 13:09:08 +02:00
|
|
|
key->conf.iv_len = IEEE80211_CCMP_HDR_LEN;
|
|
|
|
key->conf.icv_len = IEEE80211_CCMP_MIC_LEN;
|
2009-05-15 11:38:32 +02:00
|
|
|
if (seq) {
|
2012-11-14 23:22:21 +01:00
|
|
|
for (i = 0; i < IEEE80211_NUM_TIDS + 1; i++)
|
2013-05-08 13:09:08 +02:00
|
|
|
for (j = 0; j < IEEE80211_CCMP_PN_LEN; j++)
|
2009-05-11 20:57:58 +02:00
|
|
|
key->u.ccmp.rx_pn[i][j] =
|
2013-05-08 13:09:08 +02:00
|
|
|
seq[IEEE80211_CCMP_PN_LEN - j - 1];
|
2009-05-11 20:57:58 +02:00
|
|
|
}
|
2007-08-28 23:01:55 +02:00
|
|
|
/*
|
|
|
|
* Initialize AES key state here as an optimization so that
|
|
|
|
* it does not need to be initialized for every packet.
|
|
|
|
*/
|
2015-01-24 18:52:07 +01:00
|
|
|
key->u.ccmp.tfm = ieee80211_aes_key_setup_encrypt(
|
|
|
|
key_data, key_len, IEEE80211_CCMP_MIC_LEN);
|
|
|
|
if (IS_ERR(key->u.ccmp.tfm)) {
|
|
|
|
err = PTR_ERR(key->u.ccmp.tfm);
|
|
|
|
kfree(key);
|
|
|
|
return ERR_PTR(err);
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case WLAN_CIPHER_SUITE_CCMP_256:
|
|
|
|
key->conf.iv_len = IEEE80211_CCMP_256_HDR_LEN;
|
|
|
|
key->conf.icv_len = IEEE80211_CCMP_256_MIC_LEN;
|
|
|
|
for (i = 0; seq && i < IEEE80211_NUM_TIDS + 1; i++)
|
|
|
|
for (j = 0; j < IEEE80211_CCMP_256_PN_LEN; j++)
|
|
|
|
key->u.ccmp.rx_pn[i][j] =
|
|
|
|
seq[IEEE80211_CCMP_256_PN_LEN - j - 1];
|
|
|
|
/* Initialize AES key state here as an optimization so that
|
|
|
|
* it does not need to be initialized for every packet.
|
|
|
|
*/
|
|
|
|
key->u.ccmp.tfm = ieee80211_aes_key_setup_encrypt(
|
|
|
|
key_data, key_len, IEEE80211_CCMP_256_MIC_LEN);
|
2010-08-01 18:37:03 +02:00
|
|
|
if (IS_ERR(key->u.ccmp.tfm)) {
|
|
|
|
err = PTR_ERR(key->u.ccmp.tfm);
|
2008-04-08 17:56:52 +02:00
|
|
|
kfree(key);
|
2011-03-27 13:31:26 +02:00
|
|
|
return ERR_PTR(err);
|
2007-08-28 23:01:55 +02:00
|
|
|
}
|
2010-08-10 09:46:39 +02:00
|
|
|
break;
|
|
|
|
case WLAN_CIPHER_SUITE_AES_CMAC:
|
2015-01-24 18:52:08 +01:00
|
|
|
case WLAN_CIPHER_SUITE_BIP_CMAC_256:
|
2010-08-10 09:46:39 +02:00
|
|
|
key->conf.iv_len = 0;
|
2015-01-24 18:52:08 +01:00
|
|
|
if (cipher == WLAN_CIPHER_SUITE_AES_CMAC)
|
|
|
|
key->conf.icv_len = sizeof(struct ieee80211_mmie);
|
|
|
|
else
|
|
|
|
key->conf.icv_len = sizeof(struct ieee80211_mmie_16);
|
2010-08-10 09:46:39 +02:00
|
|
|
if (seq)
|
2013-05-08 13:09:08 +02:00
|
|
|
for (j = 0; j < IEEE80211_CMAC_PN_LEN; j++)
|
2012-11-14 23:15:11 +01:00
|
|
|
key->u.aes_cmac.rx_pn[j] =
|
2013-05-08 13:09:08 +02:00
|
|
|
seq[IEEE80211_CMAC_PN_LEN - j - 1];
|
2009-01-08 12:32:02 +01:00
|
|
|
/*
|
|
|
|
* Initialize AES key state here as an optimization so that
|
|
|
|
* it does not need to be initialized for every packet.
|
|
|
|
*/
|
|
|
|
key->u.aes_cmac.tfm =
|
2015-01-24 18:52:08 +01:00
|
|
|
ieee80211_aes_cmac_key_setup(key_data, key_len);
|
2010-08-01 18:37:03 +02:00
|
|
|
if (IS_ERR(key->u.aes_cmac.tfm)) {
|
|
|
|
err = PTR_ERR(key->u.aes_cmac.tfm);
|
2009-01-08 12:32:02 +01:00
|
|
|
kfree(key);
|
2011-03-27 13:31:26 +02:00
|
|
|
return ERR_PTR(err);
|
2009-01-08 12:32:02 +01:00
|
|
|
}
|
2010-08-10 09:46:39 +02:00
|
|
|
break;
|
2015-01-24 18:52:09 +01:00
|
|
|
case WLAN_CIPHER_SUITE_BIP_GMAC_128:
|
|
|
|
case WLAN_CIPHER_SUITE_BIP_GMAC_256:
|
|
|
|
key->conf.iv_len = 0;
|
|
|
|
key->conf.icv_len = sizeof(struct ieee80211_mmie_16);
|
|
|
|
if (seq)
|
|
|
|
for (j = 0; j < IEEE80211_GMAC_PN_LEN; j++)
|
|
|
|
key->u.aes_gmac.rx_pn[j] =
|
|
|
|
seq[IEEE80211_GMAC_PN_LEN - j - 1];
|
|
|
|
/* Initialize AES key state here as an optimization so that
|
|
|
|
* it does not need to be initialized for every packet.
|
|
|
|
*/
|
|
|
|
key->u.aes_gmac.tfm =
|
|
|
|
ieee80211_aes_gmac_key_setup(key_data, key_len);
|
|
|
|
if (IS_ERR(key->u.aes_gmac.tfm)) {
|
|
|
|
err = PTR_ERR(key->u.aes_gmac.tfm);
|
|
|
|
kfree(key);
|
|
|
|
return ERR_PTR(err);
|
|
|
|
}
|
|
|
|
break;
|
2015-01-24 18:52:06 +01:00
|
|
|
case WLAN_CIPHER_SUITE_GCMP:
|
|
|
|
case WLAN_CIPHER_SUITE_GCMP_256:
|
|
|
|
key->conf.iv_len = IEEE80211_GCMP_HDR_LEN;
|
|
|
|
key->conf.icv_len = IEEE80211_GCMP_MIC_LEN;
|
|
|
|
for (i = 0; seq && i < IEEE80211_NUM_TIDS + 1; i++)
|
|
|
|
for (j = 0; j < IEEE80211_GCMP_PN_LEN; j++)
|
|
|
|
key->u.gcmp.rx_pn[i][j] =
|
|
|
|
seq[IEEE80211_GCMP_PN_LEN - j - 1];
|
|
|
|
/* Initialize AES key state here as an optimization so that
|
|
|
|
* it does not need to be initialized for every packet.
|
|
|
|
*/
|
|
|
|
key->u.gcmp.tfm = ieee80211_aes_gcm_key_setup_encrypt(key_data,
|
|
|
|
key_len);
|
|
|
|
if (IS_ERR(key->u.gcmp.tfm)) {
|
|
|
|
err = PTR_ERR(key->u.gcmp.tfm);
|
|
|
|
kfree(key);
|
|
|
|
return ERR_PTR(err);
|
|
|
|
}
|
|
|
|
break;
|
2013-03-24 13:23:27 +01:00
|
|
|
default:
|
|
|
|
if (cs) {
|
2015-05-05 16:32:29 +02:00
|
|
|
if (seq_len && seq_len != cs->pn_len) {
|
|
|
|
kfree(key);
|
|
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
}
|
2013-03-24 13:23:27 +01:00
|
|
|
|
|
|
|
key->conf.iv_len = cs->hdr_len;
|
|
|
|
key->conf.icv_len = cs->mic_len;
|
|
|
|
for (i = 0; i < IEEE80211_NUM_TIDS + 1; i++)
|
2015-05-05 16:32:29 +02:00
|
|
|
for (j = 0; j < seq_len; j++)
|
2013-03-24 13:23:27 +01:00
|
|
|
key->u.gen.rx_pn[i][j] =
|
2015-05-05 16:32:29 +02:00
|
|
|
seq[seq_len - j - 1];
|
2015-03-17 11:47:33 +01:00
|
|
|
key->flags |= KEY_FLAG_CIPHER_SCHEME;
|
2013-03-24 13:23:27 +01:00
|
|
|
}
|
2009-01-08 12:32:02 +01:00
|
|
|
}
|
2010-08-10 09:46:39 +02:00
|
|
|
memcpy(key->conf.key, key_data, key_len);
|
|
|
|
INIT_LIST_HEAD(&key->list);
|
2009-01-08 12:32:02 +01:00
|
|
|
|
2008-02-25 16:27:45 +01:00
|
|
|
return key;
|
|
|
|
}
|
2007-08-28 23:01:55 +02:00
|
|
|
|
2013-03-06 22:53:52 +01:00
|
|
|
static void ieee80211_key_free_common(struct ieee80211_key *key)
|
|
|
|
{
|
2015-01-24 18:52:06 +01:00
|
|
|
switch (key->conf.cipher) {
|
|
|
|
case WLAN_CIPHER_SUITE_CCMP:
|
2015-01-24 18:52:07 +01:00
|
|
|
case WLAN_CIPHER_SUITE_CCMP_256:
|
2013-03-06 22:53:52 +01:00
|
|
|
ieee80211_aes_key_free(key->u.ccmp.tfm);
|
2015-01-24 18:52:06 +01:00
|
|
|
break;
|
|
|
|
case WLAN_CIPHER_SUITE_AES_CMAC:
|
2015-01-24 18:52:08 +01:00
|
|
|
case WLAN_CIPHER_SUITE_BIP_CMAC_256:
|
2013-03-06 22:53:52 +01:00
|
|
|
ieee80211_aes_cmac_key_free(key->u.aes_cmac.tfm);
|
2015-01-24 18:52:06 +01:00
|
|
|
break;
|
2015-01-24 18:52:09 +01:00
|
|
|
case WLAN_CIPHER_SUITE_BIP_GMAC_128:
|
|
|
|
case WLAN_CIPHER_SUITE_BIP_GMAC_256:
|
|
|
|
ieee80211_aes_gmac_key_free(key->u.aes_gmac.tfm);
|
|
|
|
break;
|
2015-01-24 18:52:06 +01:00
|
|
|
case WLAN_CIPHER_SUITE_GCMP:
|
|
|
|
case WLAN_CIPHER_SUITE_GCMP_256:
|
|
|
|
ieee80211_aes_gcm_key_free(key->u.gcmp.tfm);
|
|
|
|
break;
|
|
|
|
}
|
2014-09-10 12:39:55 +02:00
|
|
|
kzfree(key);
|
2013-03-06 22:53:52 +01:00
|
|
|
}
|
|
|
|
|
2013-03-06 23:09:11 +01:00
|
|
|
static void __ieee80211_key_destroy(struct ieee80211_key *key,
|
|
|
|
bool delay_tailroom)
|
2010-06-01 10:19:19 +02:00
|
|
|
{
|
2011-06-28 15:11:37 +02:00
|
|
|
if (key->local) {
|
mac80211: defer tailroom counter manipulation when roaming
During roaming, the crypto_tx_tailroom_needed_cnt counter
will often take values 2,1,0,1,2 because first keys are
removed and then new keys are added. This is inefficient
because during the 0->1 transition, synchronize_net must
be called to avoid packet races, although typically no
packets would be flowing during that time.
To avoid that, defer the decrement (2->1, 1->0) when keys
are removed (by half a second). This means the counter
will really have the values 2,2,2,3,4 ... 2, thus never
reaching 0 and having to do the 0->1 transition.
Note that this patch entirely disregards the drivers for
which this optimisation was done to start with, for them
the key removal itself will be expensive because it has
to synchronize_net() after the counter is incremented to
remove the key from HW crypto. For them the sequence will
look like this: 0,1,0,1,0,1,0,1,0 (*) which is clearly a
lot more inefficient. This could be addressed separately,
during key removal the 0->1->0 sequence isn't necessary.
(*) it starts at 0 because HW crypto is on, then goes to
1 when HW crypto is disabled for a key, then back to
0 because the key is deleted; this happens for both
keys in the example. When new keys are added, it goes
to 1 first because they're added in software; when a
key is moved to hardware it goes back to 0
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2013-02-23 00:59:03 +01:00
|
|
|
struct ieee80211_sub_if_data *sdata = key->sdata;
|
|
|
|
|
2010-07-27 00:52:03 +02:00
|
|
|
ieee80211_debugfs_key_remove(key);
|
mac80211: defer tailroom counter manipulation when roaming
During roaming, the crypto_tx_tailroom_needed_cnt counter
will often take values 2,1,0,1,2 because first keys are
removed and then new keys are added. This is inefficient
because during the 0->1 transition, synchronize_net must
be called to avoid packet races, although typically no
packets would be flowing during that time.
To avoid that, defer the decrement (2->1, 1->0) when keys
are removed (by half a second). This means the counter
will really have the values 2,2,2,3,4 ... 2, thus never
reaching 0 and having to do the 0->1 transition.
Note that this patch entirely disregards the drivers for
which this optimisation was done to start with, for them
the key removal itself will be expensive because it has
to synchronize_net() after the counter is incremented to
remove the key from HW crypto. For them the sequence will
look like this: 0,1,0,1,0,1,0,1,0 (*) which is clearly a
lot more inefficient. This could be addressed separately,
during key removal the 0->1->0 sequence isn't necessary.
(*) it starts at 0 because HW crypto is on, then goes to
1 when HW crypto is disabled for a key, then back to
0 because the key is deleted; this happens for both
keys in the example. When new keys are added, it goes
to 1 first because they're added in software; when a
key is moved to hardware it goes back to 0
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2013-02-23 00:59:03 +01:00
|
|
|
|
|
|
|
if (delay_tailroom) {
|
|
|
|
/* see ieee80211_delayed_tailroom_dec */
|
|
|
|
sdata->crypto_tx_tailroom_pending_dec++;
|
|
|
|
schedule_delayed_work(&sdata->dec_tailroom_needed_wk,
|
|
|
|
HZ/2);
|
|
|
|
} else {
|
2015-05-13 11:16:48 +02:00
|
|
|
decrease_tailroom_need_count(sdata, 1);
|
mac80211: defer tailroom counter manipulation when roaming
During roaming, the crypto_tx_tailroom_needed_cnt counter
will often take values 2,1,0,1,2 because first keys are
removed and then new keys are added. This is inefficient
because during the 0->1 transition, synchronize_net must
be called to avoid packet races, although typically no
packets would be flowing during that time.
To avoid that, defer the decrement (2->1, 1->0) when keys
are removed (by half a second). This means the counter
will really have the values 2,2,2,3,4 ... 2, thus never
reaching 0 and having to do the 0->1 transition.
Note that this patch entirely disregards the drivers for
which this optimisation was done to start with, for them
the key removal itself will be expensive because it has
to synchronize_net() after the counter is incremented to
remove the key from HW crypto. For them the sequence will
look like this: 0,1,0,1,0,1,0,1,0 (*) which is clearly a
lot more inefficient. This could be addressed separately,
during key removal the 0->1->0 sequence isn't necessary.
(*) it starts at 0 because HW crypto is on, then goes to
1 when HW crypto is disabled for a key, then back to
0 because the key is deleted; this happens for both
keys in the example. When new keys are added, it goes
to 1 first because they're added in software; when a
key is moved to hardware it goes back to 0
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2013-02-23 00:59:03 +01:00
|
|
|
}
|
2011-06-28 15:11:37 +02:00
|
|
|
}
|
2010-06-01 10:19:19 +02:00
|
|
|
|
2013-03-06 22:53:52 +01:00
|
|
|
ieee80211_key_free_common(key);
|
|
|
|
}
|
|
|
|
|
2013-03-06 23:09:11 +01:00
|
|
|
static void ieee80211_key_destroy(struct ieee80211_key *key,
|
|
|
|
bool delay_tailroom)
|
|
|
|
{
|
|
|
|
if (!key)
|
|
|
|
return;
|
|
|
|
|
|
|
|
/*
|
2015-11-17 09:24:37 +01:00
|
|
|
* Synchronize so the TX path and rcu key iterators
|
|
|
|
* can no longer be using this key before we free/remove it.
|
2013-03-06 23:09:11 +01:00
|
|
|
*/
|
|
|
|
synchronize_net();
|
|
|
|
|
|
|
|
__ieee80211_key_destroy(key, delay_tailroom);
|
|
|
|
}
|
|
|
|
|
2013-03-06 22:53:52 +01:00
|
|
|
void ieee80211_key_free_unused(struct ieee80211_key *key)
|
|
|
|
{
|
|
|
|
WARN_ON(key->sdata || key->local);
|
|
|
|
ieee80211_key_free_common(key);
|
2010-06-01 10:19:19 +02:00
|
|
|
}
|
|
|
|
|
2017-10-24 21:12:13 +02:00
|
|
|
static bool ieee80211_key_identical(struct ieee80211_sub_if_data *sdata,
|
|
|
|
struct ieee80211_key *old,
|
|
|
|
struct ieee80211_key *new)
|
|
|
|
{
|
|
|
|
u8 tkip_old[WLAN_KEY_LEN_TKIP], tkip_new[WLAN_KEY_LEN_TKIP];
|
|
|
|
u8 *tk_old, *tk_new;
|
|
|
|
|
|
|
|
if (!old || new->conf.keylen != old->conf.keylen)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
tk_old = old->conf.key;
|
|
|
|
tk_new = new->conf.key;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* In station mode, don't compare the TX MIC key, as it's never used
|
|
|
|
* and offloaded rekeying may not care to send it to the host. This
|
|
|
|
* is the case in iwlwifi, for example.
|
|
|
|
*/
|
|
|
|
if (sdata->vif.type == NL80211_IFTYPE_STATION &&
|
|
|
|
new->conf.cipher == WLAN_CIPHER_SUITE_TKIP &&
|
|
|
|
new->conf.keylen == WLAN_KEY_LEN_TKIP &&
|
|
|
|
!(new->conf.flags & IEEE80211_KEY_FLAG_PAIRWISE)) {
|
|
|
|
memcpy(tkip_old, tk_old, WLAN_KEY_LEN_TKIP);
|
|
|
|
memcpy(tkip_new, tk_new, WLAN_KEY_LEN_TKIP);
|
|
|
|
memset(tkip_old + NL80211_TKIP_DATA_OFFSET_TX_MIC_KEY, 0, 8);
|
|
|
|
memset(tkip_new + NL80211_TKIP_DATA_OFFSET_TX_MIC_KEY, 0, 8);
|
|
|
|
tk_old = tkip_old;
|
|
|
|
tk_new = tkip_new;
|
|
|
|
}
|
|
|
|
|
|
|
|
return !crypto_memneq(tk_old, tk_new, new->conf.keylen);
|
|
|
|
}
|
|
|
|
|
2010-08-27 13:26:52 +02:00
|
|
|
int ieee80211_key_link(struct ieee80211_key *key,
|
|
|
|
struct ieee80211_sub_if_data *sdata,
|
|
|
|
struct sta_info *sta)
|
2008-02-25 16:27:45 +01:00
|
|
|
{
|
|
|
|
struct ieee80211_key *old_key;
|
mac80211: restrict delayed tailroom needed decrement
As explained in ieee80211_delayed_tailroom_dec(), during roam,
keys of the old AP will be destroyed and new keys will be
installed. Deletion of the old key causes
crypto_tx_tailroom_needed_cnt to go from 1 to 0 and the new key
installation causes a transition from 0 to 1.
Whenever crypto_tx_tailroom_needed_cnt transitions from 0 to 1,
we invoke synchronize_net(); the reason for doing this is to avoid
a race in the TX path as explained in increment_tailroom_need_count().
This synchronize_net() operation can be slow and can affect the station
roam time. To avoid this, decrementing the crypto_tx_tailroom_needed_cnt
is delayed for a while so that upon installation of new key the
transition would be from 1 to 2 instead of 0 to 1 and thereby
improving the roam time.
This is all correct for a STA iftype, but deferring the tailroom_needed
decrement for other iftypes may be unnecessary.
For example, let's consider the case of a 4-addr client connecting to
an AP for which AP_VLAN interface is also created, let the initial
value for tailroom_needed on the AP be 1.
* 4-addr client connects to the AP (AP: tailroom_needed = 1)
* AP will clear old keys, delay decrement of tailroom_needed count
* AP_VLAN is created, it takes the tailroom count from master
(AP_VLAN: tailroom_needed = 1, AP: tailroom_needed = 1)
* Install new key for the station, assume key is plumbed in the HW,
there won't be any change in tailroom_needed count on AP iface
* Delayed decrement of tailroom_needed count on AP
(AP: tailroom_needed = 0, AP_VLAN: tailroom_needed = 1)
Because of the delayed decrement on AP iface, tailroom_needed count goes
out of sync between AP(master iface) and AP_VLAN(slave iface) and
there would be unnecessary tailroom created for the packets going
through AP_VLAN iface.
Also, WARN_ONs were observed while trying to bring down the AP_VLAN
interface:
(warn_slowpath_common) (warn_slowpath_null+0x18/0x20)
(warn_slowpath_null) (ieee80211_free_keys+0x114/0x1e4)
(ieee80211_free_keys) (ieee80211_del_virtual_monitor+0x51c/0x850)
(ieee80211_del_virtual_monitor) (ieee80211_stop+0x30/0x3c)
(ieee80211_stop) (__dev_close_many+0x94/0xb8)
(__dev_close_many) (dev_close_many+0x5c/0xc8)
Restricting delayed decrement to station interface alone fixes the problem
and it makes sense to do so because delayed decrement is done to improve
roam time which is applicable only for client devices.
Signed-off-by: Manikanta Pubbisetty <mpubbise@codeaurora.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2018-07-10 13:18:27 +02:00
|
|
|
int idx = key->conf.keyidx;
|
|
|
|
bool pairwise = key->conf.flags & IEEE80211_KEY_FLAG_PAIRWISE;
|
|
|
|
/*
|
|
|
|
* We want to delay tailroom updates only for station - in that
|
|
|
|
* case it helps roaming speed, but in other cases it hurts and
|
|
|
|
* can cause warnings to appear.
|
|
|
|
*/
|
|
|
|
bool delay_tailroom = sdata->vif.type == NL80211_IFTYPE_STATION;
|
2019-03-19 21:34:08 +01:00
|
|
|
int ret = -EOPNOTSUPP;
|
2008-02-25 16:27:45 +01:00
|
|
|
|
2010-06-01 10:19:19 +02:00
|
|
|
mutex_lock(&sdata->local->key_mtx);
|
2008-04-08 17:56:52 +02:00
|
|
|
|
2019-03-19 21:34:08 +01:00
|
|
|
if (sta && pairwise) {
|
|
|
|
struct ieee80211_key *alt_key;
|
|
|
|
|
2013-03-24 13:23:27 +01:00
|
|
|
old_key = key_mtx_dereference(sdata->local, sta->ptk[idx]);
|
2019-03-19 21:34:08 +01:00
|
|
|
alt_key = key_mtx_dereference(sdata->local, sta->ptk[idx ^ 1]);
|
|
|
|
|
|
|
|
/* The rekey code assumes that the old and new key are using
|
|
|
|
* the same cipher. Enforce the assumption for pairwise keys.
|
|
|
|
*/
|
|
|
|
if (key &&
|
|
|
|
((alt_key && alt_key->conf.cipher != key->conf.cipher) ||
|
|
|
|
(old_key && old_key->conf.cipher != key->conf.cipher)))
|
|
|
|
goto out;
|
|
|
|
} else if (sta) {
|
2011-05-13 14:15:49 +02:00
|
|
|
old_key = key_mtx_dereference(sdata->local, sta->gtk[idx]);
|
2019-03-19 21:34:08 +01:00
|
|
|
} else {
|
2011-05-13 14:15:49 +02:00
|
|
|
old_key = key_mtx_dereference(sdata->local, sdata->keys[idx]);
|
2019-03-19 21:34:08 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Non-pairwise keys must also not switch the cipher on rekey */
|
|
|
|
if (!pairwise) {
|
|
|
|
if (key && old_key && old_key->conf.cipher != key->conf.cipher)
|
|
|
|
goto out;
|
|
|
|
}
|
2008-02-25 16:27:45 +01:00
|
|
|
|
2017-09-05 14:54:54 +02:00
|
|
|
/*
|
|
|
|
* Silently accept key re-installation without really installing the
|
|
|
|
* new version of the key to avoid nonce reuse or replay issues.
|
|
|
|
*/
|
2017-10-24 21:12:13 +02:00
|
|
|
if (ieee80211_key_identical(sdata, old_key, key)) {
|
2017-09-05 14:54:54 +02:00
|
|
|
ieee80211_key_free_unused(key);
|
|
|
|
ret = 0;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
key->local = sdata->local;
|
|
|
|
key->sdata = sdata;
|
|
|
|
key->sta = sta;
|
|
|
|
|
2011-06-28 15:11:37 +02:00
|
|
|
increment_tailroom_need_count(sdata);
|
|
|
|
|
2018-08-31 15:00:38 +02:00
|
|
|
ret = ieee80211_key_replace(sdata, sta, pairwise, old_key, key);
|
2008-02-25 16:27:45 +01:00
|
|
|
|
2018-08-31 15:00:38 +02:00
|
|
|
if (!ret) {
|
|
|
|
ieee80211_debugfs_key_add(key);
|
|
|
|
ieee80211_key_destroy(old_key, delay_tailroom);
|
2013-08-07 20:11:55 +02:00
|
|
|
} else {
|
2018-08-31 15:00:38 +02:00
|
|
|
ieee80211_key_free(key, delay_tailroom);
|
2013-08-07 20:11:55 +02:00
|
|
|
}
|
2013-03-06 22:53:52 +01:00
|
|
|
|
2017-09-05 14:54:54 +02:00
|
|
|
out:
|
2010-06-01 10:19:19 +02:00
|
|
|
mutex_unlock(&sdata->local->key_mtx);
|
2010-08-27 13:26:52 +02:00
|
|
|
|
|
|
|
return ret;
|
2007-07-27 15:43:23 +02:00
|
|
|
}
|
|
|
|
|
2013-03-06 22:58:23 +01:00
|
|
|
void ieee80211_key_free(struct ieee80211_key *key, bool delay_tailroom)
|
2007-07-27 15:43:23 +02:00
|
|
|
{
|
2011-05-12 14:31:49 +02:00
|
|
|
if (!key)
|
|
|
|
return;
|
|
|
|
|
2008-04-08 17:56:52 +02:00
|
|
|
/*
|
|
|
|
* Replace key with nothingness if it was ever used.
|
|
|
|
*/
|
2008-04-09 16:45:37 +02:00
|
|
|
if (key->sdata)
|
2013-03-06 22:58:23 +01:00
|
|
|
ieee80211_key_replace(key->sdata, key->sta,
|
2010-10-05 19:39:30 +02:00
|
|
|
key->conf.flags & IEEE80211_KEY_FLAG_PAIRWISE,
|
|
|
|
key, NULL);
|
2013-03-06 22:58:23 +01:00
|
|
|
ieee80211_key_destroy(key, delay_tailroom);
|
2008-04-08 17:56:52 +02:00
|
|
|
}
|
[MAC80211]: fix race conditions with keys
During receive processing, we select the key long before using it and
because there's no locking it is possible that we kfree() the key
after having selected it but before using it for crypto operations.
Obviously, this is bad.
Secondly, during transmit processing, there are two possible races: We
have a similar race between select_key() and using it for encryption,
but we also have a race here between select_key() and hardware
encryption (both when a key is removed.)
This patch solves these issues by using RCU: when a key is to be freed,
we first remove the pointer from the appropriate places (sdata->keys,
sdata->default_key, sta->key) using rcu_assign_pointer() and then
synchronize_rcu(). Then, we can safely kfree() the key and remove it
from the hardware. There's a window here where the hardware may still
be using it for decryption, but we can't work around that without having
two hardware callbacks, one to disable the key for RX and one to disable
it for TX; but the worst thing that will happen is that we receive a
packet decrypted that we don't find a key for any more and then drop it.
When we add a key, we first need to upload it to the hardware and then,
using rcu_assign_pointer() again, link it into our structures.
In the code using keys (TX/RX paths) we use rcu_dereference() to get the
key and enclose the whole tx/rx section in a rcu_read_lock() ...
rcu_read_unlock() block. Because we've uploaded the key to hardware
before linking it into internal structures, we can guarantee that it is
valid once get to into tx().
One possible race condition remains, however: when we have hardware
acceleration enabled and the driver shuts down the queues, we end up
queueing the frame. If now somebody removes the key, the key will be
removed from hwaccel and then then driver will be asked to encrypt the
frame with a key index that has been removed. Hence, drivers will need
to be aware that the hw_key_index they are passed might not be under
all circumstances. Most drivers will, however, simply ignore that
condition and encrypt the frame with the selected key anyway, this
only results in a frame being encrypted with a wrong key or dropped
(rightfully) because the key was not valid. There isn't much we can
do about it unless we want to walk the pending frame queue every time
a key is removed and remove all frames that used it.
This race condition, however, will most likely be solved once we add
multiqueue support to mac80211 because then frames will be queued
further up the stack instead of after being processed.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Acked-by: Michael Wu <flamingice@sourmilk.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2007-09-14 17:10:24 +02:00
|
|
|
|
2010-06-01 10:19:19 +02:00
|
|
|
void ieee80211_enable_keys(struct ieee80211_sub_if_data *sdata)
|
2008-04-09 16:45:37 +02:00
|
|
|
{
|
|
|
|
struct ieee80211_key *key;
|
2015-05-13 11:16:48 +02:00
|
|
|
struct ieee80211_sub_if_data *vlan;
|
2007-08-28 23:01:55 +02:00
|
|
|
|
2008-04-09 16:45:37 +02:00
|
|
|
ASSERT_RTNL();
|
2007-08-28 23:01:55 +02:00
|
|
|
|
2009-12-23 13:15:31 +01:00
|
|
|
if (WARN_ON(!ieee80211_sdata_running(sdata)))
|
2008-04-09 16:45:37 +02:00
|
|
|
return;
|
2007-08-28 23:01:55 +02:00
|
|
|
|
2010-06-01 10:19:19 +02:00
|
|
|
mutex_lock(&sdata->local->key_mtx);
|
2007-08-28 23:01:55 +02:00
|
|
|
|
2015-05-13 11:16:48 +02:00
|
|
|
WARN_ON_ONCE(sdata->crypto_tx_tailroom_needed_cnt ||
|
|
|
|
sdata->crypto_tx_tailroom_pending_dec);
|
|
|
|
|
|
|
|
if (sdata->vif.type == NL80211_IFTYPE_AP) {
|
|
|
|
list_for_each_entry(vlan, &sdata->u.ap.vlans, u.vlan.list)
|
|
|
|
WARN_ON_ONCE(vlan->crypto_tx_tailroom_needed_cnt ||
|
|
|
|
vlan->crypto_tx_tailroom_pending_dec);
|
|
|
|
}
|
2011-06-28 15:11:37 +02:00
|
|
|
|
|
|
|
list_for_each_entry(key, &sdata->key_list, list) {
|
|
|
|
increment_tailroom_need_count(sdata);
|
2010-06-01 10:19:19 +02:00
|
|
|
ieee80211_key_enable_hw_accel(key);
|
2011-06-28 15:11:37 +02:00
|
|
|
}
|
2008-04-08 17:56:52 +02:00
|
|
|
|
2010-06-01 10:19:19 +02:00
|
|
|
mutex_unlock(&sdata->local->key_mtx);
|
2007-08-28 23:01:55 +02:00
|
|
|
}
|
|
|
|
|
2015-05-13 11:16:48 +02:00
|
|
|
void ieee80211_reset_crypto_tx_tailroom(struct ieee80211_sub_if_data *sdata)
|
|
|
|
{
|
|
|
|
struct ieee80211_sub_if_data *vlan;
|
|
|
|
|
|
|
|
mutex_lock(&sdata->local->key_mtx);
|
|
|
|
|
|
|
|
sdata->crypto_tx_tailroom_needed_cnt = 0;
|
|
|
|
|
|
|
|
if (sdata->vif.type == NL80211_IFTYPE_AP) {
|
|
|
|
list_for_each_entry(vlan, &sdata->u.ap.vlans, u.vlan.list)
|
|
|
|
vlan->crypto_tx_tailroom_needed_cnt = 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
mutex_unlock(&sdata->local->key_mtx);
|
|
|
|
}
|
|
|
|
|
2011-07-05 16:35:39 +02:00
|
|
|
void ieee80211_iter_keys(struct ieee80211_hw *hw,
|
|
|
|
struct ieee80211_vif *vif,
|
|
|
|
void (*iter)(struct ieee80211_hw *hw,
|
|
|
|
struct ieee80211_vif *vif,
|
|
|
|
struct ieee80211_sta *sta,
|
|
|
|
struct ieee80211_key_conf *key,
|
|
|
|
void *data),
|
|
|
|
void *iter_data)
|
|
|
|
{
|
|
|
|
struct ieee80211_local *local = hw_to_local(hw);
|
2013-08-07 20:11:55 +02:00
|
|
|
struct ieee80211_key *key, *tmp;
|
2011-07-05 16:35:39 +02:00
|
|
|
struct ieee80211_sub_if_data *sdata;
|
|
|
|
|
|
|
|
ASSERT_RTNL();
|
|
|
|
|
|
|
|
mutex_lock(&local->key_mtx);
|
|
|
|
if (vif) {
|
|
|
|
sdata = vif_to_sdata(vif);
|
2013-08-07 20:11:55 +02:00
|
|
|
list_for_each_entry_safe(key, tmp, &sdata->key_list, list)
|
2011-07-05 16:35:39 +02:00
|
|
|
iter(hw, &sdata->vif,
|
|
|
|
key->sta ? &key->sta->sta : NULL,
|
|
|
|
&key->conf, iter_data);
|
|
|
|
} else {
|
|
|
|
list_for_each_entry(sdata, &local->interfaces, list)
|
2013-08-07 20:11:55 +02:00
|
|
|
list_for_each_entry_safe(key, tmp,
|
|
|
|
&sdata->key_list, list)
|
2011-07-05 16:35:39 +02:00
|
|
|
iter(hw, &sdata->vif,
|
|
|
|
key->sta ? &key->sta->sta : NULL,
|
|
|
|
&key->conf, iter_data);
|
|
|
|
}
|
|
|
|
mutex_unlock(&local->key_mtx);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(ieee80211_iter_keys);
|
|
|
|
|
2015-11-17 09:24:37 +01:00
|
|
|
static void
|
|
|
|
_ieee80211_iter_keys_rcu(struct ieee80211_hw *hw,
|
|
|
|
struct ieee80211_sub_if_data *sdata,
|
|
|
|
void (*iter)(struct ieee80211_hw *hw,
|
|
|
|
struct ieee80211_vif *vif,
|
|
|
|
struct ieee80211_sta *sta,
|
|
|
|
struct ieee80211_key_conf *key,
|
|
|
|
void *data),
|
|
|
|
void *iter_data)
|
|
|
|
{
|
|
|
|
struct ieee80211_key *key;
|
|
|
|
|
|
|
|
list_for_each_entry_rcu(key, &sdata->key_list, list) {
|
|
|
|
/* skip keys of station in removal process */
|
|
|
|
if (key->sta && key->sta->removed)
|
|
|
|
continue;
|
|
|
|
if (!(key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
iter(hw, &sdata->vif,
|
|
|
|
key->sta ? &key->sta->sta : NULL,
|
|
|
|
&key->conf, iter_data);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void ieee80211_iter_keys_rcu(struct ieee80211_hw *hw,
|
|
|
|
struct ieee80211_vif *vif,
|
|
|
|
void (*iter)(struct ieee80211_hw *hw,
|
|
|
|
struct ieee80211_vif *vif,
|
|
|
|
struct ieee80211_sta *sta,
|
|
|
|
struct ieee80211_key_conf *key,
|
|
|
|
void *data),
|
|
|
|
void *iter_data)
|
|
|
|
{
|
|
|
|
struct ieee80211_local *local = hw_to_local(hw);
|
|
|
|
struct ieee80211_sub_if_data *sdata;
|
|
|
|
|
|
|
|
if (vif) {
|
|
|
|
sdata = vif_to_sdata(vif);
|
|
|
|
_ieee80211_iter_keys_rcu(hw, sdata, iter, iter_data);
|
|
|
|
} else {
|
|
|
|
list_for_each_entry_rcu(sdata, &local->interfaces, list)
|
|
|
|
_ieee80211_iter_keys_rcu(hw, sdata, iter, iter_data);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(ieee80211_iter_keys_rcu);
|
|
|
|
|
2013-12-04 23:47:09 +01:00
|
|
|
static void ieee80211_free_keys_iface(struct ieee80211_sub_if_data *sdata,
|
|
|
|
struct list_head *keys)
|
2008-04-08 17:56:52 +02:00
|
|
|
{
|
|
|
|
struct ieee80211_key *key, *tmp;
|
|
|
|
|
2015-05-13 11:16:48 +02:00
|
|
|
decrease_tailroom_need_count(sdata,
|
|
|
|
sdata->crypto_tx_tailroom_pending_dec);
|
mac80211: defer tailroom counter manipulation when roaming
During roaming, the crypto_tx_tailroom_needed_cnt counter
will often take values 2,1,0,1,2 because first keys are
removed and then new keys are added. This is inefficient
because during the 0->1 transition, synchronize_net must
be called to avoid packet races, although typically no
packets would be flowing during that time.
To avoid that, defer the decrement (2->1, 1->0) when keys
are removed (by half a second). This means the counter
will really have the values 2,2,2,3,4 ... 2, thus never
reaching 0 and having to do the 0->1 transition.
Note that this patch entirely disregards the drivers for
which this optimisation was done to start with, for them
the key removal itself will be expensive because it has
to synchronize_net() after the counter is incremented to
remove the key from HW crypto. For them the sequence will
look like this: 0,1,0,1,0,1,0,1,0 (*) which is clearly a
lot more inefficient. This could be addressed separately,
during key removal the 0->1->0 sequence isn't necessary.
(*) it starts at 0 because HW crypto is on, then goes to
1 when HW crypto is disabled for a key, then back to
0 because the key is deleted; this happens for both
keys in the example. When new keys are added, it goes
to 1 first because they're added in software; when a
key is moved to hardware it goes back to 0
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2013-02-23 00:59:03 +01:00
|
|
|
sdata->crypto_tx_tailroom_pending_dec = 0;
|
|
|
|
|
2009-01-08 12:32:02 +01:00
|
|
|
ieee80211_debugfs_key_remove_mgmt_default(sdata);
|
2008-04-08 17:56:52 +02:00
|
|
|
|
2013-03-06 23:09:11 +01:00
|
|
|
list_for_each_entry_safe(key, tmp, &sdata->key_list, list) {
|
|
|
|
ieee80211_key_replace(key->sdata, key->sta,
|
|
|
|
key->conf.flags & IEEE80211_KEY_FLAG_PAIRWISE,
|
|
|
|
key, NULL);
|
2013-12-04 23:47:09 +01:00
|
|
|
list_add_tail(&key->list, keys);
|
2013-03-06 23:09:11 +01:00
|
|
|
}
|
2008-04-08 17:56:52 +02:00
|
|
|
|
2010-12-09 19:49:02 +01:00
|
|
|
ieee80211_debugfs_key_update_default(sdata);
|
2013-12-04 23:47:09 +01:00
|
|
|
}
|
2010-12-09 19:49:02 +01:00
|
|
|
|
2013-12-04 23:47:09 +01:00
|
|
|
void ieee80211_free_keys(struct ieee80211_sub_if_data *sdata,
|
|
|
|
bool force_synchronize)
|
|
|
|
{
|
|
|
|
struct ieee80211_local *local = sdata->local;
|
|
|
|
struct ieee80211_sub_if_data *vlan;
|
2015-05-13 11:16:48 +02:00
|
|
|
struct ieee80211_sub_if_data *master;
|
2013-12-04 23:47:09 +01:00
|
|
|
struct ieee80211_key *key, *tmp;
|
|
|
|
LIST_HEAD(keys);
|
|
|
|
|
|
|
|
cancel_delayed_work_sync(&sdata->dec_tailroom_needed_wk);
|
|
|
|
|
|
|
|
mutex_lock(&local->key_mtx);
|
|
|
|
|
|
|
|
ieee80211_free_keys_iface(sdata, &keys);
|
|
|
|
|
|
|
|
if (sdata->vif.type == NL80211_IFTYPE_AP) {
|
|
|
|
list_for_each_entry(vlan, &sdata->u.ap.vlans, u.vlan.list)
|
|
|
|
ieee80211_free_keys_iface(vlan, &keys);
|
2013-03-06 23:09:11 +01:00
|
|
|
}
|
|
|
|
|
2013-12-04 23:47:09 +01:00
|
|
|
if (!list_empty(&keys) || force_synchronize)
|
|
|
|
synchronize_net();
|
|
|
|
list_for_each_entry_safe(key, tmp, &keys, list)
|
|
|
|
__ieee80211_key_destroy(key, false);
|
|
|
|
|
2015-05-13 11:16:48 +02:00
|
|
|
if (sdata->vif.type == NL80211_IFTYPE_AP_VLAN) {
|
|
|
|
if (sdata->bss) {
|
|
|
|
master = container_of(sdata->bss,
|
|
|
|
struct ieee80211_sub_if_data,
|
|
|
|
u.ap);
|
|
|
|
|
|
|
|
WARN_ON_ONCE(sdata->crypto_tx_tailroom_needed_cnt !=
|
|
|
|
master->crypto_tx_tailroom_needed_cnt);
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
WARN_ON_ONCE(sdata->crypto_tx_tailroom_needed_cnt ||
|
|
|
|
sdata->crypto_tx_tailroom_pending_dec);
|
|
|
|
}
|
|
|
|
|
2013-12-04 23:47:09 +01:00
|
|
|
if (sdata->vif.type == NL80211_IFTYPE_AP) {
|
|
|
|
list_for_each_entry(vlan, &sdata->u.ap.vlans, u.vlan.list)
|
|
|
|
WARN_ON_ONCE(vlan->crypto_tx_tailroom_needed_cnt ||
|
|
|
|
vlan->crypto_tx_tailroom_pending_dec);
|
|
|
|
}
|
mac80211: defer tailroom counter manipulation when roaming
During roaming, the crypto_tx_tailroom_needed_cnt counter
will often take values 2,1,0,1,2 because first keys are
removed and then new keys are added. This is inefficient
because during the 0->1 transition, synchronize_net must
be called to avoid packet races, although typically no
packets would be flowing during that time.
To avoid that, defer the decrement (2->1, 1->0) when keys
are removed (by half a second). This means the counter
will really have the values 2,2,2,3,4 ... 2, thus never
reaching 0 and having to do the 0->1 transition.
Note that this patch entirely disregards the drivers for
which this optimisation was done to start with, for them
the key removal itself will be expensive because it has
to synchronize_net() after the counter is incremented to
remove the key from HW crypto. For them the sequence will
look like this: 0,1,0,1,0,1,0,1,0 (*) which is clearly a
lot more inefficient. This could be addressed separately,
during key removal the 0->1->0 sequence isn't necessary.
(*) it starts at 0 because HW crypto is on, then goes to
1 when HW crypto is disabled for a key, then back to
0 because the key is deleted; this happens for both
keys in the example. When new keys are added, it goes
to 1 first because they're added in software; when a
key is moved to hardware it goes back to 0
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2013-02-23 00:59:03 +01:00
|
|
|
|
2013-12-04 23:47:09 +01:00
|
|
|
mutex_unlock(&local->key_mtx);
|
2007-08-28 23:01:55 +02:00
|
|
|
}
|
2011-07-05 16:35:41 +02:00
|
|
|
|
2013-03-06 23:09:11 +01:00
|
|
|
void ieee80211_free_sta_keys(struct ieee80211_local *local,
|
|
|
|
struct sta_info *sta)
|
|
|
|
{
|
2013-12-04 23:05:45 +01:00
|
|
|
struct ieee80211_key *key;
|
2013-03-06 23:09:11 +01:00
|
|
|
int i;
|
|
|
|
|
|
|
|
mutex_lock(&local->key_mtx);
|
2014-12-17 13:55:49 +01:00
|
|
|
for (i = 0; i < ARRAY_SIZE(sta->gtk); i++) {
|
2013-03-06 23:09:11 +01:00
|
|
|
key = key_mtx_dereference(local, sta->gtk[i]);
|
|
|
|
if (!key)
|
|
|
|
continue;
|
|
|
|
ieee80211_key_replace(key->sdata, key->sta,
|
|
|
|
key->conf.flags & IEEE80211_KEY_FLAG_PAIRWISE,
|
|
|
|
key, NULL);
|
mac80211: restrict delayed tailroom needed decrement
As explained in ieee80211_delayed_tailroom_dec(), during roam,
keys of the old AP will be destroyed and new keys will be
installed. Deletion of the old key causes
crypto_tx_tailroom_needed_cnt to go from 1 to 0 and the new key
installation causes a transition from 0 to 1.
Whenever crypto_tx_tailroom_needed_cnt transitions from 0 to 1,
we invoke synchronize_net(); the reason for doing this is to avoid
a race in the TX path as explained in increment_tailroom_need_count().
This synchronize_net() operation can be slow and can affect the station
roam time. To avoid this, decrementing the crypto_tx_tailroom_needed_cnt
is delayed for a while so that upon installation of new key the
transition would be from 1 to 2 instead of 0 to 1 and thereby
improving the roam time.
This is all correct for a STA iftype, but deferring the tailroom_needed
decrement for other iftypes may be unnecessary.
For example, let's consider the case of a 4-addr client connecting to
an AP for which AP_VLAN interface is also created, let the initial
value for tailroom_needed on the AP be 1.
* 4-addr client connects to the AP (AP: tailroom_needed = 1)
* AP will clear old keys, delay decrement of tailroom_needed count
* AP_VLAN is created, it takes the tailroom count from master
(AP_VLAN: tailroom_needed = 1, AP: tailroom_needed = 1)
* Install new key for the station, assume key is plumbed in the HW,
there won't be any change in tailroom_needed count on AP iface
* Delayed decrement of tailroom_needed count on AP
(AP: tailroom_needed = 0, AP_VLAN: tailroom_needed = 1)
Because of the delayed decrement on AP iface, tailroom_needed count goes
out of sync between AP(master iface) and AP_VLAN(slave iface) and
there would be unnecessary tailroom created for the packets going
through AP_VLAN iface.
Also, WARN_ONs were observed while trying to bring down the AP_VLAN
interface:
(warn_slowpath_common) (warn_slowpath_null+0x18/0x20)
(warn_slowpath_null) (ieee80211_free_keys+0x114/0x1e4)
(ieee80211_free_keys) (ieee80211_del_virtual_monitor+0x51c/0x850)
(ieee80211_del_virtual_monitor) (ieee80211_stop+0x30/0x3c)
(ieee80211_stop) (__dev_close_many+0x94/0xb8)
(__dev_close_many) (dev_close_many+0x5c/0xc8)
Restricting delayed decrement to station interface alone fixes the problem
and it makes sense to do so because delayed decrement is done to improve
roam time which is applicable only for client devices.
Signed-off-by: Manikanta Pubbisetty <mpubbise@codeaurora.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2018-07-10 13:18:27 +02:00
|
|
|
__ieee80211_key_destroy(key, key->sdata->vif.type ==
|
|
|
|
NL80211_IFTYPE_STATION);
|
2013-03-06 23:09:11 +01:00
|
|
|
}
|
|
|
|
|
2013-03-24 13:23:27 +01:00
|
|
|
for (i = 0; i < NUM_DEFAULT_KEYS; i++) {
|
|
|
|
key = key_mtx_dereference(local, sta->ptk[i]);
|
|
|
|
if (!key)
|
|
|
|
continue;
|
2013-03-06 23:09:11 +01:00
|
|
|
ieee80211_key_replace(key->sdata, key->sta,
|
|
|
|
key->conf.flags & IEEE80211_KEY_FLAG_PAIRWISE,
|
|
|
|
key, NULL);
|
mac80211: restrict delayed tailroom needed decrement
As explained in ieee80211_delayed_tailroom_dec(), during roam,
keys of the old AP will be destroyed and new keys will be
installed. Deletion of the old key causes
crypto_tx_tailroom_needed_cnt to go from 1 to 0 and the new key
installation causes a transition from 0 to 1.
Whenever crypto_tx_tailroom_needed_cnt transitions from 0 to 1,
we invoke synchronize_net(); the reason for doing this is to avoid
a race in the TX path as explained in increment_tailroom_need_count().
This synchronize_net() operation can be slow and can affect the station
roam time. To avoid this, decrementing the crypto_tx_tailroom_needed_cnt
is delayed for a while so that upon installation of new key the
transition would be from 1 to 2 instead of 0 to 1 and thereby
improving the roam time.
This is all correct for a STA iftype, but deferring the tailroom_needed
decrement for other iftypes may be unnecessary.
For example, let's consider the case of a 4-addr client connecting to
an AP for which AP_VLAN interface is also created, let the initial
value for tailroom_needed on the AP be 1.
* 4-addr client connects to the AP (AP: tailroom_needed = 1)
* AP will clear old keys, delay decrement of tailroom_needed count
* AP_VLAN is created, it takes the tailroom count from master
(AP_VLAN: tailroom_needed = 1, AP: tailroom_needed = 1)
* Install new key for the station, assume key is plumbed in the HW,
there won't be any change in tailroom_needed count on AP iface
* Delayed decrement of tailroom_needed count on AP
(AP: tailroom_needed = 0, AP_VLAN: tailroom_needed = 1)
Because of the delayed decrement on AP iface, tailroom_needed count goes
out of sync between AP(master iface) and AP_VLAN(slave iface) and
there would be unnecessary tailroom created for the packets going
through AP_VLAN iface.
Also, WARN_ONs were observed while trying to bring down the AP_VLAN
interface:
(warn_slowpath_common) (warn_slowpath_null+0x18/0x20)
(warn_slowpath_null) (ieee80211_free_keys+0x114/0x1e4)
(ieee80211_free_keys) (ieee80211_del_virtual_monitor+0x51c/0x850)
(ieee80211_del_virtual_monitor) (ieee80211_stop+0x30/0x3c)
(ieee80211_stop) (__dev_close_many+0x94/0xb8)
(__dev_close_many) (dev_close_many+0x5c/0xc8)
Restricting delayed decrement to station interface alone fixes the problem
and it makes sense to do so because delayed decrement is done to improve
roam time which is applicable only for client devices.
Signed-off-by: Manikanta Pubbisetty <mpubbise@codeaurora.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2018-07-10 13:18:27 +02:00
|
|
|
__ieee80211_key_destroy(key, key->sdata->vif.type ==
|
|
|
|
NL80211_IFTYPE_STATION);
|
2013-12-04 23:05:45 +01:00
|
|
|
}
|
2013-03-06 23:09:11 +01:00
|
|
|
|
|
|
|
mutex_unlock(&local->key_mtx);
|
|
|
|
}
|
|
|
|
|
mac80211: defer tailroom counter manipulation when roaming
During roaming, the crypto_tx_tailroom_needed_cnt counter
will often take values 2,1,0,1,2 because first keys are
removed and then new keys are added. This is inefficient
because during the 0->1 transition, synchronize_net must
be called to avoid packet races, although typically no
packets would be flowing during that time.
To avoid that, defer the decrement (2->1, 1->0) when keys
are removed (by half a second). This means the counter
will really have the values 2,2,2,3,4 ... 2, thus never
reaching 0 and having to do the 0->1 transition.
Note that this patch entirely disregards the drivers for
which this optimisation was done to start with, for them
the key removal itself will be expensive because it has
to synchronize_net() after the counter is incremented to
remove the key from HW crypto. For them the sequence will
look like this: 0,1,0,1,0,1,0,1,0 (*) which is clearly a
lot more inefficient. This could be addressed separately,
during key removal the 0->1->0 sequence isn't necessary.
(*) it starts at 0 because HW crypto is on, then goes to
1 when HW crypto is disabled for a key, then back to
0 because the key is deleted; this happens for both
keys in the example. When new keys are added, it goes
to 1 first because they're added in software; when a
key is moved to hardware it goes back to 0
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2013-02-23 00:59:03 +01:00
|
|
|
void ieee80211_delayed_tailroom_dec(struct work_struct *wk)
|
|
|
|
{
|
|
|
|
struct ieee80211_sub_if_data *sdata;
|
|
|
|
|
|
|
|
sdata = container_of(wk, struct ieee80211_sub_if_data,
|
|
|
|
dec_tailroom_needed_wk.work);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The reason for the delayed tailroom needed decrementing is to
|
|
|
|
* make roaming faster: during roaming, all keys are first deleted
|
|
|
|
* and then new keys are installed. The first new key causes the
|
|
|
|
* crypto_tx_tailroom_needed_cnt to go from 0 to 1, which invokes
|
|
|
|
* the cost of synchronize_net() (which can be slow). Avoid this
|
|
|
|
* by deferring the crypto_tx_tailroom_needed_cnt decrementing on
|
|
|
|
* key removal for a while, so if we roam the value is larger than
|
|
|
|
* zero and no 0->1 transition happens.
|
|
|
|
*
|
|
|
|
* The cost is that if the AP switching was from an AP with keys
|
|
|
|
* to one without, we still allocate tailroom while it would no
|
|
|
|
* longer be needed. However, in the typical (fast) roaming case
|
|
|
|
* within an ESS this usually won't happen.
|
|
|
|
*/
|
|
|
|
|
|
|
|
mutex_lock(&sdata->local->key_mtx);
|
2015-05-13 11:16:48 +02:00
|
|
|
decrease_tailroom_need_count(sdata,
|
|
|
|
sdata->crypto_tx_tailroom_pending_dec);
|
mac80211: defer tailroom counter manipulation when roaming
During roaming, the crypto_tx_tailroom_needed_cnt counter
will often take values 2,1,0,1,2 because first keys are
removed and then new keys are added. This is inefficient
because during the 0->1 transition, synchronize_net must
be called to avoid packet races, although typically no
packets would be flowing during that time.
To avoid that, defer the decrement (2->1, 1->0) when keys
are removed (by half a second). This means the counter
will really have the values 2,2,2,3,4 ... 2, thus never
reaching 0 and having to do the 0->1 transition.
Note that this patch entirely disregards the drivers for
which this optimisation was done to start with, for them
the key removal itself will be expensive because it has
to synchronize_net() after the counter is incremented to
remove the key from HW crypto. For them the sequence will
look like this: 0,1,0,1,0,1,0,1,0 (*) which is clearly a
lot more inefficient. This could be addressed separately,
during key removal the 0->1->0 sequence isn't necessary.
(*) it starts at 0 because HW crypto is on, then goes to
1 when HW crypto is disabled for a key, then back to
0 because the key is deleted; this happens for both
keys in the example. When new keys are added, it goes
to 1 first because they're added in software; when a
key is moved to hardware it goes back to 0
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2013-02-23 00:59:03 +01:00
|
|
|
sdata->crypto_tx_tailroom_pending_dec = 0;
|
|
|
|
mutex_unlock(&sdata->local->key_mtx);
|
|
|
|
}
|
2011-07-05 16:35:41 +02:00
|
|
|
|
|
|
|
void ieee80211_gtk_rekey_notify(struct ieee80211_vif *vif, const u8 *bssid,
|
|
|
|
const u8 *replay_ctr, gfp_t gfp)
|
|
|
|
{
|
|
|
|
struct ieee80211_sub_if_data *sdata = vif_to_sdata(vif);
|
|
|
|
|
|
|
|
trace_api_gtk_rekey_notify(sdata, bssid, replay_ctr);
|
|
|
|
|
|
|
|
cfg80211_gtk_rekey_notify(sdata->dev, bssid, replay_ctr, gfp);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(ieee80211_gtk_rekey_notify);
|
2011-07-07 18:58:00 +02:00
|
|
|
|
|
|
|
void ieee80211_get_key_rx_seq(struct ieee80211_key_conf *keyconf,
|
|
|
|
int tid, struct ieee80211_key_seq *seq)
|
|
|
|
{
|
|
|
|
struct ieee80211_key *key;
|
|
|
|
const u8 *pn;
|
|
|
|
|
|
|
|
key = container_of(keyconf, struct ieee80211_key, conf);
|
|
|
|
|
|
|
|
switch (key->conf.cipher) {
|
|
|
|
case WLAN_CIPHER_SUITE_TKIP:
|
2012-11-14 23:22:21 +01:00
|
|
|
if (WARN_ON(tid < 0 || tid >= IEEE80211_NUM_TIDS))
|
2011-07-07 18:58:00 +02:00
|
|
|
return;
|
|
|
|
seq->tkip.iv32 = key->u.tkip.rx[tid].iv32;
|
|
|
|
seq->tkip.iv16 = key->u.tkip.rx[tid].iv16;
|
|
|
|
break;
|
|
|
|
case WLAN_CIPHER_SUITE_CCMP:
|
2015-01-24 18:52:07 +01:00
|
|
|
case WLAN_CIPHER_SUITE_CCMP_256:
|
2012-11-14 23:22:21 +01:00
|
|
|
if (WARN_ON(tid < -1 || tid >= IEEE80211_NUM_TIDS))
|
2011-07-07 18:58:00 +02:00
|
|
|
return;
|
|
|
|
if (tid < 0)
|
2012-11-14 23:22:21 +01:00
|
|
|
pn = key->u.ccmp.rx_pn[IEEE80211_NUM_TIDS];
|
2011-07-07 18:58:00 +02:00
|
|
|
else
|
|
|
|
pn = key->u.ccmp.rx_pn[tid];
|
2013-05-08 13:09:08 +02:00
|
|
|
memcpy(seq->ccmp.pn, pn, IEEE80211_CCMP_PN_LEN);
|
2011-07-07 18:58:00 +02:00
|
|
|
break;
|
|
|
|
case WLAN_CIPHER_SUITE_AES_CMAC:
|
2015-01-24 18:52:08 +01:00
|
|
|
case WLAN_CIPHER_SUITE_BIP_CMAC_256:
|
2011-07-07 18:58:00 +02:00
|
|
|
if (WARN_ON(tid != 0))
|
|
|
|
return;
|
|
|
|
pn = key->u.aes_cmac.rx_pn;
|
2013-05-08 13:09:08 +02:00
|
|
|
memcpy(seq->aes_cmac.pn, pn, IEEE80211_CMAC_PN_LEN);
|
2011-07-07 18:58:00 +02:00
|
|
|
break;
|
2015-01-24 18:52:09 +01:00
|
|
|
case WLAN_CIPHER_SUITE_BIP_GMAC_128:
|
|
|
|
case WLAN_CIPHER_SUITE_BIP_GMAC_256:
|
|
|
|
if (WARN_ON(tid != 0))
|
|
|
|
return;
|
|
|
|
pn = key->u.aes_gmac.rx_pn;
|
|
|
|
memcpy(seq->aes_gmac.pn, pn, IEEE80211_GMAC_PN_LEN);
|
|
|
|
break;
|
2015-01-24 18:52:06 +01:00
|
|
|
case WLAN_CIPHER_SUITE_GCMP:
|
|
|
|
case WLAN_CIPHER_SUITE_GCMP_256:
|
|
|
|
if (WARN_ON(tid < -1 || tid >= IEEE80211_NUM_TIDS))
|
|
|
|
return;
|
|
|
|
if (tid < 0)
|
|
|
|
pn = key->u.gcmp.rx_pn[IEEE80211_NUM_TIDS];
|
|
|
|
else
|
|
|
|
pn = key->u.gcmp.rx_pn[tid];
|
|
|
|
memcpy(seq->gcmp.pn, pn, IEEE80211_GCMP_PN_LEN);
|
|
|
|
break;
|
2011-07-07 18:58:00 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(ieee80211_get_key_rx_seq);
|
2013-08-07 20:11:55 +02:00
|
|
|
|
|
|
|
void ieee80211_set_key_rx_seq(struct ieee80211_key_conf *keyconf,
|
|
|
|
int tid, struct ieee80211_key_seq *seq)
|
|
|
|
{
|
|
|
|
struct ieee80211_key *key;
|
|
|
|
u8 *pn;
|
|
|
|
|
|
|
|
key = container_of(keyconf, struct ieee80211_key, conf);
|
|
|
|
|
|
|
|
switch (key->conf.cipher) {
|
|
|
|
case WLAN_CIPHER_SUITE_TKIP:
|
|
|
|
if (WARN_ON(tid < 0 || tid >= IEEE80211_NUM_TIDS))
|
|
|
|
return;
|
|
|
|
key->u.tkip.rx[tid].iv32 = seq->tkip.iv32;
|
|
|
|
key->u.tkip.rx[tid].iv16 = seq->tkip.iv16;
|
|
|
|
break;
|
|
|
|
case WLAN_CIPHER_SUITE_CCMP:
|
2015-01-24 18:52:07 +01:00
|
|
|
case WLAN_CIPHER_SUITE_CCMP_256:
|
2013-08-07 20:11:55 +02:00
|
|
|
if (WARN_ON(tid < -1 || tid >= IEEE80211_NUM_TIDS))
|
|
|
|
return;
|
|
|
|
if (tid < 0)
|
|
|
|
pn = key->u.ccmp.rx_pn[IEEE80211_NUM_TIDS];
|
|
|
|
else
|
|
|
|
pn = key->u.ccmp.rx_pn[tid];
|
|
|
|
memcpy(pn, seq->ccmp.pn, IEEE80211_CCMP_PN_LEN);
|
|
|
|
break;
|
|
|
|
case WLAN_CIPHER_SUITE_AES_CMAC:
|
2015-01-24 18:52:08 +01:00
|
|
|
case WLAN_CIPHER_SUITE_BIP_CMAC_256:
|
2013-08-07 20:11:55 +02:00
|
|
|
if (WARN_ON(tid != 0))
|
|
|
|
return;
|
|
|
|
pn = key->u.aes_cmac.rx_pn;
|
|
|
|
memcpy(pn, seq->aes_cmac.pn, IEEE80211_CMAC_PN_LEN);
|
|
|
|
break;
|
2015-01-24 18:52:09 +01:00
|
|
|
case WLAN_CIPHER_SUITE_BIP_GMAC_128:
|
|
|
|
case WLAN_CIPHER_SUITE_BIP_GMAC_256:
|
|
|
|
if (WARN_ON(tid != 0))
|
|
|
|
return;
|
|
|
|
pn = key->u.aes_gmac.rx_pn;
|
|
|
|
memcpy(pn, seq->aes_gmac.pn, IEEE80211_GMAC_PN_LEN);
|
|
|
|
break;
|
2015-01-24 18:52:06 +01:00
|
|
|
case WLAN_CIPHER_SUITE_GCMP:
|
|
|
|
case WLAN_CIPHER_SUITE_GCMP_256:
|
|
|
|
if (WARN_ON(tid < -1 || tid >= IEEE80211_NUM_TIDS))
|
|
|
|
return;
|
|
|
|
if (tid < 0)
|
|
|
|
pn = key->u.gcmp.rx_pn[IEEE80211_NUM_TIDS];
|
|
|
|
else
|
|
|
|
pn = key->u.gcmp.rx_pn[tid];
|
|
|
|
memcpy(pn, seq->gcmp.pn, IEEE80211_GCMP_PN_LEN);
|
|
|
|
break;
|
2013-08-07 20:11:55 +02:00
|
|
|
default:
|
|
|
|
WARN_ON(1);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(ieee80211_set_key_rx_seq);
|
|
|
|
|
|
|
|
void ieee80211_remove_key(struct ieee80211_key_conf *keyconf)
|
|
|
|
{
|
|
|
|
struct ieee80211_key *key;
|
|
|
|
|
|
|
|
key = container_of(keyconf, struct ieee80211_key, conf);
|
|
|
|
|
|
|
|
assert_key_lock(key->local);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* if key was uploaded, we assume the driver will/has remove(d)
|
|
|
|
* it, so adjust bookkeeping accordingly
|
|
|
|
*/
|
|
|
|
if (key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE) {
|
|
|
|
key->flags &= ~KEY_FLAG_UPLOADED_TO_HARDWARE;
|
|
|
|
|
2019-03-16 21:44:43 +01:00
|
|
|
if (!(key->conf.flags & (IEEE80211_KEY_FLAG_GENERATE_MMIC |
|
|
|
|
IEEE80211_KEY_FLAG_PUT_MIC_SPACE |
|
|
|
|
IEEE80211_KEY_FLAG_RESERVE_TAILROOM)))
|
2013-08-07 20:11:55 +02:00
|
|
|
increment_tailroom_need_count(key->sdata);
|
|
|
|
}
|
|
|
|
|
|
|
|
ieee80211_key_free(key, false);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(ieee80211_remove_key);
|
|
|
|
|
|
|
|
struct ieee80211_key_conf *
|
|
|
|
ieee80211_gtk_rekey_add(struct ieee80211_vif *vif,
|
|
|
|
struct ieee80211_key_conf *keyconf)
|
|
|
|
{
|
|
|
|
struct ieee80211_sub_if_data *sdata = vif_to_sdata(vif);
|
|
|
|
struct ieee80211_local *local = sdata->local;
|
|
|
|
struct ieee80211_key *key;
|
|
|
|
int err;
|
|
|
|
|
|
|
|
if (WARN_ON(!local->wowlan))
|
|
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
|
|
|
|
if (WARN_ON(vif->type != NL80211_IFTYPE_STATION))
|
|
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
|
|
|
|
key = ieee80211_key_alloc(keyconf->cipher, keyconf->keyidx,
|
|
|
|
keyconf->keylen, keyconf->key,
|
2013-03-24 13:23:27 +01:00
|
|
|
0, NULL, NULL);
|
2013-08-07 20:11:55 +02:00
|
|
|
if (IS_ERR(key))
|
2013-08-28 19:03:36 +02:00
|
|
|
return ERR_CAST(key);
|
2013-08-07 20:11:55 +02:00
|
|
|
|
|
|
|
if (sdata->u.mgd.mfp != IEEE80211_MFP_DISABLED)
|
|
|
|
key->conf.flags |= IEEE80211_KEY_FLAG_RX_MGMT;
|
|
|
|
|
|
|
|
err = ieee80211_key_link(key, sdata, NULL);
|
|
|
|
if (err)
|
|
|
|
return ERR_PTR(err);
|
|
|
|
|
|
|
|
return &key->conf;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(ieee80211_gtk_rekey_add);
|