regulator: gpio-regulator: Fix finding of smallest value
Commit 4dbd8f63f0
(regulator: gpio-regulator: Set the smallest
voltage/current in the specified range) forgot to set the newly
introduced best_val.
Therefore it stayed always at INT_MAX thus breaking the setting
of the voltage.
Included is also an init value for target, as warnings about
a possibly uninitialised target started appearing with this fix.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
This commit is contained in:
parent
7d4be2f5ad
commit
00926369b7
|
@ -104,13 +104,15 @@ static int gpio_regulator_set_value(struct regulator_dev *dev,
|
||||||
int min, int max)
|
int min, int max)
|
||||||
{
|
{
|
||||||
struct gpio_regulator_data *data = rdev_get_drvdata(dev);
|
struct gpio_regulator_data *data = rdev_get_drvdata(dev);
|
||||||
int ptr, target, state, best_val = INT_MAX;
|
int ptr, target = 0, state, best_val = INT_MAX;
|
||||||
|
|
||||||
for (ptr = 0; ptr < data->nr_states; ptr++)
|
for (ptr = 0; ptr < data->nr_states; ptr++)
|
||||||
if (data->states[ptr].value < best_val &&
|
if (data->states[ptr].value < best_val &&
|
||||||
data->states[ptr].value >= min &&
|
data->states[ptr].value >= min &&
|
||||||
data->states[ptr].value <= max)
|
data->states[ptr].value <= max) {
|
||||||
target = data->states[ptr].gpios;
|
target = data->states[ptr].gpios;
|
||||||
|
best_val = data->states[ptr].value;
|
||||||
|
}
|
||||||
|
|
||||||
if (best_val == INT_MAX)
|
if (best_val == INT_MAX)
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
|
|
Loading…
Reference in New Issue