media: venus: core: Fix runtime PM imbalance in venus_probe
[ Upstream commit bbe516e976
]
pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced. For other error
paths after this call, things are the same.
Fix this by adding pm_runtime_put_noidle() after 'err_runtime_disable'
label. But in this case, the error path after pm_runtime_put_sync()
will decrease PM usage counter twice. Thus add an extra
pm_runtime_get_noresume() in this path to balance PM counter.
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
0ce7ba162b
commit
05f9cc28a9
|
@ -316,8 +316,10 @@ static int venus_probe(struct platform_device *pdev)
|
|||
goto err_core_deinit;
|
||||
|
||||
ret = pm_runtime_put_sync(dev);
|
||||
if (ret)
|
||||
if (ret) {
|
||||
pm_runtime_get_noresume(dev);
|
||||
goto err_dev_unregister;
|
||||
}
|
||||
|
||||
return 0;
|
||||
|
||||
|
@ -328,6 +330,7 @@ err_core_deinit:
|
|||
err_venus_shutdown:
|
||||
venus_shutdown(core);
|
||||
err_runtime_disable:
|
||||
pm_runtime_put_noidle(dev);
|
||||
pm_runtime_set_suspended(dev);
|
||||
pm_runtime_disable(dev);
|
||||
hfi_destroy(core);
|
||||
|
|
Loading…
Reference in New Issue