MIPS/ath25: Fix race in installing chained IRQ handler
Fix a race where a pending interrupt could be received and the handler called before the handler's data has been setup, by converting to irq_set_chained_handler_and_data(). Search and conversion was done with coccinelle: @@ expression E1, E2, E3; @@ ( -if (irq_set_chained_handler(E1, E3) != 0) - BUG(); | -irq_set_chained_handler(E1, E3); ) -irq_set_handler_data(E1, E2); +irq_set_chained_handler_and_data(E1, E3, E2); @@ expression E1, E2, E3; @@ ( -if (irq_set_chained_handler(E1, E3) != 0) - BUG(); ... | -irq_set_chained_handler(E1, E3); ... ) -irq_set_handler_data(E1, E2); +irq_set_chained_handler_and_data(E1, E3, E2); Reported-by: Russell King <rmk+kernel@arm.linux.org.uk> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Julia Lawall <Julia.Lawall@lip6.fr> Cc: Ralf Baechle <ralf@linux-mips.org> Cc: Sergey Ryazanov <ryazanov.s.a@gmail.com> Cc: linux-mips@linux-mips.org
This commit is contained in:
parent
20f83e717f
commit
08ece35e7d
|
@ -156,8 +156,8 @@ void __init ar5312_arch_init_irq(void)
|
|||
irq = irq_create_mapping(domain, AR5312_MISC_IRQ_AHB_PROC);
|
||||
setup_irq(irq, &ar5312_ahb_err_interrupt);
|
||||
|
||||
irq_set_chained_handler(AR5312_IRQ_MISC, ar5312_misc_irq_handler);
|
||||
irq_set_handler_data(AR5312_IRQ_MISC, domain);
|
||||
irq_set_chained_handler_and_data(AR5312_IRQ_MISC,
|
||||
ar5312_misc_irq_handler, domain);
|
||||
|
||||
ar5312_misc_irq_domain = domain;
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue