net/rxrpc: Use BUG_ON
if (...) BUG(); should be replaced with BUG_ON(...) when the test has no side-effects to allow a definition of BUG_ON that drops the code completely. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @ disable unlikely @ expression E,f; @@ ( if (<... f(...) ...>) { BUG(); } | - if (unlikely(E)) { BUG(); } + BUG_ON(E); ) @@ expression E,f; @@ ( if (<... f(...) ...>) { BUG(); } | - if (E) { BUG(); } + BUG_ON(E); ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
9ff5660746
commit
163e3cb7da
|
@ -156,8 +156,7 @@ static int rxrpc_accept_incoming_call(struct rxrpc_local *local,
|
||||||
false);
|
false);
|
||||||
spin_unlock(&call->lock);
|
spin_unlock(&call->lock);
|
||||||
notification = NULL;
|
notification = NULL;
|
||||||
if (ret < 0)
|
BUG_ON(ret < 0);
|
||||||
BUG();
|
|
||||||
}
|
}
|
||||||
spin_unlock(&call->conn->state_lock);
|
spin_unlock(&call->conn->state_lock);
|
||||||
|
|
||||||
|
|
|
@ -814,8 +814,7 @@ static int rxrpc_post_message(struct rxrpc_call *call, u32 mark, u32 error,
|
||||||
spin_lock_bh(&call->lock);
|
spin_lock_bh(&call->lock);
|
||||||
ret = rxrpc_queue_rcv_skb(call, skb, true, fatal);
|
ret = rxrpc_queue_rcv_skb(call, skb, true, fatal);
|
||||||
spin_unlock_bh(&call->lock);
|
spin_unlock_bh(&call->lock);
|
||||||
if (ret < 0)
|
BUG_ON(ret < 0);
|
||||||
BUG();
|
|
||||||
}
|
}
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
|
|
Loading…
Reference in New Issue