extcon: arizona: Get MICVDD against extcon device
Previously we would do a regulator get against the main Arizona device to obtain the MICVDD regulator. Arizona is an MFD device and normally MICVDD will be supplied by one of its children (the arizona-micsupp regulator). As devres destruction for the MFD device will run after all its children have been destroyed, the regulator will be destroyed before devres calls regulator_put. This causes a warning from both the destruction of the child node, as the regulator is still open, and from the put of the regulator as the regulator device has already been destroyed. A simple fix here is to get the regulator against the extcon device itself such that devres runs when the child is destroyed. This has the additional benefit that if for some reason the extcon driver is unloaded the regulator reference won't hang around until the MFD is unloaded. Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
This commit is contained in:
parent
0a16ee633a
commit
17271f608b
|
@ -1120,7 +1120,7 @@ static int arizona_extcon_probe(struct platform_device *pdev)
|
||||||
if (!info)
|
if (!info)
|
||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
|
|
||||||
info->micvdd = devm_regulator_get(arizona->dev, "MICVDD");
|
info->micvdd = devm_regulator_get(&pdev->dev, "MICVDD");
|
||||||
if (IS_ERR(info->micvdd)) {
|
if (IS_ERR(info->micvdd)) {
|
||||||
ret = PTR_ERR(info->micvdd);
|
ret = PTR_ERR(info->micvdd);
|
||||||
dev_err(arizona->dev, "Failed to get MICVDD: %d\n", ret);
|
dev_err(arizona->dev, "Failed to get MICVDD: %d\n", ret);
|
||||||
|
|
Loading…
Reference in New Issue