OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Staging: speakup: Use kmemdup rather than duplicating its implementation 

Use kmemdup rather than duplicating its implementation

The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Thomas Meyer 2011-11-12 13:11:18 +01:00 committed by Greg Kroah-Hartman
parent cd420765eb
commit 1aa5eb67d7
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/staging/speakup/kobjects.c
View File

@ -265,12 +265,11 @@ static ssize_t keymap_store(struct kobject *kobj, struct kobj_attribute *attr,
unsigned long flags; unsigned long flags;
spk_lock(flags); spk_lock(flags);
in_buff = kmalloc(count + 1, GFP_ATOMIC); in_buff = kmemdup(buf, count + 1, GFP_ATOMIC);
if (!in_buff) { if (!in_buff) {
spk_unlock(flags); spk_unlock(flags);
return -ENOMEM; return -ENOMEM;
} }
memcpy(in_buff, buf, count + 1);
if (strchr("dDrR", *in_buff)) { if (strchr("dDrR", *in_buff)) {
set_key_info(key_defaults, key_buf); set_key_info(key_defaults, key_buf);
pr_info("keymap set to default values\n"); pr_info("keymap set to default values\n");