net/mlx5: Fix leak upon failure of rule creation
[ Upstream commit a5bfe6b4675e0eefbd9418055b5cc6e89af27eb4 ]
When creation of a new rule that requires allocation of an FTE fails,
need to call to tree_put_node on the FTE in order to release its'
resource.
Fixes: cefc23554f
("net/mlx5: Fix FTE cleanup")
Signed-off-by: Maor Gottlieb <maorg@nvidia.com>
Reviewed-by: Alaa Hleihel <alaa@nvidia.com>
Reviewed-by: Mark Bloch <mbloch@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
67b7f73bbe
commit
1cef1d46ad
|
@ -1697,6 +1697,7 @@ search_again_locked:
|
||||||
if (!fte_tmp)
|
if (!fte_tmp)
|
||||||
continue;
|
continue;
|
||||||
rule = add_rule_fg(g, spec, flow_act, dest, dest_num, fte_tmp);
|
rule = add_rule_fg(g, spec, flow_act, dest, dest_num, fte_tmp);
|
||||||
|
/* No error check needed here, because insert_fte() is not called */
|
||||||
up_write_ref_node(&fte_tmp->node, false);
|
up_write_ref_node(&fte_tmp->node, false);
|
||||||
tree_put_node(&fte_tmp->node, false);
|
tree_put_node(&fte_tmp->node, false);
|
||||||
kmem_cache_free(steering->ftes_cache, fte);
|
kmem_cache_free(steering->ftes_cache, fte);
|
||||||
|
@ -1745,6 +1746,8 @@ skip_search:
|
||||||
up_write_ref_node(&g->node, false);
|
up_write_ref_node(&g->node, false);
|
||||||
rule = add_rule_fg(g, spec, flow_act, dest, dest_num, fte);
|
rule = add_rule_fg(g, spec, flow_act, dest, dest_num, fte);
|
||||||
up_write_ref_node(&fte->node, false);
|
up_write_ref_node(&fte->node, false);
|
||||||
|
if (IS_ERR(rule))
|
||||||
|
tree_put_node(&fte->node, false);
|
||||||
return rule;
|
return rule;
|
||||||
}
|
}
|
||||||
rule = ERR_PTR(-ENOENT);
|
rule = ERR_PTR(-ENOENT);
|
||||||
|
@ -1844,6 +1847,8 @@ search_again_locked:
|
||||||
up_write_ref_node(&g->node, false);
|
up_write_ref_node(&g->node, false);
|
||||||
rule = add_rule_fg(g, spec, flow_act, dest, dest_num, fte);
|
rule = add_rule_fg(g, spec, flow_act, dest, dest_num, fte);
|
||||||
up_write_ref_node(&fte->node, false);
|
up_write_ref_node(&fte->node, false);
|
||||||
|
if (IS_ERR(rule))
|
||||||
|
tree_put_node(&fte->node, false);
|
||||||
tree_put_node(&g->node, false);
|
tree_put_node(&g->node, false);
|
||||||
return rule;
|
return rule;
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue