net: sched: prefer qdisc_is_empty() over direct qlen access
When checking for root qdisc queue length, do not access directly q.qlen. In the following patches we will move back qlen accounting to per CPU values for NOLOCK qdiscs. Instead, prefer the qdisc_is_empty() helper usage. Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
b0a231a26d
commit
1f5e6fdd6a
|
@ -747,7 +747,7 @@ static inline bool qdisc_all_tx_empty(const struct net_device *dev)
|
||||||
struct netdev_queue *txq = netdev_get_tx_queue(dev, i);
|
struct netdev_queue *txq = netdev_get_tx_queue(dev, i);
|
||||||
const struct Qdisc *q = rcu_dereference(txq->qdisc);
|
const struct Qdisc *q = rcu_dereference(txq->qdisc);
|
||||||
|
|
||||||
if (q->q.qlen) {
|
if (!qdisc_is_empty(q)) {
|
||||||
rcu_read_unlock();
|
rcu_read_unlock();
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue