sony-laptop: potential null dereference
In the original code, if "device_enum" was NULL then it would dereference it when it printed the error message. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Matthew Garrett <mjg@redhat.com>
This commit is contained in:
parent
31f007598c
commit
200140bdb5
|
@ -1311,7 +1311,11 @@ static void sony_nc_rfkill_setup(struct acpi_device *device)
|
||||||
}
|
}
|
||||||
|
|
||||||
device_enum = (union acpi_object *) buffer.pointer;
|
device_enum = (union acpi_object *) buffer.pointer;
|
||||||
if (!device_enum || device_enum->type != ACPI_TYPE_BUFFER) {
|
if (!device_enum) {
|
||||||
|
pr_err(DRV_PFX "No SN06 return object.");
|
||||||
|
goto out_no_enum;
|
||||||
|
}
|
||||||
|
if (device_enum->type != ACPI_TYPE_BUFFER) {
|
||||||
pr_err(DRV_PFX "Invalid SN06 return object 0x%.2x\n",
|
pr_err(DRV_PFX "Invalid SN06 return object 0x%.2x\n",
|
||||||
device_enum->type);
|
device_enum->type);
|
||||||
goto out_no_enum;
|
goto out_no_enum;
|
||||||
|
|
Loading…
Reference in New Issue