OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

rcutree/rcu_bh_qs: disable irq while calling rcu_preempt_qs() 

Any callers to the function rcu_preempt_qs() must disable irqs in
order to protect the assignment to ->rcu_read_unlock_special. In
RT case, rcu_bh_qs() as the wrapper of rcu_preempt_qs() is called
in some scenarios where irq is enabled, like this path,

do_single_softirq()
    |
    + local_irq_enable();
    + handle_softirq()
    |    |
    |    + rcu_bh_qs()
    |        |
    |        + rcu_preempt_qs()
    |
    + local_irq_disable()

So here we'd better disable irq directly inside of rcu_bh_qs() to
fix this, otherwise the kernel may be freezable sometimes as
observed. And especially this way is also kind and safe for the
potential rcu_bh_qs() usage elsewhere in the future.

Cc: stable-rt@vger.kernel.org
Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com>
Signed-off-by: Bin Jiang <bin.jiang@windriver.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
This commit is contained in:
Tiejun Chen 2013-12-18 17:51:49 +08:00 committed by Alibek Omarov
parent 010ec70629
commit 22775b1bef
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
kernel/rcu/tree.c
View File

@ -204,7 +204,12 @@ static void rcu_preempt_qs(int cpu);
void rcu_bh_qs(int cpu)
{
unsigned long flags;
/* Callers to this function, rcu_preempt_qs(), must disable irqs. */
local_irq_save(flags);
rcu_preempt_qs(cpu);
local_irq_restore(flags);
}
#else
void rcu_bh_qs(int cpu)