fs: Fix S_NOSEC handling
file_remove_suid() could mistakenly set S_NOSEC inode bit when root was modifying the file. As a result following writes to the file by ordinary user would avoid clearing suid or sgid bits. Fix the bug by checking actual mode bits before setting S_NOSEC. CC: stable@vger.kernel.org Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
parent
c0c3a718e3
commit
2426f39100
|
@ -1706,8 +1706,8 @@ int file_remove_suid(struct file *file)
|
||||||
error = security_inode_killpriv(dentry);
|
error = security_inode_killpriv(dentry);
|
||||||
if (!error && killsuid)
|
if (!error && killsuid)
|
||||||
error = __remove_suid(dentry, killsuid);
|
error = __remove_suid(dentry, killsuid);
|
||||||
if (!error && (inode->i_sb->s_flags & MS_NOSEC))
|
if (!error)
|
||||||
inode->i_flags |= S_NOSEC;
|
inode_has_no_xattr(inode);
|
||||||
|
|
||||||
return error;
|
return error;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue