phy: spear1310-miphy: Return proper error for spear1310_miphy_xlate
The of_xlate callback should return ERR_PTR on error. Signed-off-by: Axel Lin <axel.lin@ingics.com> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
This commit is contained in:
parent
fbea230e78
commit
247e21c613
|
@ -192,14 +192,14 @@ static struct phy *spear1310_miphy_xlate(struct device *dev,
|
||||||
|
|
||||||
if (args->args_count < 1) {
|
if (args->args_count < 1) {
|
||||||
dev_err(dev, "DT did not pass correct no of args\n");
|
dev_err(dev, "DT did not pass correct no of args\n");
|
||||||
return NULL;
|
return ERR_PTR(-ENODEV);
|
||||||
}
|
}
|
||||||
|
|
||||||
priv->mode = args->args[0];
|
priv->mode = args->args[0];
|
||||||
|
|
||||||
if (priv->mode != SATA && priv->mode != PCIE) {
|
if (priv->mode != SATA && priv->mode != PCIE) {
|
||||||
dev_err(dev, "DT did not pass correct phy mode\n");
|
dev_err(dev, "DT did not pass correct phy mode\n");
|
||||||
return NULL;
|
return ERR_PTR(-ENODEV);
|
||||||
}
|
}
|
||||||
|
|
||||||
return priv->phy;
|
return priv->phy;
|
||||||
|
|
Loading…
Reference in New Issue