ceph: fix bogus endianness change in ceph_ioctl_set_layout
sparse says:
fs/ceph/ioctl.c💯28: warning: cast to restricted __le64
preferred_osd is a __s64 so we don't need to do any conversion. Also,
just remove the cast in ceph_ioctl_get_layout as it's not needed.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
This commit is contained in:
parent
7fea24c6d4
commit
24c149ad69
|
@ -25,7 +25,7 @@ static long ceph_ioctl_get_layout(struct file *file, void __user *arg)
|
||||||
l.stripe_count = ci->i_layout.stripe_count;
|
l.stripe_count = ci->i_layout.stripe_count;
|
||||||
l.object_size = ci->i_layout.object_size;
|
l.object_size = ci->i_layout.object_size;
|
||||||
l.data_pool = ci->i_layout.pool_id;
|
l.data_pool = ci->i_layout.pool_id;
|
||||||
l.preferred_osd = (s32)-1;
|
l.preferred_osd = -1;
|
||||||
if (copy_to_user(arg, &l, sizeof(l)))
|
if (copy_to_user(arg, &l, sizeof(l)))
|
||||||
return -EFAULT;
|
return -EFAULT;
|
||||||
}
|
}
|
||||||
|
@ -97,7 +97,7 @@ static long ceph_ioctl_set_layout(struct file *file, void __user *arg)
|
||||||
nl.data_pool = ci->i_layout.pool_id;
|
nl.data_pool = ci->i_layout.pool_id;
|
||||||
|
|
||||||
/* this is obsolete, and always -1 */
|
/* this is obsolete, and always -1 */
|
||||||
nl.preferred_osd = le64_to_cpu(-1);
|
nl.preferred_osd = -1;
|
||||||
|
|
||||||
err = __validate_layout(mdsc, &nl);
|
err = __validate_layout(mdsc, &nl);
|
||||||
if (err)
|
if (err)
|
||||||
|
|
Loading…
Reference in New Issue