cifs: Read buffer overflow
Check whether index is within bounds before testing the element. Acked-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: Steve French <sfrench@us.ibm.com>
This commit is contained in:
parent
4486d6ede1
commit
24e2fb615f
|
@ -44,7 +44,7 @@ cifs_ucs2_bytes(const __le16 *from, int maxbytes,
|
||||||
int maxwords = maxbytes / 2;
|
int maxwords = maxbytes / 2;
|
||||||
char tmp[NLS_MAX_CHARSET_SIZE];
|
char tmp[NLS_MAX_CHARSET_SIZE];
|
||||||
|
|
||||||
for (i = 0; from[i] && i < maxwords; i++) {
|
for (i = 0; i < maxwords && from[i]; i++) {
|
||||||
charlen = codepage->uni2char(le16_to_cpu(from[i]), tmp,
|
charlen = codepage->uni2char(le16_to_cpu(from[i]), tmp,
|
||||||
NLS_MAX_CHARSET_SIZE);
|
NLS_MAX_CHARSET_SIZE);
|
||||||
if (charlen > 0)
|
if (charlen > 0)
|
||||||
|
|
Loading…
Reference in New Issue