f2fs: fix a bug of inheriting default ACL from parent
Introduced by a6dda0e63e
"f2fs: use generic posix ACL infrastructure".
When testing default acl, gets in recent kernel (3.19.0-rc5),
user::rwx
group::r-x
other::r-x
default:user::rwx
default:group::r-x
default:group:root:rwx
default😷:rwx
default:other::r-x
]# getfacl testdir/
user::rwx
group::rwx
// missing an acl "group:root:rwx" inherited from parent
other::r-x
default:user::rwx
default:group::r-x
default:group:root:rwx
default😷:rwx
default:other::r-x
Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
Reviewed-by: Chao Yu <chao2.yu@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
This commit is contained in:
parent
f28e503429
commit
3b6709b771
|
@ -396,7 +396,7 @@ int f2fs_init_acl(struct inode *inode, struct inode *dir, struct page *ipage,
|
||||||
posix_acl_release(default_acl);
|
posix_acl_release(default_acl);
|
||||||
}
|
}
|
||||||
if (acl) {
|
if (acl) {
|
||||||
if (error)
|
if (!error)
|
||||||
error = __f2fs_set_acl(inode, ACL_TYPE_ACCESS, acl,
|
error = __f2fs_set_acl(inode, ACL_TYPE_ACCESS, acl,
|
||||||
ipage);
|
ipage);
|
||||||
posix_acl_release(acl);
|
posix_acl_release(acl);
|
||||||
|
|
Loading…
Reference in New Issue