From 3b9c55efb23ebc6edb8190d9afa78b311e49404f Mon Sep 17 00:00:00 2001 From: Chunyan Zhang Date: Wed, 25 Mar 2020 16:14:27 +0800 Subject: [PATCH] tty: serial: make SERIAL_SPRD depend on COMMON_CLK kbuild-test reported an error: config: mips-randconfig-a001-20200321 ... >> drivers/tty/serial/sprd_serial.c:1175: undefined reference to `clk_set_parent' Because some mips Kconfig selects HAVE_CLK but not COMMON_CLK and no clk_set_parent implemented, so the error was exposed. So adding dependence on COMMON_CLK can fix this issue. Fixes: 7ba87cfec71a ("tty: serial: make SERIAL_SPRD not depend on ARCH_SPRD") Reported-by: kbuild test robot Signed-off-by: Chunyan Zhang Link: https://lore.kernel.org/r/20200325081427.20312-1-zhang.lyra@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index aa6d82175491..d6644f3d81fc 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -1445,6 +1445,7 @@ config SERIAL_MEN_Z135 config SERIAL_SPRD tristate "Support for Spreadtrum serial" select SERIAL_CORE + depends on COMMON_CLK help This enables the driver for the Spreadtrum's serial.