hwmon: (i5k_amb) use permission-specific DEVICE_ATTR variants
Use DEVICE_ATTR_RO for read-only attributes. This simplifies the source code, improves readbility, and reduces the chance of inconsistencies. The conversion was done automatically using coccinelle. It was validated by compiling both the old and the new source code and comparing its text, data, and bss size. Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> [groeck: Updated description] Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
parent
3eb52cfdf5
commit
3edf03b3c1
|
@ -114,14 +114,14 @@ struct i5k_amb_data {
|
||||||
unsigned int num_attrs;
|
unsigned int num_attrs;
|
||||||
};
|
};
|
||||||
|
|
||||||
static ssize_t show_name(struct device *dev, struct device_attribute *devattr,
|
static ssize_t name_show(struct device *dev, struct device_attribute *devattr,
|
||||||
char *buf)
|
char *buf)
|
||||||
{
|
{
|
||||||
return sprintf(buf, "%s\n", DRVNAME);
|
return sprintf(buf, "%s\n", DRVNAME);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
static DEVICE_ATTR(name, S_IRUGO, show_name, NULL);
|
static DEVICE_ATTR_RO(name);
|
||||||
|
|
||||||
static struct platform_device *amb_pdev;
|
static struct platform_device *amb_pdev;
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue