OpenE2K/linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

leds: pwm: Support ACPI via firmware-node framework

Browse Source 
DT specific handling is replaced by firmware-node abstration to support
ACPI specification of PWM LEDS.

Example ASL:
Device (PWML)
{
    Name (_HID, "PRP0001")
    Name (_DSD, Package () {
          ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
          Package () { Package () {"compatible",
                                    Package () {"pwm-leds"}}}})

    Device (PWL0)
    {
        Name (_HID, "PRP0001")
        Name (_DSD, Package () {
              ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
              Package () {
                           Package () {"label", "alarm-led"},
                           Package () {"pwms", Package ()
                                       {\_SB_.PCI0.PWM, 0, 600000, 0}},
                           Package () {"linux,default-state", "off"}}})
    }
}

Signed-off-by: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
This commit is contained in:
Nikolaus Voss 2019-06-12 10:36:08 +02:00 committed by Thierry Reding
parent 4a6ef8e37c
commit 3f467ebe9e
1 changed files with 27 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
drivers/leds/leds-pwm.c
View File

@ -75,7 +75,7 @@ static inline size_t sizeof_pwm_leds_priv(int num_leds)
} }
static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv, static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv,
struct led_pwm *led, struct device_node *child) struct led_pwm *led, struct fwnode_handle *fwnode)
{ {
struct led_pwm_data *led_data = &priv->leds[priv->num_leds]; struct led_pwm_data *led_data = &priv->leds[priv->num_leds];
struct pwm_args pargs; struct pwm_args pargs;
@ -88,8 +88,8 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv,
led_data->cdev.max_brightness = led->max_brightness; led_data->cdev.max_brightness = led->max_brightness;
led_data->cdev.flags = LED_CORE_SUSPENDRESUME; led_data->cdev.flags = LED_CORE_SUSPENDRESUME;
if (child) if (fwnode)
led_data->pwm = devm_of_pwm_get(dev, child, NULL); led_data->pwm = devm_fwnode_pwm_get(dev, fwnode, NULL);
else else
led_data->pwm = devm_pwm_get(dev, led->name); led_data->pwm = devm_pwm_get(dev, led->name);
if (IS_ERR(led_data->pwm)) { if (IS_ERR(led_data->pwm)) {
@ -114,7 +114,8 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv,
if (!led_data->period && (led->pwm_period_ns > 0)) if (!led_data->period && (led->pwm_period_ns > 0))
led_data->period = led->pwm_period_ns; led_data->period = led->pwm_period_ns;
ret = devm_of_led_classdev_register(dev, child, &led_data->cdev); ret = devm_of_led_classdev_register(dev, to_of_node(fwnode),
&led_data->cdev);
if (ret == 0) { if (ret == 0) {
priv->num_leds++; priv->num_leds++;
led_pwm_set(&led_data->cdev, led_data->cdev.brightness); led_pwm_set(&led_data->cdev, led_data->cdev.brightness);
@ -126,27 +127,35 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv,
return ret; return ret;
} }
static int led_pwm_create_of(struct device *dev, struct led_pwm_priv *priv) static int led_pwm_create_fwnode(struct device *dev, struct led_pwm_priv *priv)
{ {
struct device_node *child; struct fwnode_handle *fwnode;
struct led_pwm led; struct led_pwm led;
int ret = 0; int ret = 0;
memset(&led, 0, sizeof(led)); memset(&led, 0, sizeof(led));
for_each_child_of_node(dev->of_node, child) { device_for_each_child_node(dev, fwnode) {
led.name = of_get_property(child, "label", NULL) ? : ret = fwnode_property_read_string(fwnode, "label", &led.name);
child->name; if (ret && is_of_node(fwnode))
led.name = to_of_node(fwnode)->name;
led.default_trigger = of_get_property(child, if (!led.name) {
"linux,default-trigger", NULL); fwnode_handle_put(fwnode);
led.active_low = of_property_read_bool(child, "active-low"); return -EINVAL;
of_property_read_u32(child, "max-brightness", }
&led.max_brightness);
ret = led_pwm_add(dev, priv, &led, child); fwnode_property_read_string(fwnode, "linux,default-trigger",
&led.default_trigger);
led.active_low = fwnode_property_read_bool(fwnode,
"active-low");
fwnode_property_read_u32(fwnode, "max-brightness",
&led.max_brightness);
ret = led_pwm_add(dev, priv, &led, fwnode);
if (ret) { if (ret) {
of_node_put(child); fwnode_handle_put(fwnode);
break; break;
} }
} }
@ -164,7 +173,7 @@ static int led_pwm_probe(struct platform_device *pdev)
if (pdata) if (pdata)
count = pdata->num_leds; count = pdata->num_leds;
else else
count = of_get_child_count(pdev->dev.of_node); count = device_get_child_node_count(&pdev->dev);
if (!count) if (!count)
return -EINVAL; return -EINVAL;
@ -182,7 +191,7 @@ static int led_pwm_probe(struct platform_device *pdev)
break; break;
} }
} else { } else {
ret = led_pwm_create_of(&pdev->dev, priv); ret = led_pwm_create_fwnode(&pdev->dev, priv);
} }
if (ret) if (ret)