OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

V4L/DVB: drivers/media: Eliminate a NULL pointer dereference 

In each case, the print involves dereferencing a value that is NULL or is
near NULL.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression E,E1;
identifier f;
statement S1,S2,S3;
@@

if ((E == NULL && ...) || ...)
{
  ... when != if (...) S1 else S2
      when != E = E1
* E->f
  ... when any
  return ...;
}
else S3
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Julia Lawall 2010-05-27 09:36:45 -03:00 committed by Mauro Carvalho Chehab
parent 5c331fc8c1
commit 4202066c69
3 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/media/dvb/firewire/firedtv-1394.c
View File

@ -58,7 +58,7 @@ static void rawiso_activity_cb(struct hpsb_iso *iso)
num = hpsb_iso_n_ready(iso);
if (!fdtv) {
dev_err(fdtv->device, "received at unknown iso channel\n");
pr_err("received at unknown iso channel\n");
goto out;
}

2
drivers/media/video/hdpvr/hdpvr-video.c
View File

@ -366,7 +366,7 @@ static int hdpvr_open(struct file *file)
dev = (struct hdpvr_device *)video_get_drvdata(video_devdata(file));
if (!dev) {
v4l2_err(&dev->v4l2_dev, "open failing with with ENODEV\n");
pr_err("open failing with with ENODEV\n");
retval = -ENODEV;
goto err;
}

3
drivers/media/video/usbvision/usbvision-video.c
View File

@ -1671,8 +1671,7 @@ static void __devexit usbvision_disconnect(struct usb_interface *intf)
PDEBUG(DBG_PROBE, "");
if (usbvision == NULL) {
dev_err(&usbvision->dev->dev,
"%s: usb_get_intfdata() failed\n", __func__);
pr_err("%s: usb_get_intfdata() failed\n", __func__);
return;
}