x86: hw_breakpoint.c arch_check_va_in_kernelspace and hw_breakpoint_handler should be static
arch_check_va_in_kernelspace() and hw_breakpoint_handler() is used only by same file so it should be static. Also fixed non-ANSI function declaration of function 'arch_uninstall_thread_hw_breakpoint' Fixed following sparse warnings : arch/x86/kernel/hw_breakpoint.c:124:42: warning: non-ANSI function declaration of function 'arch_uninstall_thread_hw_breakpoint' arch/x86/kernel/hw_breakpoint.c:169:5: warning: symbol 'arch_check_va_in_kernelspace' was not declared. Should it be static? arch/x86/kernel/hw_breakpoint.c:313:15: warning: symbol 'hw_breakpoint_handler' was not declared. Should it be static? Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com> Cc: Alan Stern <stern@rowland.harvard.edu> Cc: "K.Prasad" <prasad@linux.vnet.ibm.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> LKML-Reference: <1245230059.2662.4.camel@ht.satnam> Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
parent
eadb8a091b
commit
4555835b70
|
@ -121,7 +121,7 @@ void arch_install_thread_hw_breakpoint(struct task_struct *tsk)
|
|||
/*
|
||||
* Install the debug register values for just the kernel, no thread.
|
||||
*/
|
||||
void arch_uninstall_thread_hw_breakpoint()
|
||||
void arch_uninstall_thread_hw_breakpoint(void)
|
||||
{
|
||||
/* Clear the user-space portion of debugreg7 by setting only kdr7 */
|
||||
set_debugreg(kdr7, 7);
|
||||
|
@ -166,7 +166,7 @@ int arch_check_va_in_userspace(unsigned long va, u8 hbp_len)
|
|||
/*
|
||||
* Check for virtual address in kernel space.
|
||||
*/
|
||||
int arch_check_va_in_kernelspace(unsigned long va, u8 hbp_len)
|
||||
static int arch_check_va_in_kernelspace(unsigned long va, u8 hbp_len)
|
||||
{
|
||||
unsigned int len;
|
||||
|
||||
|
@ -310,7 +310,7 @@ void arch_flush_thread_hw_breakpoint(struct task_struct *tsk)
|
|||
* NOTIFY_STOP returned for all other cases
|
||||
*
|
||||
*/
|
||||
int __kprobes hw_breakpoint_handler(struct die_args *args)
|
||||
static int __kprobes hw_breakpoint_handler(struct die_args *args)
|
||||
{
|
||||
int i, cpu, rc = NOTIFY_STOP;
|
||||
struct hw_breakpoint *bp;
|
||||
|
|
Loading…
Reference in New Issue