f2fs: fix use-after-free issue
[ Upstream commit 99c787cfd2
]
During umount, f2fs_put_super() unregisters procfs entries after
f2fs_destroy_segment_manager(), it may cause use-after-free
issue when umount races with procfs accessing, fix it by relocating
f2fs_unregister_sysfs().
[Chao Yu: change commit title/message a bit]
Signed-off-by: Li Guifu <bluce.liguifu@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
4cba879430
commit
45e30390f5
|
@ -1075,6 +1075,9 @@ static void f2fs_put_super(struct super_block *sb)
|
||||||
int i;
|
int i;
|
||||||
bool dropped;
|
bool dropped;
|
||||||
|
|
||||||
|
/* unregister procfs/sysfs entries in advance to avoid race case */
|
||||||
|
f2fs_unregister_sysfs(sbi);
|
||||||
|
|
||||||
f2fs_quota_off_umount(sb);
|
f2fs_quota_off_umount(sb);
|
||||||
|
|
||||||
/* prevent remaining shrinker jobs */
|
/* prevent remaining shrinker jobs */
|
||||||
|
@ -1138,8 +1141,6 @@ static void f2fs_put_super(struct super_block *sb)
|
||||||
|
|
||||||
kvfree(sbi->ckpt);
|
kvfree(sbi->ckpt);
|
||||||
|
|
||||||
f2fs_unregister_sysfs(sbi);
|
|
||||||
|
|
||||||
sb->s_fs_info = NULL;
|
sb->s_fs_info = NULL;
|
||||||
if (sbi->s_chksum_driver)
|
if (sbi->s_chksum_driver)
|
||||||
crypto_free_shash(sbi->s_chksum_driver);
|
crypto_free_shash(sbi->s_chksum_driver);
|
||||||
|
|
Loading…
Reference in New Issue