cifs: using strlcpy instead of strncpy
for NUL terminated string, need alway set '\0' in the end. Signed-off-by: Zhao Hongjiang <zhaohongjiang@huawei.com> Signed-off-by: Steve French <smfrench@gmail.com>
This commit is contained in:
parent
be7457d388
commit
46b51d0835
|
@ -3732,7 +3732,7 @@ CIFSTCon(const unsigned int xid, struct cifs_ses *ses,
|
||||||
}
|
}
|
||||||
bcc_ptr += length + 1;
|
bcc_ptr += length + 1;
|
||||||
bytes_left -= (length + 1);
|
bytes_left -= (length + 1);
|
||||||
strncpy(tcon->treeName, tree, MAX_TREE_SIZE);
|
strlcpy(tcon->treeName, tree, sizeof(tcon->treeName));
|
||||||
|
|
||||||
/* mostly informational -- no need to fail on error here */
|
/* mostly informational -- no need to fail on error here */
|
||||||
kfree(tcon->nativeFileSystem);
|
kfree(tcon->nativeFileSystem);
|
||||||
|
|
|
@ -746,7 +746,7 @@ SMB2_tcon(const unsigned int xid, struct cifs_ses *ses, const char *tree,
|
||||||
tcon->tidStatus = CifsGood;
|
tcon->tidStatus = CifsGood;
|
||||||
tcon->need_reconnect = false;
|
tcon->need_reconnect = false;
|
||||||
tcon->tid = rsp->hdr.TreeId;
|
tcon->tid = rsp->hdr.TreeId;
|
||||||
strncpy(tcon->treeName, tree, MAX_TREE_SIZE);
|
strlcpy(tcon->treeName, tree, sizeof(tcon->treeName));
|
||||||
|
|
||||||
if ((rsp->Capabilities & SMB2_SHARE_CAP_DFS) &&
|
if ((rsp->Capabilities & SMB2_SHARE_CAP_DFS) &&
|
||||||
((tcon->share_flags & SHI1005_FLAGS_DFS) == 0))
|
((tcon->share_flags & SHI1005_FLAGS_DFS) == 0))
|
||||||
|
|
Loading…
Reference in New Issue