OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

net: netsec: remove superfluous if statement 

While freeing tx buffers the memory has to be unmapped if the packet was
an skb or was used for .ndo_xdp_xmit using the same arguments. Get rid
of the unneeded extra 'else if' statement

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Ilias Apalodimas 2019-07-10 00:14:48 +03:00 committed by David S. Miller
parent c099a40894
commit 4831539dce
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/ethernet/socionext/netsec.c
View File

@ -654,12 +654,12 @@ static bool netsec_clean_tx_dring(struct netsec_priv *priv)
eop = (entry->attr >> NETSEC_TX_LAST) & 1;
dma_rmb();
if (desc->buf_type == TYPE_NETSEC_SKB)
/* if buf_type is either TYPE_NETSEC_SKB or
* TYPE_NETSEC_XDP_NDO we mapped it
*/
if (desc->buf_type != TYPE_NETSEC_XDP_TX)
dma_unmap_single(priv->dev, desc->dma_addr, desc->len,
DMA_TO_DEVICE);
else if (desc->buf_type == TYPE_NETSEC_XDP_NDO)
dma_unmap_single(priv->dev, desc->dma_addr,
desc->len, DMA_TO_DEVICE);
if (!eop)
goto next;