OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

block: submit_bh() inadvertently discards barrier flag on a sync write 

Reported by Milan Broz <mbroz@redhat.com>, commit 18ce3751 inadvertently
made submit_bh() discard the barrier bit for a WRITE_SYNC request. Fix
that up.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
This commit is contained in:
Jens Axboe 2008-08-22 10:00:36 +02:00
parent a4a778971b
commit 48fd4f93a0
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
fs/buffer.c
View File

@ -2926,14 +2926,17 @@ int submit_bh(int rw, struct buffer_head * bh)
BUG_ON(!buffer_mapped(bh)); BUG_ON(!buffer_mapped(bh));
BUG_ON(!bh->b_end_io); BUG_ON(!bh->b_end_io);
if (buffer_ordered(bh) && (rw == WRITE)) /*
rw = WRITE_BARRIER; * Mask in barrier bit for a write (could be either a WRITE or a
* WRITE_SYNC
*/
if (buffer_ordered(bh) && (rw & WRITE))
rw |= WRITE_BARRIER;
/* /*
* Only clear out a write error when rewriting, should this * Only clear out a write error when rewriting
* include WRITE_SYNC as well?
*/ */
if (test_set_buffer_req(bh) && (rw == WRITE || rw == WRITE_BARRIER)) if (test_set_buffer_req(bh) && (rw & WRITE))
clear_buffer_write_io_error(bh); clear_buffer_write_io_error(bh);
/* /*